Skip to content

Clean up Alignment Generation

Nicholas Styles requested to merge nstyles/athena:rndmNumberFix into main

When testing some things for ITk misalignment with @xilin I noticed that when running CreateMisalignment ITk.py with mode 2 (random misalignments) I obtain 0.0 for all misalignments. (The standard CreateMisalignments would also behave the same).

I think this is because even when selecting the random mode, the random number was using the initial alignment parameters (x,y,z,alpha,beta,gamma) for the width of the gaussian from which the random numbers are drawn. This meant that when taking the default configuration (which sets all these initial alignment parameters as 0), all random numbers were always 0.0.

Admittedly this is easy enough to fix in the configuration of the job, but it is not a priori very clear that the same configurables used to set the constant shifts for mode 1 would also determine the widths of the random shifts, nor is it very user-friendly that the default configuration gives "random shifts" that are by construction 0.0.

New parameters have been added to separately control the widths, with a default setting of 100 microns.

In addition there is some general clean-up done.

FYI @ncalace @cgrefe @sroe

Edited by Nicholas Styles

Merge request reports