MuonTrackingGeometry - Copy the inert material onto the conditions store DetMgr

Hi everybody,

In the context of ATLASRECTS-6446, we discovered with some pudding that the readout geometry in the Conditions store does not contain the passive material. The solution at that time was simply to use the geometry from the detStore() as the passive volume don't care about the alignment of the active ones. This MR is the attempt to attach the passive nodes to the second readout geomerty. To avoid a deep copy of the corresponding subtrees, I've introduced a GeoPhysVolProxy auxillary class which can be appened to the det mgrs TreeTop. Don't know whether that's the best solution - Tagging: @tsulaia, @boudreau, @rbianchi, @todorova.

@goblirsc, @sroe, @pscholer, @pgadow

Prerequisite to fix the material: ATLASRECTS-7840

added full-integration-tests full-unit-tests labels

This merge request affects 4 packages:

• DetectorDescription/GeoModel/GeoModelUtilities
• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry
• MuonSpectrometer/MuonGeoModel

Affected files list will not be printed in this case

Adding @apsallid ,@rosati ,@jojungge ,@stavrop ,@kluit ,@pscholer ,@rbianchi as watchers

added Geometry MuonSpectrometer main review-pending-level-1 labels

changed the description

changed the description

added Run3-DataReco-output-changed Run3-MCReco-output-changed labels

CI Result FAILURE (hash 965c6024)

	Athena	AthSimulation	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1352]

added 1 commit

• f782ba28 - Ãanother test

Compare with previous version

removed Run3-DataReco-output-changed label

removed Run3-MCReco-output-changed label

This merge request affects 4 packages:

• DetectorDescription/GeoModel/GeoModelUtilities
• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry
• MuonSpectrometer/MuonGeoModel

Affected files list will not be printed in this case

Adding @pscholer ,@rbianchi ,@kluit ,@rosati ,@stavrop ,@apsallid ,@jojungge as watchers

added Run3-DataReco-output-changed Run3-MCReco-output-changed labels

CI Result FAILURE (hash f782ba28)

	Athena	AthSimulation	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1356]

added review-user-action-required label

removed review-pending-level-1 label

Hi @jojungge,

To avoid a deep copy of the corresponding subtrees

I'm probably missing something obvious here, but why don't you simply take a pointer to the passive material volume and append it to the tree top of the manager retrieved from the condition store? No deep copy will happen in this case.

I only retrieve a const pointer while graph->add requires a non-const one ;-).

added 20 commits

• f782ba28...7a751f72 - 17 commits from branch atlas:main
• 445e35e4 - Copy the inert matetrial onto the conditions store det mgr
• 027bfbe3 - Ãanother test
• 6789309b - Use const cast instead

Compare with previous version

This merge request affects 3 packages:

• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry
• MuonSpectrometer/MuonGeoModel

Affected files list will not be printed in this case

Adding @jojungge ,@pscholer ,@apsallid ,@kluit ,@stavrop ,@rosati as watchers

added review-pending-level-1 label and removed review-user-action-required label

removed Run3-DataReco-output-changed label

removed Run3-MCReco-output-changed label

added 1 commit

• a3e3cafa - Remove debug message

Compare with previous version

This merge request affects 3 packages:

• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry
• MuonSpectrometer/MuonGeoModel

Affected files list will not be printed in this case

Adding @stavrop ,@rosati ,@pscholer ,@jojungge ,@kluit ,@apsallid as watchers

added Run3-DataReco-output-changed Run3-MCReco-output-changed labels

CI Result FAILURE (hash 6789309b)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1455]

CI Result FAILURE (hash a3e3cafa)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1457]

resolved all threads

mentioned in merge request GeoModelDev/GeoModel!222 (merged)

added review-user-action-required label

removed review-pending-level-1 label

added 289 commits

• a3e3cafa...5f8f4a79 - 284 commits from branch atlas:main
• 2212af17 - Copy the inert matetrial onto the conditions store det mgr
• 3d41e675 - Ãanother test
• 35b6116a - Use const cast instead
• d8d2fc70 - Remove debug message
• 8872b2d3 - Stonjek

Compare with previous version

removed Run3-DataReco-output-changed label

removed Run3-MCReco-output-changed label

This merge request affects 3 packages:

• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry
• MuonSpectrometer/MuonGeoModel

Affected files list will not be printed in this case

Adding @pscholer ,@jojungge ,@stavrop ,@apsallid ,@rosati ,@kluit as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI integration tests for projects Athena,AthSimulation are cancelled because of compilation error(s)

CI Result FAILURE (hash 8872b2d3)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 11
AthSimulation: number of compilation errors 1, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1755]

added 1 commit

• 7024e613 - Apply 3 suggestion(s) to 1 file(s)

Compare with previous version

Jenkins please retry a build

This merge request affects 3 packages:

• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
• MuonSpectrometer/MuonDetDescr/MuonTrackingGeometry
• MuonSpectrometer/MuonGeoModel

Affected files list will not be printed in this case

Adding @rosati ,@jojungge ,@apsallid ,@pscholer ,@stavrop ,@kluit as watchers

added Run3-DataReco-output-changed Run3-MCReco-output-changed labels

CI Result FAILURE (hash 7024e613)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1785]

Related to the above comments, are the updated references forthcoming?

-- James for L1

added review-user-action-required label and removed review-pending-level-1 label

marked this merge request as draft