Replace ConfigFactory used in block config with backend for text config so both are consistent.
To ensure that the block and text configuration are consistent, the TextConfig
class was refactored into a ConfigFacotry
and and TextConfig
classes. The ConfigFactory
class replaces the previous ConfigFactory
used in the block config so that the functions/classes for each block are the same for both and the way that they are configured are the same.
The block config implemented in FullCPAlgorithmsTest.py
was updated to use the new back-end.
Many of the functions previously used in TextConfig
class were moved to the ConfigSequence
class to make interacting with the blocks and block options easier.
The PileupReweighting
block for the text config was replaced with the code used for the block config.
The blocks stored in the TextConfig
class are now encapsulated in a class that can create an instance of the class/function associated with the block.
Addresses the following:
Merge request reports
Activity
assigned to @jolamber
requested review from @krumnack
added Analysis CPAlgorithms labels
added main label
added 1 commit
- cb401ffa - pass autoconfigFromFlags to PRW block from cmd
added 474 commits
-
cb401ffa...25797b74 - 472 commits from branch
atlas:main
- 077d827c - Replace ConfigFactory used in block config with backend for text config so both are consistent.
- 0d2599f9 - pass autoconfigFromFlags to PRW block from cmd
-
cb401ffa...25797b74 - 472 commits from branch
This merge request affects 1 package:
- PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig
This merge request affects 5 files:
- PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/data/for_compare.yaml
- PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/ConfigFactory.py
- PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/ConfigSequence.py
- PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/ConfigText.py
- PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/FullCPAlgorithmsTest.py
added analysis-review-required review-pending-level-1 labels
CI Result FAILURE (hash 0d2599f9)Athena AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1400]This merge request affects 1 package:
- PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig
This merge request affects 5 files:
- PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/data/for_compare.yaml
- PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/ConfigFactory.py
- PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/ConfigSequence.py
- PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/ConfigText.py
- PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig/python/FullCPAlgorithmsTest.py
CI Result FAILURE (hash 0d2599f9)Athena AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1410]added review-user-action-required label and removed review-pending-level-1 label
added 1 commit
- 9b5ae817 - update PHYSLITE.py block configuration to use common backend
- Resolved by Tadej Novak
I'm tagging @ravinab here as this should be thoroughly validated.