Skip to content

Solve clang warnings from ACTS and change logic of the has Column implementation

Carlo Varni requested to merge cvarni/athena:hasColumn into main

As noticed by @tadej there are several warnings coming from ACTS, but this then triggerd me some questions when I took a look at the code.

These are static variables of the xAOD::TrackState object, so by definition they should always be there. Not sure why we are comparing the individual values (float, double or std::size_t or whatever) against kInvalid which (if I recall it right) is numeric_limits<std::size_t>::max(). The variables will always be there with some default value.

As such, I'm simply changing the code to check the istate element in the xAOD::TrackStates container is there.

@pagessin @tbold

Edited by Carlo Varni

Merge request reports

Loading