Try to use C++20 starts_with

Try to use C++20 starts_with

Jenkins please retry the build

This merge request affects 22 packages:

• Control/AthContainers
• Control/AthContainersRoot
• Control/AthenaKernel
• Control/AthenaServices
• Control/IOVSvc
• Control/xAODRootAccess
• Database/APR/RootCollection
• Database/AthenaPOOL/AthenaPoolCnvSvc
• Database/AthenaPOOL/EventSelectorAthenaPool
• Database/RDBAccessSvc
• DetectorDescription/GeoModel/GeoModelSvc
• PhysicsAnalysis/AnalysisCommon/ReweightUtils
• PhysicsAnalysis/BPhys/BPhysTools
• PhysicsAnalysis/D3PDMaker/D3PDMakerReader
• PhysicsAnalysis/D3PDMaker/D3PDMakerUtils
• PhysicsAnalysis/TopPhys/xAOD/TopAnalysis
• PhysicsAnalysis/TopPhys/xAOD/TopConfiguration
• PhysicsAnalysis/TopPhys/xAOD/TopObjectSelectionTools
• TileCalorimeter/TileConditions
• Trigger/TrigMonitoring/TrigEgammaMonitoring
• Trigger/TrigSteer/TrigCompositeUtils
• Trigger/TrigT1/TrigT1MBTS

Affected files list will not be printed in this case

Adding @cgarvey ,@tadej ,@stavrop ,@harkusha ,@fernando ,@rosati ,@abarton ,@akraszna ,@solodkov ,@amete ,@jojungge ,@safarzad ,@pavol ,@gemmeren ,@tamartin ,@wwalko ,@dbakshig ,@ssnyder ,@skorn ,@jodafons ,@apsallid ,@eegidiop ,@iouri ,@ravinab ,@kluit ,@maszyman ,@thsteven ,@rbianchi ,@pscholer ,@mnowak as watchers

added Analysis AnalysisTop Core DQ Database Geometry MuonSpectrometer Tile Trigger analysis-review-required main labels

WARNING: big files (>100K) are found in the changeset

100K in file PhysicsAnalysis/D3PDMaker/D3PDMakerReader/src/CodeGenerator_v2.cxx

I know it's a draft, but... why?

If you'd like to make all parts rely on CxxUtils::starts_with(...) instead of using Boost, that's fine. Even if sort of wasted effort in my mind.

But C++20 is not on the table yet. And I don't think we should keep an MR that touches this many packages, open for ~2 months. (Until we can start using C++20 freely.)

CI integration tests for projects Athena,AthSimulation,AthGeneration,AthAnalysis are cancelled because of compilation error(s)

CI Result FAILURE (hash 486afb46)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 1
AthSimulation: number of compilation errors 1, warnings 27
AthGeneration: number of compilation errors 1, warnings 21
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 1, warnings 38
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 1731]

closed

marked this merge request as ready

changed the description

reopened

resolved all threads

Jenkins please retry the build

This merge request affects 22 packages:

• Control/AthContainers
• Control/AthContainersRoot
• Control/AthenaKernel
• Control/AthenaServices
• Control/IOVSvc
• Control/xAODRootAccess
• Database/APR/RootCollection
• Database/AthenaPOOL/AthenaPoolCnvSvc
• Database/AthenaPOOL/EventSelectorAthenaPool
• Database/RDBAccessSvc
• DetectorDescription/GeoModel/GeoModelSvc
• PhysicsAnalysis/AnalysisCommon/ReweightUtils
• PhysicsAnalysis/BPhys/BPhysTools
• PhysicsAnalysis/D3PDMaker/D3PDMakerReader
• PhysicsAnalysis/D3PDMaker/D3PDMakerUtils
• PhysicsAnalysis/TopPhys/xAOD/TopAnalysis
• PhysicsAnalysis/TopPhys/xAOD/TopConfiguration
• PhysicsAnalysis/TopPhys/xAOD/TopObjectSelectionTools
• TileCalorimeter/TileConditions
• Trigger/TrigMonitoring/TrigEgammaMonitoring
• Trigger/TrigSteer/TrigCompositeUtils
• Trigger/TrigT1/TrigT1MBTS

Affected files list will not be printed in this case

Adding @gemmeren ,@kluit ,@eegidiop ,@jlieberm ,@mnowak ,@apsallid ,@tadej ,@amete ,@abarton ,@ztao ,@jojungge ,@solodkov ,@iouri ,@harkusha ,@stavrop ,@ravinab ,@pavol ,@tamartin ,@mverissi ,@ssnyder ,@rbianchi ,@akraszna ,@cgarvey ,@pscholer ,@maszyman ,@fernando ,@efurtado ,@wwalko ,@thsteven ,@rosati ,@jodafons ,@dbakshig ,@skorn as watchers

added review-pending-level-1 label

WARNING: big files (>100K) are found in the changeset

100K in file PhysicsAnalysis/D3PDMaker/D3PDMakerReader/src/CodeGenerator_v2.cxx

added 1 commit

• bc358c9a - Compilation fixes

Compare with previous version

This merge request affects 22 packages:

• Control/AthContainers
• Control/AthContainersRoot
• Control/AthenaKernel
• Control/AthenaServices
• Control/IOVSvc
• Control/xAODRootAccess
• Database/APR/RootCollection
• Database/AthenaPOOL/AthenaPoolCnvSvc
• Database/AthenaPOOL/EventSelectorAthenaPool
• Database/RDBAccessSvc
• DetectorDescription/GeoModel/GeoModelSvc
• PhysicsAnalysis/AnalysisCommon/ReweightUtils
• PhysicsAnalysis/BPhys/BPhysTools
• PhysicsAnalysis/D3PDMaker/D3PDMakerReader
• PhysicsAnalysis/D3PDMaker/D3PDMakerUtils
• PhysicsAnalysis/TopPhys/xAOD/TopAnalysis
• PhysicsAnalysis/TopPhys/xAOD/TopConfiguration
• PhysicsAnalysis/TopPhys/xAOD/TopObjectSelectionTools
• TileCalorimeter/TileConditions
• Trigger/TrigMonitoring/TrigEgammaMonitoring
• Trigger/TrigSteer/TrigCompositeUtils
• Trigger/TrigT1/TrigT1MBTS

Affected files list will not be printed in this case

Adding @skorn ,@pscholer ,@cgarvey ,@solodkov ,@mverissi ,@apsallid ,@akraszna ,@ztao ,@mnowak ,@jojungge ,@ravinab ,@thsteven ,@harkusha ,@stavrop ,@gemmeren ,@iouri ,@dbakshig ,@kluit ,@tadej ,@wwalko ,@amete ,@abarton ,@ssnyder ,@maszyman ,@jodafons ,@fernando ,@eegidiop ,@efurtado ,@rosati ,@pavol ,@rbianchi ,@tamartin ,@jlieberm as watchers

WARNING: big files (>100K) are found in the changeset

100K in file PhysicsAnalysis/D3PDMaker/D3PDMakerReader/src/CodeGenerator_v2.cxx

AthGeneration at least is still building with gcc11/C++17. Before undrafting this, check the build status page to be sure nothing is still building main with gcc11.