Update HepMcParticleLink to handle creation with GenParticle::id() as well as barcodes
Transient HepMcParticleLink objects can now be built using either GenParticle::id() or the GenParticle barcode Attribute as the unique ID for the particle.
Eventually support for the barcode-based syntax will be restricted to legacy TP converter code. Until the migration is complete it is better to explicitly force the use of HepMcParticleLink::IS_BARCODE and HepMcParticleLink::IS_ID in the constructors in an attempt to ensure that the correct input is being provided.
HepMcParticleLink TP converters work for most use-cases. Some awkwardness for links to GenParticles that have been cut from the McEventCollection, mostly in deciding whether the unique ID is a barcode or an id. The value is preserved though, so the links can still be used to group EDM objects linked to the same truth particle.
Added HepMcParticleLink_p3 and HepMcParticleLinkCnv_p3 - based on GenParticle::id(). This works as well as the existing HepMcParticleLink_p1/p2 versions. New persistent versions of other EDM classes which depend on HepMcParticleLink will be added in future merge requests.
Output matches except for the output of DetailedTrackTruthBuilder. This relies on sorting by HepMcParticleLinks. The old implementation sorted based on barcode, whereas the new implementation sorts based on GenParticle::id(). In some cases (quasi-stable particle simulation) the barcode-based ordering of GenParticles sometimes differs from the id-based ordering. This means that some objects appear in a different order in the output containers. I don't think that this is an issue, but I need to discuss with Tracking experts.
Once these changes are merged then it becomes simpler to migrate clients to be id()-based. It should be possible to do this in multiple smaller merge requests.
Merge request reports
Activity
added 198 commits
-
0f859e94...cab1ec97 - 196 commits from branch
atlas:main - a5bc8c97 - HepMcParticleLink changes - UNTESTED
- 9f2fd055 - HepMcParticleLink unit tests passing
-
0f859e94...cab1ec97 - 196 commits from branch
added Generators InnerDetector Simulation main labels
Athena AthSimulation AthGeneration AthAnalysis externals 
cmake make 
tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
-
This merge request affects 20 packages:
- Generators/GeneratorObjects
- Generators/GeneratorObjectsTPCnv
- HighGranularityTimingDetector/HGTD_Digitization/HGTD_Digitization
- HighGranularityTimingDetector/HGTD_Digitization/HGTD_FastDigitization
- InnerDetector/InDetDigitization/BCM_Digitization
- InnerDetector/InDetDigitization/PixelDigitization
- InnerDetector/InDetDigitization/SCT_Digitization
- InnerDetector/InDetDigitization/StripDigitization
- InnerDetector/InDetDigitization/TRT_Digitization
- InnerDetector/InDetEventCnv/InDetSimEventTPCnv
- MuonSpectrometer/MuonDigitization/CSC_Digitization
- MuonSpectrometer/MuonDigitization/MDT_Digitization
- MuonSpectrometer/MuonDigitization/MM_Digitization
- MuonSpectrometer/MuonDigitization/RPC_Digitization
- MuonSpectrometer/MuonDigitization/TGC_Digitization
- MuonSpectrometer/MuonDigitization/sTGC_Digitization
- PhysicsAnalysis/TruthParticleID/McParticleTools
- Simulation/Tools/McEventCollectionFilter
- Tracking/TrkTools/TrkTruthCreatorTools
- Trigger/EFTracking/FPGATrackSim/FPGATrackSimSGInput
Affected files list will not be printed in this case
Adding @gemmeren ,@jojungge ,@pscholer ,@rosati ,@calfayan ,@goetz ,@dshope ,@cohm ,@sroe ,@stavrop ,@apsallid ,@kluit ,@jchapman ,@stsuno ,@battagl ,@lshan ,@cgrefe as watchers
added Analysis Digitization EFTracking HGTD MuonSpectrometer Tracking Trigger labels
-
Athena AthSimulation AthGeneration AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
added 76 commits
-
fea062bf...62ea7f1c - 66 commits from branch
atlas:main - efe1a2e4 - HepMcParticleLink changes - UNTESTED
- 6e6d29c9 - HepMcParticleLink unit tests passing
- a8efe27a - TP Converter Tests passing
- 6fce3571 - Initial version of HepMcParticleLink_p3 and TP converters
- 89f2a6b7 - Update existing TP converters in InDetSimEventTPCnv
- 937f8304 - McEventCollectionFilter: Still barcode-based, but using new HepMcParticleLink syntax
- 2be53ce8 - InDetDigitization: Update syntax to use new HepMcParticleLink syntax
- 7da063e8 - Migrate HGTD Digitization code to the new HepMcParticleLink syntax.
- d13bd87b - MuonDigitization: Update syntax to use new HepMcParticleLink syntax
- acad61d3 - Update other HepMcParticleLink clients to new syntax
Toggle commit list-
fea062bf...62ea7f1c - 66 commits from branch
added 5 commits
- 32329c99 - InDetDigitization: Update syntax to use new HepMcParticleLink syntax
- ed52548a - Migrate HGTD Digitization code to the new HepMcParticleLink syntax.
- a689036d - MuonDigitization: Update syntax to use new HepMcParticleLink syntax
- dbde688c - Update other HepMcParticleLink clients to new syntax
- 64573326 - FPGATrackSimSGInput temp fixes
Toggle commit listadded 1 commit
- 8d47d6e3 - TrackHelper: Update HepMcParticleLink syntax
added 1 commit
- 877e914f - Fixup HepMcParticleLink syntax in ISF InputConverter
removed Run2-FullSim-output-changed label
removed Run3-FullSim-output-changed label
removed Run3-HitsFilter-output-changed label
removed Run3-HitsMerge-output-changed label
removed Run4-FullSim-output-changed label
-
This merge request affects 22 packages:
- Generators/GeneratorObjects
- Generators/GeneratorObjectsTPCnv
- HighGranularityTimingDetector/HGTD_Digitization/HGTD_Digitization
- HighGranularityTimingDetector/HGTD_Digitization/HGTD_FastDigitization
- InnerDetector/InDetDigitization/BCM_Digitization
- InnerDetector/InDetDigitization/PixelDigitization
- InnerDetector/InDetDigitization/SCT_Digitization
- InnerDetector/InDetDigitization/StripDigitization
- InnerDetector/InDetDigitization/TRT_Digitization
- InnerDetector/InDetEventCnv/InDetSimEventTPCnv
- MuonSpectrometer/MuonDigitization/CSC_Digitization
- MuonSpectrometer/MuonDigitization/MDT_Digitization
- MuonSpectrometer/MuonDigitization/MM_Digitization
- MuonSpectrometer/MuonDigitization/RPC_Digitization
- MuonSpectrometer/MuonDigitization/TGC_Digitization
- MuonSpectrometer/MuonDigitization/sTGC_Digitization
- PhysicsAnalysis/TruthParticleID/McParticleTools
- Simulation/G4Sim/MCTruth
- Simulation/ISF/ISF_Core/ISF_Services
- Simulation/Tools/McEventCollectionFilter
- Tracking/TrkTools/TrkTruthCreatorTools
- Trigger/EFTracking/FPGATrackSim/FPGATrackSimSGInput
Affected files list will not be printed in this case
Adding @kluit ,@lmijovic ,@cgrefe ,@battagl ,@goetz ,@stsuno ,@apsallid ,@pscholer ,@sroe ,@gemmeren ,@cohm ,@stavrop ,@calfayan ,@jchapman ,@jojungge ,@dshope ,@rosati ,@lshan as watchers
-
Athena AthSimulation AthGeneration AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
added 1 commit
- 7e923c2d - Fixup HepMcParticleLink syntax in ISF InputConverter
-
This merge request affects 22 packages:
- Generators/GeneratorObjects
- Generators/GeneratorObjectsTPCnv
- HighGranularityTimingDetector/HGTD_Digitization/HGTD_Digitization
- HighGranularityTimingDetector/HGTD_Digitization/HGTD_FastDigitization
- InnerDetector/InDetDigitization/BCM_Digitization
- InnerDetector/InDetDigitization/PixelDigitization
- InnerDetector/InDetDigitization/SCT_Digitization
- InnerDetector/InDetDigitization/StripDigitization
- InnerDetector/InDetDigitization/TRT_Digitization
- InnerDetector/InDetEventCnv/InDetSimEventTPCnv
- MuonSpectrometer/MuonDigitization/CSC_Digitization
- MuonSpectrometer/MuonDigitization/MDT_Digitization
- MuonSpectrometer/MuonDigitization/MM_Digitization
- MuonSpectrometer/MuonDigitization/RPC_Digitization
- MuonSpectrometer/MuonDigitization/TGC_Digitization
- MuonSpectrometer/MuonDigitization/sTGC_Digitization
- PhysicsAnalysis/TruthParticleID/McParticleTools
- Simulation/G4Sim/MCTruth
- Simulation/ISF/ISF_Core/ISF_Services
- Simulation/Tools/McEventCollectionFilter
- Tracking/TrkTools/TrkTruthCreatorTools
- Trigger/EFTracking/FPGATrackSim/FPGATrackSimSGInput
Affected files list will not be printed in this case
Adding @jchapman ,@gemmeren ,@lshan ,@stsuno ,@sroe ,@stavrop ,@cgrefe ,@apsallid ,@lmijovic ,@jojungge ,@goetz ,@dshope ,@battagl ,@cohm ,@pscholer ,@calfayan ,@kluit ,@rosati as watchers
added Run3-HitsFilter-output-changed label
-
Athena AthSimulation AthGeneration AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Run3-HitsFilter output changes as we need a special way of flagging suppressed pile-up truth in the new scheme.
Py:diff-root INFO comparing tree [CollectionTree] in files: Py:diff-root INFO old: [/cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/WorkflowReferences/main/s4008/v1/myHITS.pool.root] Py:diff-root INFO new: [/home/jchapman/4clone/run/run_s4008/myHITS.pool.root] Py:diff-root INFO branches of interest: set() Py:diff-root INFO ignore leaves: ('Token', 'index_ref', '(.*)_timings\\.(.*)', '(.*)_mems\\.(.*)', '(.*)TrigCostContainer(.*)') Py:diff-root INFO enforce leaves: ('BCID',) Py:diff-root INFO leaves prefix: Py:diff-root INFO hacks: ('m_athenabarcode', 'm_token') Py:diff-root INFO entries: -1 Py:diff-root INFO mode: detailed Py:diff-root INFO error mode: resilient Py:diff-root INFO order trees: True Py:diff-root INFO exact branches: False Py:diff-root INFO comparing over [10] entries... Py:diff-root INFO comparing [38] leaves over entries... Py:diff-root INFO 000.SiHitCollection_p3_PixelHits.1.m_barcode.000.SiHitCollection_p3_PixelHits.1.m_barcode 2147483647 -> 0 => diff= [50.00000000%] Py:diff-root INFO 000.SiHitCollection_p3_SCT_Hits.1.m_barcode.000.SiHitCollection_p3_SCT_Hits.1.m_barcode 2147483647 -> 0 => diff= [50.00000000%] Py:diff-root INFO 005.SiHitCollection_p3_PixelHits.0.m_barcode.005.SiHitCollection_p3_PixelHits.0.m_barcode 2147483647 -> 0 => diff= [50.00000000%] Py:diff-root INFO 005.SiHitCollection_p3_SCT_Hits.1.m_barcode.005.SiHitCollection_p3_SCT_Hits.1.m_barcode 2147483647 -> 0 => diff= [50.00000000%] Py:diff-root INFO 008.SiHitCollection_p3_BCMHits.0.m_barcode.008.SiHitCollection_p3_BCMHits.0.m_barcode 2147483647 -> 0 => diff= [50.00000000%] Py:diff-root INFO 008.SiHitCollection_p3_PixelHits.1.m_barcode.008.SiHitCollection_p3_PixelHits.1.m_barcode 2147483647 -> 0 => diff= [50.00000000%] Py:diff-root INFO 008.SiHitCollection_p3_SCT_Hits.1.m_barcode.008.SiHitCollection_p3_SCT_Hits.1.m_barcode 2147483647 -> 0 => diff= [50.00000000%] Py:diff-root INFO 009.SiHitCollection_p3_PixelHits.0.m_barcode.009.SiHitCollection_p3_PixelHits.0.m_barcode 2147483647 -> 0 => diff= [50.00000000%] Py:diff-root INFO 009.SiHitCollection_p3_SCT_Hits.1.m_barcode.009.SiHitCollection_p3_SCT_Hits.1.m_barcode 2147483647 -> 0 => diff= [50.00000000%] Py:diff-root INFO 002.SiHitCollection_p3_PixelHits.0.m_barcode.002.SiHitCollection_p3_PixelHits.0.m_barcode 2147483647 -> 0 => diff= [50.00000000%] Py:diff-root INFO 002.SiHitCollection_p3_SCT_Hits.1.m_barcode.002.SiHitCollection_p3_SCT_Hits.1.m_barcode 2147483647 -> 0 => diff= [50.00000000%] Py:diff-root INFO 003.SiHitCollection_p3_PixelHits.1.m_barcode.003.SiHitCollection_p3_PixelHits.1.m_barcode 2147483647 -> 0 => diff= [50.00000000%] Py:diff-root INFO 003.SiHitCollection_p3_SCT_Hits.1.m_barcode.003.SiHitCollection_p3_SCT_Hits.1.m_barcode 2147483647 -> 0 => diff= [50.00000000%] Py:diff-root INFO Found [3148] identical leaves Py:diff-root INFO Found [13] different leaves Py:diff-root INFO [SiHitCollection_p3_BCMHits.m_barcode]: 1 leaves differ Py:diff-root INFO [SiHitCollection_p3_PixelHits.m_barcode]: 6 leaves differ Py:diff-root INFO [SiHitCollection_p3_SCT_Hits.m_barcode]: 6 leaves differ Py:diff-root ERROR files differ!added 158 commits
-
7e923c2d...8e2a6676 - 145 commits from branch
atlas:main - 8e2a6676...d148ef6a - 3 earlier commits
- 1ff763fd - Initial version of HepMcParticleLink_p3 and TP converters
- 9d9b8032 - Update existing TP converters in InDetSimEventTPCnv
- ae07d7c1 - McEventCollectionFilter: Still barcode-based, but using new HepMcParticleLink syntax
- 140e3791 - InDetDigitization: Update syntax to use new HepMcParticleLink syntax
- 6ef1add6 - Migrate HGTD Digitization code to the new HepMcParticleLink syntax.
- 193c844a - MuonDigitization: Update syntax to use new HepMcParticleLink syntax
- 129f9182 - Update other HepMcParticleLink clients to new syntax
- 7a94d6e7 - FPGATrackSimSGInput temp fixes
- 1282de0d - TrackHelper: Update HepMcParticleLink syntax
- 6bf098c9 - Fixup HepMcParticleLink syntax in ISF InputConverter
Toggle commit list-
7e923c2d...8e2a6676 - 145 commits from branch
added 637 commits
-
6bf098c9...25fa6bb5 - 624 commits from branch
atlas:main - 25fa6bb5...f0771b7b - 3 earlier commits
- faef9b2a - Initial version of HepMcParticleLink_p3 and TP converters
- 79c2c941 - Update existing TP converters in InDetSimEventTPCnv
- 8153303f - McEventCollectionFilter: Still barcode-based, but using new HepMcParticleLink syntax
- ff3aacdd - InDetDigitization: Update syntax to use new HepMcParticleLink syntax
- b62f7686 - Migrate HGTD Digitization code to the new HepMcParticleLink syntax.
- b5a69ab9 - MuonDigitization: Update syntax to use new HepMcParticleLink syntax
- 919ed37c - Update other HepMcParticleLink clients to new syntax
- 041c50ca - FPGATrackSimSGInput temp fixes
- 7da9f47c - TrackHelper: Update HepMcParticleLink syntax
- 9ac3900e - Fixup HepMcParticleLink syntax in ISF InputConverter
Toggle commit list-
6bf098c9...25fa6bb5 - 624 commits from branch
mentioned in merge request !66930 (merged)
Resolved by John Derek ChapmanFollowing the creation of the 24.0 branch from main, you should now decide whether this MR should target 24.0 or main, according to these guidelines agreed in the Software Weekly meeting: https://indico.cern.ch/event/1382755/attachments/2802320/4889268/BranchingGuidelines24.pdf If you decide that this MR should target 24.0, please re-direct it by editing and changing the target branch in the drop-down menu. If it should stay in main, please indicate this as a reply to this message. Remember that all MRs going into 24.0 will also be swept into main.
- Last reply by John Derek Chapman
added 1965 commits
-
9ac3900e...d381cecf - 1952 commits from branch
atlas:main - d381cecf...04cb114f - 3 earlier commits
- 09cd75eb - Initial version of HepMcParticleLink_p3 and TP converters
- 78c48cdb - Update existing TP converters in InDetSimEventTPCnv
- 8c2648e5 - McEventCollectionFilter: Still barcode-based, but using new HepMcParticleLink syntax
- 08732018 - InDetDigitization: Update syntax to use new HepMcParticleLink syntax
- f70dfb44 - Migrate HGTD Digitization code to the new HepMcParticleLink syntax.
- 9914e4cd - MuonDigitization: Update syntax to use new HepMcParticleLink syntax
- 172f0b45 - Update other HepMcParticleLink clients to new syntax
- 1d2ff520 - FPGATrackSimSGInput temp fixes
- 6702996b - TrackHelper: Update HepMcParticleLink syntax
- 8c2158c8 - Fixup HepMcParticleLink syntax in ISF InputConverter
Toggle commit list-
9ac3900e...d381cecf - 1952 commits from branch
added 496 commits
-
8c2158c8...610e95ce - 495 commits from branch
atlas:main - ba62897d - HepMcParticleLink adaption to GenParticle::id
-
8c2158c8...610e95ce - 495 commits from branch
-
This merge request affects 25 packages:
- Event/xAOD/xAODTruthCnv
- Generators/GeneratorObjects
- Generators/GeneratorObjectsTPCnv
- HighGranularityTimingDetector/HGTD_Digitization/HGTD_Digitization
- HighGranularityTimingDetector/HGTD_Digitization/HGTD_FastDigitization
- InnerDetector/InDetDigitization/BCM_Digitization
- InnerDetector/InDetDigitization/PixelDigitization
- InnerDetector/InDetDigitization/SCT_Digitization
- InnerDetector/InDetDigitization/StripDigitization
- InnerDetector/InDetDigitization/TRT_Digitization
- InnerDetector/InDetEventCnv/InDetSimEventTPCnv
- InnerDetector/InDetSimEvent
- MuonSpectrometer/MuonDigitization/CSC_Digitization
- MuonSpectrometer/MuonDigitization/MDT_Digitization
- MuonSpectrometer/MuonDigitization/MM_Digitization
- MuonSpectrometer/MuonDigitization/RPC_Digitization
- MuonSpectrometer/MuonDigitization/TGC_Digitization
- MuonSpectrometer/MuonDigitization/sTGC_Digitization
- MuonSpectrometer/MuonSimEvent
- PhysicsAnalysis/TruthParticleID/McParticleTools
- Simulation/G4Sim/MCTruth
- Simulation/ISF/ISF_Core/ISF_Services
- Simulation/Tools/McEventCollectionFilter
- Tracking/TrkTools/TrkTruthCreatorTools
- Trigger/EFTracking/FPGATrackSim/FPGATrackSimSGInput
Affected files list will not be printed in this case
Adding @kluit ,@jchapman ,@akraszna ,@rosati ,@lshan ,@jojungge ,@pscholer ,@cohm ,@gemmeren ,@goetz ,@calfayan ,@stavrop ,@apsallid ,@lmijovic ,@cgrefe ,@sroe ,@dshope ,@battagl ,@stsuno as watchers
added EDM analysis-review-required labels
removed Run3-HitsFilter-output-changed label
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
added 1 commit
- 39dee743 - HepMcParticleLink adaption to GenParticle::id
-
This merge request affects 25 packages:
- Event/xAOD/xAODTruthCnv
- Generators/GeneratorObjects
- Generators/GeneratorObjectsTPCnv
- HighGranularityTimingDetector/HGTD_Digitization/HGTD_Digitization
- HighGranularityTimingDetector/HGTD_Digitization/HGTD_FastDigitization
- InnerDetector/InDetDigitization/BCM_Digitization
- InnerDetector/InDetDigitization/PixelDigitization
- InnerDetector/InDetDigitization/SCT_Digitization
- InnerDetector/InDetDigitization/StripDigitization
- InnerDetector/InDetDigitization/TRT_Digitization
- InnerDetector/InDetEventCnv/InDetSimEventTPCnv
- InnerDetector/InDetSimEvent
- MuonSpectrometer/MuonDigitization/CSC_Digitization
- MuonSpectrometer/MuonDigitization/MDT_Digitization
- MuonSpectrometer/MuonDigitization/MM_Digitization
- MuonSpectrometer/MuonDigitization/RPC_Digitization
- MuonSpectrometer/MuonDigitization/TGC_Digitization
- MuonSpectrometer/MuonDigitization/sTGC_Digitization
- MuonSpectrometer/MuonSimEvent
- PhysicsAnalysis/TruthParticleID/McParticleTools
- Simulation/G4Sim/MCTruth
- Simulation/ISF/ISF_Core/ISF_Services
- Simulation/Tools/McEventCollectionFilter
- Tracking/TrkTools/TrkTruthCreatorTools
- Trigger/EFTracking/FPGATrackSim/FPGATrackSimSGInput
Affected files list will not be printed in this case
Adding @cgrefe ,@jojungge ,@stavrop ,@akraszna ,@goetz ,@sroe ,@gemmeren ,@dshope ,@jchapman ,@rosati ,@battagl ,@stsuno ,@lmijovic ,@pscholer ,@kluit ,@cohm ,@calfayan ,@apsallid ,@lshan as watchers
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
added 105 commits
-
39dee743...49794837 - 104 commits from branch
atlas:main - b7977e9c - HepMcParticleLink adaption to GenParticle::id
-
39dee743...49794837 - 104 commits from branch
-
This merge request affects 25 packages:
- Event/xAOD/xAODTruthCnv
- Generators/GeneratorObjects
- Generators/GeneratorObjectsTPCnv
- HighGranularityTimingDetector/HGTD_Digitization/HGTD_Digitization
- HighGranularityTimingDetector/HGTD_Digitization/HGTD_FastDigitization
- InnerDetector/InDetDigitization/BCM_Digitization
- InnerDetector/InDetDigitization/PixelDigitization
- InnerDetector/InDetDigitization/SCT_Digitization
- InnerDetector/InDetDigitization/StripDigitization
- InnerDetector/InDetDigitization/TRT_Digitization
- InnerDetector/InDetEventCnv/InDetSimEventTPCnv
- InnerDetector/InDetSimEvent
- MuonSpectrometer/MuonDigitization/CSC_Digitization
- MuonSpectrometer/MuonDigitization/MDT_Digitization
- MuonSpectrometer/MuonDigitization/MM_Digitization
- MuonSpectrometer/MuonDigitization/RPC_Digitization
- MuonSpectrometer/MuonDigitization/TGC_Digitization
- MuonSpectrometer/MuonDigitization/sTGC_Digitization
- MuonSpectrometer/MuonSimEvent
- PhysicsAnalysis/TruthParticleID/McParticleTools
- Simulation/G4Sim/MCTruth
- Simulation/ISF/ISF_Core/ISF_Services
- Simulation/Tools/McEventCollectionFilter
- Tracking/TrkTools/TrkTruthCreatorTools
- Trigger/EFTracking/FPGATrackSim/FPGATrackSimSGInput
Affected files list will not be printed in this case
Adding @akraszna ,@goetz ,@jojungge ,@kluit ,@rosati ,@dshope ,@lshan ,@cgrefe ,@stsuno ,@calfayan ,@gemmeren ,@jchapman ,@stavrop ,@sroe ,@battagl ,@cohm ,@lmijovic ,@apsallid ,@pscholer as watchers
added Run2-MCReco-output-changed Run3-MCReco-output-changed labels
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
added 1 commit
- f0dedad9 - HepMcParticleLink adaption to GenParticle::id
-
This merge request affects 25 packages:
- Event/xAOD/xAODTruthCnv
- Generators/GeneratorObjects
- Generators/GeneratorObjectsTPCnv
- HighGranularityTimingDetector/HGTD_Digitization/HGTD_Digitization
- HighGranularityTimingDetector/HGTD_Digitization/HGTD_FastDigitization
- InnerDetector/InDetDigitization/BCM_Digitization
- InnerDetector/InDetDigitization/PixelDigitization
- InnerDetector/InDetDigitization/SCT_Digitization
- InnerDetector/InDetDigitization/StripDigitization
- InnerDetector/InDetDigitization/TRT_Digitization
- InnerDetector/InDetEventCnv/InDetSimEventTPCnv
- InnerDetector/InDetSimEvent
- MuonSpectrometer/MuonDigitization/CSC_Digitization
- MuonSpectrometer/MuonDigitization/MDT_Digitization
- MuonSpectrometer/MuonDigitization/MM_Digitization
- MuonSpectrometer/MuonDigitization/RPC_Digitization
- MuonSpectrometer/MuonDigitization/TGC_Digitization
- MuonSpectrometer/MuonDigitization/sTGC_Digitization
- MuonSpectrometer/MuonSimEvent
- PhysicsAnalysis/TruthParticleID/McParticleTools
- Simulation/G4Sim/MCTruth
- Simulation/ISF/ISF_Core/ISF_Services
- Simulation/Tools/McEventCollectionFilter
- Tracking/TrkTools/TrkTruthCreatorTools
- Trigger/EFTracking/FPGATrackSim/FPGATrackSimSGInput
Affected files list will not be printed in this case
Adding @battagl ,@dshope ,@stavrop ,@kluit ,@sroe ,@akraszna ,@rosati ,@cgrefe ,@stsuno ,@cohm ,@jojungge ,@goetz ,@jchapman ,@calfayan ,@pscholer ,@gemmeren ,@lshan ,@apsallid ,@lmijovic as watchers
removed Run2-MCReco-output-changed label
removed Run3-MCReco-output-changed label
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
added 1 commit
- 5f58519f - HepMcParticleLink adaption to GenParticle::id
-
This merge request affects 25 packages:
- Event/xAOD/xAODTruthCnv
- Generators/GeneratorObjects
- Generators/GeneratorObjectsTPCnv
- HighGranularityTimingDetector/HGTD_Digitization/HGTD_Digitization
- HighGranularityTimingDetector/HGTD_Digitization/HGTD_FastDigitization
- InnerDetector/InDetDigitization/BCM_Digitization
- InnerDetector/InDetDigitization/PixelDigitization
- InnerDetector/InDetDigitization/SCT_Digitization
- InnerDetector/InDetDigitization/StripDigitization
- InnerDetector/InDetDigitization/TRT_Digitization
- InnerDetector/InDetEventCnv/InDetSimEventTPCnv
- InnerDetector/InDetSimEvent
- MuonSpectrometer/MuonDigitization/CSC_Digitization
- MuonSpectrometer/MuonDigitization/MDT_Digitization
- MuonSpectrometer/MuonDigitization/MM_Digitization
- MuonSpectrometer/MuonDigitization/RPC_Digitization
- MuonSpectrometer/MuonDigitization/TGC_Digitization
- MuonSpectrometer/MuonDigitization/sTGC_Digitization
- MuonSpectrometer/MuonSimEvent
- PhysicsAnalysis/TruthParticleID/McParticleTools
- Simulation/G4Sim/MCTruth
- Simulation/ISF/ISF_Core/ISF_Services
- Simulation/Tools/McEventCollectionFilter
- Tracking/TrkTools/TrkTruthCreatorTools
- Trigger/EFTracking/FPGATrackSim/FPGATrackSimSGInput
Affected files list will not be printed in this case
Adding @akraszna ,@kluit ,@apsallid ,@lmijovic ,@sroe ,@stsuno ,@lshan ,@rosati ,@goetz ,@jojungge ,@calfayan ,@jchapman ,@cohm ,@cgrefe ,@stavrop ,@pscholer ,@battagl ,@gemmeren ,@dshope as watchers
added Run2-MCReco-output-changed Run3-MCReco-output-changed labels
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
mentioned in merge request !69536 (merged)
added 175 commits
-
5f58519f...b9a6001c - 172 commits from branch
atlas:main - 99a45443 - HepMcParticleLink: Minimal changes to method definitions
- a0f800be - Update HepMcParticleLink clients to specificly flag barcode usage
- fcf2080f - HepMcParticleLink adaption to GenParticle::id
Toggle commit list-
5f58519f...b9a6001c - 172 commits from branch
-
This merge request affects 48 packages:
- Event/xAOD/xAODTruthCnv
- ForwardDetectors/ForwardTransport
- ForwardDetectors/LUCID/LUCID_Cnv/LUCID_EventTPCnv
- ForwardDetectors/LUCID/LUCID_SimUtils/LUCID_SimEvent
- Generators/GeneratorObjects
- Generators/GeneratorObjectsTPCnv
- HighGranularityTimingDetector/HGTD_Digitization/HGTD_Digitization
- HighGranularityTimingDetector/HGTD_Digitization/HGTD_FastDigitization
- InnerDetector/InDetDigitization/BCM_Digitization
- InnerDetector/InDetDigitization/PixelDigitization
- InnerDetector/InDetDigitization/SCT_Digitization
- InnerDetector/InDetDigitization/StripDigitization
- InnerDetector/InDetDigitization/TRT_Digitization
- InnerDetector/InDetEventCnv/InDetEventAthenaPool
- InnerDetector/InDetEventCnv/InDetSimEventTPCnv
- InnerDetector/InDetG4/BCM_G4_SD
- InnerDetector/InDetG4/BLM_G4_SD
- InnerDetector/InDetG4/PixelG4_SD
- InnerDetector/InDetG4/SCT_G4_SD
- InnerDetector/InDetRawAlgs/InDetOverlay
- InnerDetector/InDetSimEvent
- MuonSpectrometer/MuonCnv/MuonEventTPCnv
- MuonSpectrometer/MuonCnv/MuonSimEventTPCnv
- MuonSpectrometer/MuonDigitization/CSC_Digitization
- MuonSpectrometer/MuonDigitization/MDT_Digitization
- MuonSpectrometer/MuonDigitization/MM_Digitization
- MuonSpectrometer/MuonDigitization/RPC_Digitization
- MuonSpectrometer/MuonDigitization/TGC_Digitization
- MuonSpectrometer/MuonDigitization/sTGC_Digitization
- MuonSpectrometer/MuonG4/MuonG4SD
- MuonSpectrometer/MuonPhaseII/Event/xAOD/xAODMuonSimHit
- MuonSpectrometer/MuonSimEvent
- MuonSpectrometer/MuonTruthAlgs
- PhysicsAnalysis/TruthParticleID/McParticleEvent
- PhysicsAnalysis/TruthParticleID/McParticleEventTPCnv
- PhysicsAnalysis/TruthParticleID/McParticleTools
- Reconstruction/TrackParticleTruthTPCnv
- Simulation/G4Sim/MCTruth
- Simulation/G4Utilities/G4Ancillary/G4AncillarySimEvent
- Simulation/ISF/ISF_Core/ISF_Event
- Simulation/ISF/ISF_Core/ISF_Services
- Simulation/ISF/ISF_Fatras/ISF_FatrasToolsMS
- Simulation/Tools/McEventCollectionFilter
- Tracking/TrkEventCnv/TrkTruthTPCnv
- Tracking/TrkTools/TrkTruthCreatorTools
- Trigger/EFTracking/FPGATrackSim/FPGATrackSimSGInput
- Trigger/TrigTruthEvent/TrigTruthEventTPCnv
- graphics/VP1/VP1Systems/VP1TrackSystems
Affected files list will not be printed in this case
Adding @kluit ,@lmijovic ,@keli ,@tkharlam ,@gemmeren ,@battagl ,@stsuno ,@jojungge ,@tcuhadar ,@rosati ,@rbianchi ,@sroe ,@calfayan ,@dshope ,@akraszna ,@sutt ,@apsallid ,@pscholer ,@jchapman ,@ahaas ,@tadej ,@cohm ,@cgrefe ,@bkerridg ,@goetz ,@nagano ,@stavrop ,@lshan as watchers
added EventDisplay ForwardDetectors Overlay Reconstruction Upgrade labels
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake N/A N/A N/A N/A N/A make N/A N/A N/A N/A N/A tests N/A N/A N/A N/A N/A 
-
This merge request affects 48 packages:
- Event/xAOD/xAODTruthCnv
- ForwardDetectors/ForwardTransport
- ForwardDetectors/LUCID/LUCID_Cnv/LUCID_EventTPCnv
- ForwardDetectors/LUCID/LUCID_SimUtils/LUCID_SimEvent
- Generators/GeneratorObjects
- Generators/GeneratorObjectsTPCnv
- HighGranularityTimingDetector/HGTD_Digitization/HGTD_Digitization
- HighGranularityTimingDetector/HGTD_Digitization/HGTD_FastDigitization
- InnerDetector/InDetDigitization/BCM_Digitization
- InnerDetector/InDetDigitization/PixelDigitization
- InnerDetector/InDetDigitization/SCT_Digitization
- InnerDetector/InDetDigitization/StripDigitization
- InnerDetector/InDetDigitization/TRT_Digitization
- InnerDetector/InDetEventCnv/InDetEventAthenaPool
- InnerDetector/InDetEventCnv/InDetSimEventTPCnv
- InnerDetector/InDetG4/BCM_G4_SD
- InnerDetector/InDetG4/BLM_G4_SD
- InnerDetector/InDetG4/PixelG4_SD
- InnerDetector/InDetG4/SCT_G4_SD
- InnerDetector/InDetRawAlgs/InDetOverlay
- InnerDetector/InDetSimEvent
- MuonSpectrometer/MuonCnv/MuonEventTPCnv
- MuonSpectrometer/MuonCnv/MuonSimEventTPCnv
- MuonSpectrometer/MuonDigitization/CSC_Digitization
- MuonSpectrometer/MuonDigitization/MDT_Digitization
- MuonSpectrometer/MuonDigitization/MM_Digitization
- MuonSpectrometer/MuonDigitization/RPC_Digitization
- MuonSpectrometer/MuonDigitization/TGC_Digitization
- MuonSpectrometer/MuonDigitization/sTGC_Digitization
- MuonSpectrometer/MuonG4/MuonG4SD
- MuonSpectrometer/MuonPhaseII/Event/xAOD/xAODMuonSimHit
- MuonSpectrometer/MuonSimEvent
- MuonSpectrometer/MuonTruthAlgs
- PhysicsAnalysis/TruthParticleID/McParticleEvent
- PhysicsAnalysis/TruthParticleID/McParticleEventTPCnv
- PhysicsAnalysis/TruthParticleID/McParticleTools
- Reconstruction/TrackParticleTruthTPCnv
- Simulation/G4Sim/MCTruth
- Simulation/G4Utilities/G4Ancillary/G4AncillarySimEvent
- Simulation/ISF/ISF_Core/ISF_Event
- Simulation/ISF/ISF_Core/ISF_Services
- Simulation/ISF/ISF_Fatras/ISF_FatrasToolsMS
- Simulation/Tools/McEventCollectionFilter
- Tracking/TrkEventCnv/TrkTruthTPCnv
- Tracking/TrkTools/TrkTruthCreatorTools
- Trigger/EFTracking/FPGATrackSim/FPGATrackSimSGInput
- Trigger/TrigTruthEvent/TrigTruthEventTPCnv
- graphics/VP1/VP1Systems/VP1TrackSystems
Affected files list will not be printed in this case
Adding @calfayan ,@rbianchi ,@stavrop ,@sutt ,@jojungge ,@cohm ,@akraszna ,@tcuhadar ,@pscholer ,@gemmeren ,@battagl ,@keli ,@bkerridg ,@tadej ,@ahaas ,@lmijovic ,@lshan ,@rosati ,@sroe ,@cgrefe ,@tkharlam ,@dshope ,@kluit ,@stsuno ,@jchapman ,@apsallid ,@nagano ,@goetz as watchers
-
Athena AthSimulation AthGeneration AnalysisBase AthAnalysis externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
