CA v legacy grid test

Add a new test test_trigP1_v1Dev_newJO_grid.py comparing CA to legacy over a larger set of events than the build test - ATR-27049

Test runs first the legacy to create the reference, rather than needing to compare to other tests or having a reference stored in the release.

Several points to discus before merging:

• The count comparison is set as required but from testing it will be blocked by ATR-28477 so will currently fail. We want the result checked though, so believe this is the easiest way for shifters to notice/report the difference.
• The legacy part of the test duplicates test_trigP1_v1Dev_grid.py so this test could be removed either now or in the near future.
• The test is new so will need references generating for rootcomp.
• This test runs athenaHLT on data, do we want to do similar for MC?

cc @fwinkl @fpastore @martindl @cpollard @wiedenma @okuprash @sshaw @khoo

This merge request affects 1 package:

• Trigger/TrigValidation/TrigP1Test

This merge request affects 1 file:

• Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1Dev_newJO_grid.py

Adding @salderwe ,@martindl ,@okumura ,@vmartin as watchers

added Trigger main review-pending-level-1 labels

marked the checklist item The count comparison is set as required but from testing it will be blocked by ATR-28477 so will currently fail. We want the result checked though, so believe this is the easiest way for shifters to notice/report the difference. as completed

marked the checklist item The count comparison is set as required but from testing it will be blocked by ATR-28477 so will currently fail. We want the result checked though, so believe this is the easiest way for shifters to notice/report the difference. as incomplete

CI Result FAILURE (hash 3b51745c)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2270]

I think it is worth adding a similar test on MC (doesn't necessarily need to be part of this MR). There are quite a lot of chains that have zero (or very few) events passing in the data grid test. We were discussing with Bertrand and Chris what the best input to use would be though (ttbar covers most use cases, but some combination of ttbar, bphys, slepton samples might provide more complete coverage).

added review-user-action-required label and removed review-pending-level-1 label

Should this MR maybe be marked as draft if it is not yet ready to be merged?

Otherwise any new commit will make it pop up for the shifter.

Cheers L1

This merge request affects 1 package:

• Trigger/TrigValidation/TrigP1Test

This merge request affects 1 file:

• Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1Dev_newJO_grid.py

Adding @vmartin ,@martindl ,@okumura ,@salderwe as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash 3b51745c)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2386]

Is the failed pipeline (TrigP1Test_TrigValSteeringUT_ctest) expected? Also, there is an unresolved thread.

Cheers, Anne (L1)

added review-user-action-required label and removed review-pending-level-1 label

mentioned in merge request !67716 (merged)

marked the checklist item The test is new so will need references generating for rootcomp. as completed

mentioned in commit 25fd8ecd

resolved all threads

Jenkins please retry a build

This merge request affects 1 package:

• Trigger/TrigValidation/TrigP1Test

This merge request affects 1 file:

• Trigger/TrigValidation/TrigP1Test/test/test_trigP1_v1Dev_newJO_grid.py

Adding @martindl ,@salderwe ,@okumura ,@vmartin as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 3b51745c)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2459]

Looks good to me, approving.

Cheers, Philipp (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 1e2d11e0

mentioned in merge request !67835 (merged)

mentioned in commit 3c15d439