Skip to content
Snippets Groups Projects

TRT high thresholds for fast-OR trigger - ATR-28372

Merged Pawel Rybczynski requested to merge prybczyn/athena:fastOR_thr into 23.0
All threads resolved!

The main goal of this merge request is to allow adjustment of the TRT high threshold used in fast-OR trigger for heavy ions. Additionally, a minor correction to the trigger logic is applied.

In the TRT_Digitization package the high threshold limits are lowered to allow threshold values used in heavy ion collisions. In the TrigT1TRT package a python script, for overriding the high thresholds in job options, is added. It is also included in the CMakeLists.

A correction to the trigger logic in TrigT1TRT package is applied.

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Petar BokanPetar Bokan 1 year ago (Dec 12, 2023 10:30am UTC)

Merge details

  • Changes merged into 23.0 with e1ee398c (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

  • Pawel Rybczynski resolved all threads

    resolved all threads

  • :pencil: Build area was cleaned as per request posted in the DB. The full software build will be performed

  • This merge request affects 2 packages:

    • InnerDetector/InDetDigitization/TRT_Digitization
    • Trigger/TrigT1/TrigT1TRT

    Affected files list will not be printed in this case

    Adding @cgrefe ,@calfayan ,@sroe ,@jchapman ,@goetz as watchers

  • :white_check_mark: CI Result SUCCESS (hash 7898232d)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-CC7 79778]

  • Changes look good to me, approving.

    Cheers, Philipp (L1)

  • added review-approved label and removed review-pending-level-1 label

  • Petar Bokan mentioned in commit e1ee398c

    mentioned in commit e1ee398c

  • merged

  • Walter Lampl mentioned in merge request !67813 (merged)

    mentioned in merge request !67813 (merged)

  • Frank Winklmeier mentioned in merge request !67925 (merged)

    mentioned in merge request !67925 (merged)

  • Please register or sign in to reply
    Loading