Add missing jvt selection to default output content in CP algorithms

At the moment, the default variables in the block configuration in CP algorithms does not actually store the jvt selection, this MR fixes that. This is essential, when running with systematics, since one needs a per-systematic flag to properly throw away jets failing JVT.

added 1 commit

• 7c350306 - jvt selection should be per-syst...

Compare with previous version

added 1 commit

• 184a0411 - jvt selection should be per-syst...

Compare with previous version

This merge request affects 2 packages:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms

Affected files list will not be printed in this case

Adding @tadej ,@krumnack as watchers

added Analysis CPAlgorithms JetEtmiss analysis-review-required main review-pending-level-1 labels

This merge request affects 2 packages:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms

Affected files list will not be printed in this case

Adding @tadej ,@krumnack as watchers

MR adds an important feature for analysis and does not break current model - approving from AR side

Giovanni (AR)

removed analysis-review-required label

added analysis-review-approved label

I'm fine with the change, but to clarify, in practice I always just merged this selection with the common OR selection to have one final "passes systematic" selection at the end. I guess this is only needed if one wants to keep JVT-failing jets.

CI Result FAILURE (hash e056fdab)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2389]

CI Result FAILURE (hash 184a0411)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2391]

Are the pipeline failures expected?

Cheers, Anne (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 330364aa - Ignore jvt branches in sequences vs blocks comparison test

Compare with previous version

This merge request affects 2 packages:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms

Affected files list will not be printed in this case

Adding @krumnack ,@tadej as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash 330364aa)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2460]

There are warnings in a really long log and one unresolved thread. Could you follow up on this?

Cheers, Philipp (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 7661da37 - Disable jvt branch comparison also in unit tests

Compare with previous version

This merge request affects 2 packages:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms

Affected files list will not be printed in this case

Adding @krumnack ,@tadej as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash 7661da37)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2481]

added review-user-action-required label

removed review-pending-level-1 label

@omajersk can we hold off on this MR until after the PHYSLITE tutorial (tomorrow)?

added 3 commits

• f17aad96 - Revert "Disable jvt branch comparison also in unit tests"
• 75450a17 - Revert "Ignore jvt branches in sequences vs blocks comparison test"
• e08ccaa8 - Make jvt_selection variable not for comparison.

Compare with previous version

This merge request affects 2 packages:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms

Affected files list will not be printed in this case

Adding @tadej ,@krumnack as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result FAILURE (hash e08ccaa8)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2700]

added 1 commit

• f61279c2 - Disable jvt select variable in all comparison tests.

Compare with previous version

This merge request affects 2 packages:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms

Affected files list will not be printed in this case

Adding @krumnack ,@tadej as watchers

CI Result FAILURE (hash f61279c2)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2722]

Slight changes between the two last failed pipelines (AnalysisAlgorithmsConfig_TestJobFastSimCompare_ctest vs. AnalysisAlgorithmsConfig_TestJobDataCompare_ctest). This failure is not expected, as discussed in the unresolved thread, so I'm giving the MR back to the user.

Cheers, Anne (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 3a66da76 - Fix typo

Compare with previous version

This merge request affects 2 packages:

• PhysicsAnalysis/Algorithms/AnalysisAlgorithmsConfig
• PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms

Affected files list will not be printed in this case

Adding @krumnack ,@tadej as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 3a66da76)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2729]

resolved all threads

Looks good from my perspective.

Cheers, Anne (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 77d54f8a