MuonReadoutGeometry: fix compilation problems in debug.

The problem was here:

#ifdef NDEBUG
    float TgcReadoutElement::gangThickness(int /*gasGap*/, int /*gang*/) const
#else
    float TgcReadoutElement::gangThickness(int gasGap, int gang) const
#endif
    {
        assert(validGang(gasGap, gang));
        return 0.05 * CLHEP::mm;
    }

const was removed in opt but not dbg. But we cannot remove const here too because validGang is const, and changing this will have knock-on consequences in all the other const methods.

Reverting the static change for this function.

Fixes ATLASRECTS-7858

This merge request affects no known files AND packages. Consult an expert!

This merge request affects 0 files:

added main no-domain review-pending-level-1 labels

added 1 commit

• 19bfa6a3 - Fix compilation problem in debug by reverting static change

Compare with previous version

I have no idea why gitlab thinks there are merge conflicts, and I cannot reproduce this locally...

This merge request affects 1 package:

• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry

This merge request affects 2 files:

• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/MuonReadoutGeometry/TgcReadoutElement.h
• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/src/TgcReadoutElement.cxx

Adding @kluit ,@pscholer ,@stavrop ,@jojungge ,@apsallid ,@rosati as watchers

added MuonSpectrometer label

closed

I opened !67773 (merged) with IDENTICAL changes and there's no merge conflicts. Bizarre.

Anyway, not going to investigate further.

CI Result SUCCESS (hash 811fc772)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2518]

CI Result SUCCESS (hash 19bfa6a3)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2519]