Skip to content
Snippets Groups Projects

Adding new compiled pixel calibration code

Merged Sergi Rodriguez Bosca requested to merge serodrig/athena:PixCalib_2 into main

This MR is meant to include in the Athena project the new code for the Pixel detector. This is still a work in progress - but there are a lot of changes so better to get already the first draft.

I have added 5 different files:

  • PixelCalibration.cxx: main source file to execute the calibration
  • Calib.cxx/.h: Class to obtain the threshold, intime and fitting parameters for normal, long and ganged pixels
  • CalibFrontEndInfo.cxx/.h: Class to store all the information in order to print it in the correct DB format

This calibration can run different layers at the same time in different command lines. The execution line could be:

PixelCalibration THR=SCAN_S000089736 THRintime=SCAN_S000089737 TOT=SCAN_S000089738 directory_path=/eos/atlas/atlascerngroupdisk/det-ibl/charge-calibration/20230623_ALL/ Blayer

To run the Blayer with the SCAN files provided as an arguments.

The old calibration code will be removed in a separate MR, after the internal discussion with the offline team

Merge request reports

Pipeline #6616475 passed

Pipeline passed for d7115179 on serodrig:PixCalib_2

Approval is optional

Merged by Walter LamplWalter Lampl 1 year ago (Dec 14, 2023 1:52pm UTC)

Merge details

  • Changes merged into master with 382843a0.
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Escalating to L2 due to size and a new keyword.

    Cheers, Philipp (L1)

  • Thomas Strebler resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • Sergi Rodriguez Bosca resolved all threads

    resolved all threads

  • Thomas Strebler
  • Thomas Strebler
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading