Small fix in TEvent to avoid reading objects that would be called "MetaData" but that would not be trees (related previous MR !65967))

I found out a small issue in the recently merged MR !65967 (merged). The previous MR (among many other things) implemented the reading of extra-metadata trees in order to retrieve event format information. This case can happen for augmented derivation file for instance were there is a metadata tree per stream decision.

The issue is in case an object is called "*MetaData*" e.g. in our analysis we have an hist (TH1D object) that is called MetaData_EventCount then the code was crashing by trying to read that object as a tree. I added a bit more protections against such cases and this solved the issue.

Tagging @akraszna, @ssnyder, @ekourlit and @gwatts.

Please let me know if you have comments about the robustness of the fix,
Thanks in advance,
Best,
Romain

added Core main labels

added analysis-review-expert analysis-review-required labels

changed the description

This merge request affects 1 package:

• Control/xAODRootAccess

This merge request affects 1 file:

• Control/xAODRootAccess/Root/TEvent.cxx

Adding @akraszna ,@ssnyder as watchers

added review-pending-level-1 label

WARNING: big files (>100K) are found in the changeset

148K in file Control/xAODRootAccess/Root/TEvent.cxx

CI Result SUCCESS (hash ab035a47)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2570]

Looks good to me, approving.

Cheers, Philipp (L1)

added review-approved label and removed review-pending-level-1 label

All seems perfect to approve as analysis review

added analysis-review-approved label and removed analysis-review-required label

Who is the analysis-review-expert supposed to approve this MR? @krumnack?

• Walter

added review-user-action-required label and removed analysis-review-expert review-approved labels

I left analysis-review-approved active, since I'm only asking for technical changes. The development is absolutely justified from an "analysis perspective".

added 1 commit

• e54759f0 - Adding change from Attila

Compare with previous version

This merge request affects 1 package:

• Control/xAODRootAccess

This merge request affects 1 file:

• Control/xAODRootAccess/Root/TEvent.cxx

Adding @ssnyder ,@akraszna as watchers

added review-pending-level-1 label and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

148K in file Control/xAODRootAccess/Root/TEvent.cxx

resolved all threads

CI Result SUCCESS (hash e54759f0)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2662]

Looks good from my perspective.

Cheers, Anne (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit b3ab5839