support for new and old l1a modules at the TP

This targets the main branch - fixing issues seen in: !67752 (comment 7408322)

This merge request affects 2 packages:

• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode
• MuonSpectrometer/MuonCnv/MuonSTGC_CnvTools

Affected files list will not be printed in this case

Adding @jojungge ,@rosati ,@kluit ,@stavrop ,@pscholer ,@apsallid as watchers

added MuonSpectrometer Trigger main review-pending-level-1 labels

CI Result SUCCESS (hash 4acfd2cb)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
DetCommon: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2607]

There seem to be some compilation warnings, could you have a look?

/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/src/NSWTriggerSTGL1AElink.cxx: In member function 'void Muon::nsw::NSWTriggerSTGL1AElink::decode_header(std::size_t&, int)':
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/src/NSWTriggerSTGL1AElink.cxx:37:15: warning: unused variable 'start' [-Wunused-variable]
   37 |   std::size_t start = readPointer;
      |               ^~~~~
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/src/NSWTriggerSTGL1AElink.cxx: In member function 'int Muon::nsw::NSWTriggerSTGL1AElink::parse_version_workaround(std::size_t&)':
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/MuonSpectrometer/MuonCnv/MuonNSWCommonDecode/src/NSWTriggerSTGL1AElink.cxx:98:8: warning: unused variable 'anchor_location' [-Wunused-variable]
   98 |    int anchor_location = Muon::nsw::STGTPL1A::loc_version1_anchor;
      |        ^~~~~~~~~~~~~~~

Cheers

L1

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• eb0fc8a2 - fixed compilation warnings

Compare with previous version

This merge request affects 2 packages:

• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode
• MuonSpectrometer/MuonCnv/MuonSTGC_CnvTools

Affected files list will not be printed in this case

Adding @jojungge ,@stavrop ,@rosati ,@pscholer ,@apsallid ,@kluit as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash eb0fc8a2)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2612]

I just have two minor comments, otherwise this looks good to me.

Cheers

L1

added review-approved label and removed review-pending-level-1 label

added review-user-action-required label and removed review-approved label

added 1 commit

• 6bcf1e23 - Correcting not needed comments and printouts

Compare with previous version

Corrected according to Eric's comments

This merge request affects 2 packages:

• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode
• MuonSpectrometer/MuonCnv/MuonSTGC_CnvTools

Affected files list will not be printed in this case

Adding @pscholer ,@kluit ,@jojungge ,@stavrop ,@apsallid ,@rosati as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 6bcf1e23)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2625]

resolved all threads

MR looks good to me, CI shows no problems - approving.

Cheers, Yuriy (L1)

removed review-pending-level-1 label

added review-approved label

resolved all threads

added 1 commit

• a753c210 - remove unecessary comment

Compare with previous version

This merge request affects 2 packages:

• MuonSpectrometer/MuonCnv/MuonNSWCommonDecode
• MuonSpectrometer/MuonCnv/MuonSTGC_CnvTools

Affected files list will not be printed in this case

Adding @kluit ,@rosati ,@jojungge ,@pscholer ,@apsallid ,@stavrop as watchers

added review-pending-level-1 label and removed review-approved label

CI Result SUCCESS (hash a753c210)

	Athena	DetCommon
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
DetCommon: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2667]

resolved all threads

Looks good from my perspective. Small remark: In the first file, the copyright was changed from 2023 back to 2021, that could be changed in the next version. I resolved the open thread because it was clear that the code change had solved it.

Cheers, Anne (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 34e52fb2

FYI, I fixed the copyright year in-place