CPAlgorithms: expose the useClusterEta property of the PtEtaSelection tool

The CP::AsgPtEtaSelectionTool set up by the PtEtaSelectionBlock has an option to use the cluster eta instead of the track eta: this is the recommended approach when applying eta cuts on electrons and photons. This MR exposes that option at the level of the config block.

I'm not sure whether we want to enforce the use of cluster eta on egamma objects by default (or how best to do it). Currently, we expect the user to know that this option is needed for electrons and photons, but not for jets, muons or taus - is that a reasonable expectation?

This merge request affects 1 package:

• PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms

This merge request affects 1 file:

• PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms/python/AsgAnalysisConfig.py

Adding @krumnack ,@tadej as watchers

added Analysis CPAlgorithms analysis-review-required main review-pending-level-1 labels

CI Result SUCCESS (hash 2a0bc77d)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2698]

Looks good to be approved as analysis review

added analysis-review-approved label and removed analysis-review-required label

Looks good from my perspective.

Cheers, Anne (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit a452ed71

Hi @ravinab,

In terms of doing this automatically, several things would have to happen:

• We'd need to register with the ConfigAccumulator that a container corresponds to an e-gamma object. This would likely happen in the corresponding e-gamma block.
• We'd need the ability to ask the ConfigAccumulator to ask for the corresponding flag for a given container.
• We change the PtEtaSelectionConfig to make your new property default to None and if so ask the ConfigAccumulator for the new flag.

I don't believe it would be hard or a lot of effort. It would pretty much mirror how we communicate the source jet container from the jet block to all the downstream blocks (in particular to MET).

And if using cluster-eta for e-gamma is the recommendation, it would seem like a very good idea to implement that as the default. My idea with the configuration is that in the idealized case if you were to write a really minimal configuration file you'd only have to write things you'd also put on a slide if you were to make a presentation on what you did. So for options you'd ideally just have to specify them if either you are doing non-standard or if there is no standard that reflects what most analyses are doing. Of course we are still quite a way away from that, but I think the closer we can get the better.

Cheers, Nils