Skip to content
Snippets Groups Projects

CPAlgorithms: implement pseudo-data smearing for Full JER systematics

Merged Baptiste Ravina requested to merge ravinab/athena:cpalgo_jersmearing into main
All threads resolved!

As described in JetUncertaintiesRel22, for the "Full" or "All" JER uncertainty models, one needs to run the JetUncertaintiesTool twice, once in MC-mode and once in data-mode.

Merge request reports

Pipeline #6644958 passed

Pipeline passed for 8bb4363e on ravinab:cpalgo_jersmearing

Approval is optional

Merged by Frank WinklmeierFrank Winklmeier 1 year ago (Dec 21, 2023 2:32pm UTC)

Merge details

  • Changes merged into main with 3b624c24 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Baptiste Ravina added 2 commits

    added 2 commits

    • 40040503 - refactor the jet uncertainties algorithm
    • e53cfbc9 - trick the JetUncertaintiesTool into registering JER systematics for pseudo data

    Compare with previous version

  • Baptiste Ravina added 1 commit

    added 1 commit

    Compare with previous version

  • Baptiste Ravina added 56 commits

    added 56 commits

    • 83b2e1c4...b15b68e5 - 51 commits from branch atlas:main
    • da42276a - attempting to duplicate JER systematics
    • 66f44d91 - replace the full set of systematics?
    • 473d4288 - refactor the jet uncertainties algorithm
    • c04d8e58 - trick the JetUncertaintiesTool into registering JER systematics for pseudo data
    • 177f893b - cleanup

    Compare with previous version

  • Baptiste Ravina added 1 commit

    added 1 commit

    • 8bb4363e - separate systematics vector in initialisation rather than in execution

    Compare with previous version

  • Baptiste Ravina resolved all threads

    resolved all threads

  • Baptiste Ravina marked this merge request as ready

    marked this merge request as ready

  • Author Developer

    Jenkins please retry a build

  • This merge request affects 2 packages:

    • PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms
    • Reconstruction/Jet/JetUncertainties

    Affected files list will not be printed in this case

    Adding @goetz ,@krumnack ,@tadej as watchers

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 132K in file Reconstruction/Jet/JetUncertainties/Root/JetUncertaintiesTool.cxx

  • Tadej Novak resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash 8bb4363e)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2871]

  • The planned CI service intervention interrupted the previous CI build at the very last stage - handling log files. Out of extra precaution I will retry this build.

  • Jenkins please retry a build

  • This merge request affects 2 packages:

    • PhysicsAnalysis/Algorithms/JetAnalysisAlgorithms
    • Reconstruction/Jet/JetUncertainties

    Affected files list will not be printed in this case

    Adding @goetz ,@tadej ,@krumnack as watchers

  • :warning: WARNING: big files (>100K) are found in the changeset

    :pencil: 132K in file Reconstruction/Jet/JetUncertainties/Root/JetUncertaintiesTool.cxx

  • :white_check_mark: CI Result SUCCESS (hash 8bb4363e)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2876]

  • Developer

    Looks good from my perspective.

    Cheers, Anne (L1)

  • added review-approved label and removed review-pending-level-1 label

  • I think this should work.

    Nils [Analysis RC]

  • Frank Winklmeier mentioned in commit 3b624c24

    mentioned in commit 3b624c24

  • This introduced a unit test failure in the nightlies: ATLASG-2657

    Please provide a fix asap.

  • Please register or sign in to reply
    Loading