Skip to content
Snippets Groups Projects

TruthClassificationTool: updated the classification scheme on the muon side

Merged Ka Yan Fan requested to merge kfan/athena:main_TC into main

Classification Scheme on the muon side is updated to recover the original Unknown muons by adding 5 new categories. Changes are mostly made in the TruthClassificationTool.cxx Information of the new categories are included in the README.md

@nbruscin @lpascual @mvanadia @nicolaid @sangelid @dparedes

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • I've just shared a few comments probably worth to consider.

    Best, Thomas - L1

  • Ka Yan Fan added 1 commit

    added 1 commit

    • 3e4daf8b - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • This merge request affects 2 packages:

    • PhysicsAnalysis/AnalysisCommon/TruthClassification
    • PhysicsAnalysis/Interfaces/AsgAnalysisInterfaces

    Affected files list will not be printed in this case

    Adding @akraszna ,@fcardill ,@yoyamagu as watchers

  • :white_check_mark: CI Result SUCCESS (hash 3e4daf8b)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2820]

  • Developer

    There is an open thread. Aside from that, the code looks good from my perspective.

    Cheers, Anne (L1)

  • Ka Yan Fan added 1 commit

    added 1 commit

    Compare with previous version

  • This merge request affects 2 packages:

    • PhysicsAnalysis/AnalysisCommon/TruthClassification
    • PhysicsAnalysis/Interfaces/AsgAnalysisInterfaces

    Affected files list will not be printed in this case

    Adding @yoyamagu ,@fcardill ,@akraszna as watchers

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading