Change the jet scale when computing certain jet mods

This MR changes the scale of the jet used in JetConstituentFrac.cxx and JetGroomMRatio.cxx to "JetConstitScaleMomentum" to rightly compute the jet mods. Currently the mods are not computed with a fixed scale leading to inconsistency in jet tools.

Tagging @cdelitzs, @delsart

This merge request affects 1 package:

• Reconstruction/Jet/JetMomentTools

This merge request affects 2 files:

• Reconstruction/Jet/JetMomentTools/Root/JetConstituentFrac.cxx
• Reconstruction/Jet/JetMomentTools/Root/JetGroomMRatio.cxx

Adding @goetz as watcher

added JetEtmiss Reconstruction analysis-review-required main review-pending-level-1 labels

added urgent label

Thanks so much @galbouy

Marking the request as urgent so that this can hopefully still be included for the next round of PHYS production: ATLASDPD-2017

added analysis-review-approved label and removed analysis-review-required label

added Run2-Derivation-output-changed Run3-Derivation-output-changed labels

CI Result FAILURE (hash fa3118fa)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2839]

I just wanted to comment that the changes that are observed by the CI test for the following variables are expected:

• NeutralEFrac
• ChargePTFrac
• ChargeMFrac
• groomMRatio

As Guillaume mentioned in the description, this MR fixes the previous implementation to ensure that the denominator is always at the correct scale independent of what calibration we are applying.

I am not sure however how to update the reference files to ensure that the CI tests are not crashing anymore. Maybe someone can help us here

Thanks!

cc @christos @jcatmore for offline-sw-review-approved

Output from the failed pipelines: ERROR Py:diff-root INFO [AntiKt10UFOCSSKSoftDropBeta100Zcut10JetsAuxDyn.ChargeMFrac]: 4 leaves differ ERROR Py:diff-root INFO [AntiKt10UFOCSSKSoftDropBeta100Zcut10JetsAuxDyn.ChargePTFrac]: 4 leaves differ ERROR Py:diff-root INFO [AntiKt10UFOCSSKSoftDropBeta100Zcut10JetsAuxDyn.NeutralEFrac]: 4 leaves differ ERROR Py:diff-root INFO [AntiKt10UFOCSSKSoftDropBeta100Zcut10JetsAuxDyn.groomMRatio]: 4 leaves differ

The pipeline failures seem to all arise from the mentioned four variables, so the MR looks good from my perspective.

Cheers, Anne (L1)

added review-approved label and removed review-pending-level-1 label

added 21 commits

• fa3118fa...22b81114 - 16 commits from branch atlas:main
• 3c513285 - add dual implementation for ONNX service name setting
• 5d9c2e17 - restore file JetCalibTools_Example.cxx
• a61e01f2 - change jet scale at which fractions are computed
• ed3ba2a7 - same change for groomMRatio
• 4b1d3248 - Update CI references

Compare with previous version

This merge request affects 2 packages:

• Reconstruction/Jet/JetMomentTools
• Tools/WorkflowTestRunner

Affected files list will not be printed in this case

Adding @goetz ,@pagessin as watchers

added Tools review-pending-level-1 labels and removed review-approved label

added offline-sw-review-approved label

Hi @fwinkl .

I added the label. But this did not change "Reco" ouput (it is Derivations I see) . So in theory is not for Reco-Integration per se . I think these were supposed to be under AMG or something.

Anyhow, I guess there is no point delaying this for that .

CI Result SUCCESS (hash 4b1d3248)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2858]

removed review-pending-level-1 label

added review-approved label

mentioned in commit 45bd89d5

merged