make ROOTTREE default storage for metadata instead of ROOTTREEINDEX

Follow-up from !67839 (merged), in particular !67839 (comment 7448149).

Bonus: fix a bug in xAOD::Utils::getFirstBranchMatch (909bbd78, e34b7405), see: !67972 (comment 7449441)

added full-integration-tests full-unit-tests labels

The pipeline in !67839 (merged) was failing (after !67820 (merged) got merged) in DataModelRunTests_RootAllocTestRead(No)AllocWith(out)Alloc tests with:

see the log

 285/2287 Test  #551: DataModelRunTests_RootAllocTestReadAllocWithAlloc_ctest ...................***Failed   77.13 sec
Py:Athena            INFO including file "DataModelRunTests/xAODRootTest.py"
xAOD::Init                INFO    Environment initialised for data access
xAOD::TEvent::readFrom    INFO    Input file provides no event or metadata
xAOD::TEvent::getEntry    ERROR   /var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/Control/xAODRootAccess/Root/TEvent.cxx:1329 Function called on an uninitialised object
xAOD::MakeTransientTree   ERROR   /var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/Control/xAODRootAccess/Root/MakeTransientTree.cxx:247 Couldn't load first event
Traceback (most recent call last):
  File "/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/Control/DataModelTest/DataModelRunTests/test/RootAllocTestReadAllocWithAlloc_t.py", line 22, in <module>
    ana.run()
  File "/build2/ci-builds/main/Athena/build/Athena/x86_64-el9-gcc13-opt/jobOptions/DataModelRunTests/xAODRootTest.py", line 320, in run
    nent = self.tree.GetEntries()
TypeError: none of the 2 overloaded methods succeeded. Full details:
  attempt to access a null-pointer
  Long64_t TTree::GetEntries(const char* selection) =>
    TypeError: takes at least 1 arguments (0 given)
xAOD::MakeTransientTree   ERROR   /var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/Control/xAODRootAccess/Root/MakeTransientTree.cxx:247 Couldn't load first event
Traceback (most recent call last):
  File "/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/Control/DataModelTest/DataModelRunTests/test/RootAllocTestReadAllocWithAlloc_t.py", line 22, in <module>
    ana.run()
  File "/build2/ci-builds/main/Athena/build/Athena/x86_64-el9-gcc13-opt/jobOptions/DataModelRunTests/xAODRootTest.py", line 320, in run
    nent = self.tree.GetEntries()
TypeError: none of the 2 overloaded methods succeeded. Full details:
  attempt to access a null-pointer
  Long64_t TTree::GetEntries(const char* selection) =>
    TypeError: takes at least 1 arguments (0 given)
[97;101;1m post.sh> ERROR: Test RootAllocTestReadAllocWithAlloc failed with exit code: 1[m
 post.sh> Please check /build/ci-builds/main/Athena/build/Athena/Control/DataModelTest/DataModelRunTests/CMakeFiles/unitTestRun/RootAllocTestReadAllocWithAlloc.log

This may come from some interference of 9e4a5d43 with !67820 (merged).

The observed behaviour may come from this buggy-looking line which should probably read:

         for( int i = 0; i <= pBranches->GetLast() ; ++i ) {

or

         for( int i = 0; i < pBranches->GetEntries() ; ++i ) {

mentioned in merge request !67839 (merged)

Jenkins please retry the build

This merge request affects 1 package:

• Control/AthenaConfiguration

This merge request affects 1 file:

• Control/AthenaConfiguration/python/AllConfigFlags.py

Adding @ssnyder ,@gemmeren ,@maszyman as watchers

added Core analysis-review-required main labels

added 1 commit

• 909bbd78 - fix iterating over the branches to get the first pattern match

Compare with previous version

Jenkins please retry the build

Let's see the CI results with and w/o the fix in the tree iteration.

This merge request affects 2 packages:

• Control/AthenaConfiguration
• Control/xAODRootAccess

Affected files list will not be printed in this case

Adding @ssnyder ,@akraszna ,@maszyman ,@gemmeren as watchers

CI Result FAILURE (hash 9e4a5d43)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2919]

CI Result FAILURE (hash 909bbd78)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2920]

added 1 commit

• e34b7405 - avoid redundant calls to GetLast()

Compare with previous version

Jenkins please retry the build

This merge request affects 2 packages:

• Control/AthenaConfiguration
• Control/xAODRootAccess

Affected files list will not be printed in this case

Adding @ssnyder ,@gemmeren ,@maszyman ,@akraszna as watchers

CI Result FAILURE (hash e34b7405)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2936]

Jenkins please retry the build

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 2 packages:

• Control/AthenaConfiguration
• Control/xAODRootAccess

Affected files list will not be printed in this case

Adding @maszyman ,@akraszna ,@ssnyder ,@gemmeren as watchers

CI Result SUCCESS (hash e34b7405)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2990]

marked this merge request as ready

changed the description

added review-pending-level-1 label

Looks good to me, approving request.

Cheers, Lucy (L1)

added review-approved label and removed review-pending-level-1 label

The MR looks good to me, putting analysis-review-expert flag as this involves a set of MRs affecting core packages

removed analysis-review-required label

added analysis-review-expert label

Hi @robouque,

Changes to core Athena packages are usually something we just wave through, as analysis is not really a primary user for Athena. If the changes involve changes to core analysis packages or require change changes to analysis packages that is a different story.

In this case there is a change to TEvent (which is core analysis), but since it is just a setting change for meta-data it should be fine, as long as it doesn't break the tests.

Cheers, Nils [Analysis RC]

added analysis-review-approved label and removed analysis-review-expert label

merged

mentioned in commit 7b54ccfd

resolved all threads