Skip to content
Snippets Groups Projects

Bug fix on ​L2MuonSAIOMon in TrigMuonMonitoring

Merged Ryo Ishikawa requested to merge rishikaw/athena:athena_L2SAIO into main
All threads resolved!

Fix a problem in L2MuonSAIOmon. Fix event selection not to require that events pass the chain to be monitored. Fix an estimation workflow in the fillVariablesPerOfflineMuonPerChain to fix a turn on curve in DQ histogram. Fix a problem that decision_ptthreshold wrongly depends on message level. Fix decision_ptthreshold to be called on all monitored chains.

ping @yoyamagu and @vippolit

Merge request reports

Pipeline #6661131 passed

Pipeline passed for 2727e5d0 on rishikaw:athena_L2SAIO

Approval is optional

Merged by Vakhtang TsulaiaVakhtang Tsulaia 1 year ago (Jan 8, 2024 7:36pm UTC)

Merge details

  • Changes merged into main with 132e4b5e (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ryo Ishikawa added 1 commit

    added 1 commit

    Compare with previous version

  • This merge request affects 1 package:

    • Trigger/TrigMonitoring/TrigMuonMonitoring

    This merge request affects 2 files:

    • Trigger/TrigMonitoring/TrigMuonMonitoring/src/L2MuonSAIOMon.cxx
    • Trigger/TrigMonitoring/TrigMuonMonitoring/src/L2MuonSAIOMon.h
  • :white_check_mark: CI Result SUCCESS (hash 2727e5d0)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2955]

  • Ryo Ishikawa resolved all threads

    resolved all threads

  • Looks good to me, approving request.

    Cheers, Lucy (L1)

  • added review-approved label and removed review-pending-level-1 label

  • added bugfix label

  • Vakhtang Tsulaia mentioned in commit 132e4b5e

    mentioned in commit 132e4b5e

  • Please register or sign in to reply
    Loading