Adding ONNX compatability to FastCaloSim
Spiritual successor to !66216 (closed) Which is itself a variant on !63562 (merged). Look to !63562 (merged) for the best documentation.
This is a slightly abbreviated version of the above MR's because there is a problem somewhere in the changes to TFCSPredicExtrapWeights.cxx
. This problem caused the CI to fail. The problem is quite specific, it mostly doesn't show up. TO reproduce it outside the CI, you can run the 23.0 branch (which already has the changes, because it has less CI on it);
asetup Athena,23.0,latest && \
ATHENA_CORE_NUMBER=0 Sim_tf.py --AMIConfig a913 --inputEVNTFile /cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/CampaignInputs/mc23/EVNT/mc23_13p6TeV.601229.PhPy8EG_A14_ttbar_hdamp258p75_SingleLep.evgen.EVNT.e8514/EVNT.32288062._002040.pool.root.1 --outputHITSFile myHITS.pool.root --imf False --maxEvents 20
So I took out the changes to TFCSPredictExtrapWeights.cxx
, that now only runs on lwtnn. This MR only changes the net in TFCEGANEtaSlice.cxx
so that it may run on lwtnn or ONNX. This bit seems to work just fine.
As I'm leaving, I won't be able to interact with gitlab. I'm still happy to help, if there is anything you'd like to ask; henrydayhall@protonmail.com
Merge request reports
Activity
This merge request affects 1 package:
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent
This merge request affects 21 files:
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/CMakeLists.txt
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/LinkDef.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/MLogging.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSEnergyAndHitGANV2.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANEtaSlice.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANLWTNNHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANXMLParameters.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSNetworkFactory.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSONNXHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSSimpleLWTNNHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkBase.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkLWTNN.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/MLogging.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSEnergyAndHitGANV2.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANEtaSlice.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANLWTNNHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSNetworkFactory.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSONNXHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSSimpleLWTNNHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkBase.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkLWTNN.cxx
Adding @zhangr ,@jbeirer ,@jchapman ,@tadej ,@schaarsc as watchers
added Simulation main labels
CI Result SUCCESS (hash fe627808)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2976]added 2 commits
This merge request affects 1 package:
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent
This merge request affects 30 files:
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/CMakeLists.txt
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/LinkDef.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/MLogging.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSEnergyAndHitGANV2.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANEtaSlice.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANLWTNNHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSNetworkFactory.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSONNXHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSPredictExtrapWeights.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSSimpleLWTNNHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkBase.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkLWTNN.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/GenericNetwork_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/NormPredExtrapSample/MeanStdDevEnergyFractions_eta_0_5.txt
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSEnergyAndHitGANV2_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSPredictExtrapWeights_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/toy_network.onnx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/MLogging.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSEnergyAndHitGANV2.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANEtaSlice.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANLWTNNHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSNetworkFactory.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSONNXHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSPredictExtrapWeights.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSSimpleLWTNNHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkBase.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkLWTNN.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/GenericNetwork_test.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSEnergyAndHitGANV2_test.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSPredictExtrapWeights_test.cxx
Adding @jbeirer ,@tadej ,@zhangr ,@schaarsc ,@jchapman as watchers
This merge request affects 1 package:
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent
This merge request affects 30 files:
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/CMakeLists.txt
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/LinkDef.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/MLogging.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSEnergyAndHitGANV2.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANEtaSlice.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANLWTNNHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSNetworkFactory.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSONNXHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSPredictExtrapWeights.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSSimpleLWTNNHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkBase.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkLWTNN.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/GenericNetwork_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/NormPredExtrapSample/MeanStdDevEnergyFractions_eta_0_5.txt
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSEnergyAndHitGANV2_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSPredictExtrapWeights_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/toy_network.onnx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/MLogging.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSEnergyAndHitGANV2.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANEtaSlice.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANLWTNNHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSNetworkFactory.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSONNXHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSPredictExtrapWeights.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSSimpleLWTNNHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkBase.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkLWTNN.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/GenericNetwork_test.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSEnergyAndHitGANV2_test.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSPredictExtrapWeights_test.cxx
Adding @jbeirer ,@jchapman ,@schaarsc ,@tadej ,@zhangr as watchers
CI Result FAILURE (hash 463520fb)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2977]This merge request affects 1 package:
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent
This merge request affects 30 files:
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/CMakeLists.txt
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/LinkDef.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/MLogging.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSEnergyAndHitGANV2.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANEtaSlice.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANLWTNNHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSNetworkFactory.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSONNXHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSPredictExtrapWeights.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSSimpleLWTNNHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkBase.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkLWTNN.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/GenericNetwork_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/NormPredExtrapSample/MeanStdDevEnergyFractions_eta_0_5.txt
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSEnergyAndHitGANV2_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSPredictExtrapWeights_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/toy_network.onnx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/MLogging.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSEnergyAndHitGANV2.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANEtaSlice.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANLWTNNHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSNetworkFactory.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSONNXHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSPredictExtrapWeights.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSSimpleLWTNNHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkBase.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkLWTNN.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/GenericNetwork_test.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSEnergyAndHitGANV2_test.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSPredictExtrapWeights_test.cxx
Adding @schaarsc ,@tadej ,@jchapman ,@jbeirer ,@zhangr as watchers
mentioned in merge request !66216 (closed)
CI Result FAILURE (hash 7e3149b1)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2979] CI Result FAILURE (hash 93a8f9ab)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2978]This merge request affects 1 package:
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent
This merge request affects 30 files:
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/CMakeLists.txt
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/LinkDef.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/MLogging.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSEnergyAndHitGANV2.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANEtaSlice.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANLWTNNHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSNetworkFactory.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSONNXHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSPredictExtrapWeights.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSSimpleLWTNNHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkBase.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkLWTNN.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/GenericNetwork_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/NormPredExtrapSample/MeanStdDevEnergyFractions_eta_0_5.txt
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSEnergyAndHitGANV2_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSPredictExtrapWeights_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/toy_network.onnx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/MLogging.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSEnergyAndHitGANV2.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANEtaSlice.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANLWTNNHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSNetworkFactory.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSONNXHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSPredictExtrapWeights.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSSimpleLWTNNHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkBase.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkLWTNN.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/GenericNetwork_test.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSEnergyAndHitGANV2_test.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSPredictExtrapWeights_test.cxx
Adding @zhangr ,@schaarsc ,@tadej ,@jbeirer ,@jchapman as watchers
added review-pending-level-1 label
CI Result FAILURE (hash 7e3149b1)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2980]This merge request affects 1 package:
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent
This merge request affects 30 files:
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/CMakeLists.txt
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/LinkDef.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/MLogging.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSEnergyAndHitGANV2.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANEtaSlice.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANLWTNNHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSNetworkFactory.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSONNXHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSPredictExtrapWeights.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSSimpleLWTNNHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkBase.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkLWTNN.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/GenericNetwork_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/NormPredExtrapSample/MeanStdDevEnergyFractions_eta_0_5.txt
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSEnergyAndHitGANV2_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSPredictExtrapWeights_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/toy_network.onnx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/MLogging.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSEnergyAndHitGANV2.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANEtaSlice.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANLWTNNHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSNetworkFactory.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSONNXHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSPredictExtrapWeights.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSSimpleLWTNNHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkBase.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkLWTNN.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/GenericNetwork_test.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSEnergyAndHitGANV2_test.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSPredictExtrapWeights_test.cxx
Adding @zhangr ,@jbeirer ,@jchapman ,@schaarsc ,@tadej as watchers
CI Result FAILURE (hash 11b24c22)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2981]This merge request affects 1 package:
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent
This merge request affects 30 files:
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/CMakeLists.txt
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/LinkDef.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/MLogging.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSEnergyAndHitGANV2.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANEtaSlice.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANLWTNNHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSNetworkFactory.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSONNXHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSPredictExtrapWeights.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSSimpleLWTNNHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkBase.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkLWTNN.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/GenericNetwork_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/NormPredExtrapSample/MeanStdDevEnergyFractions_eta_0_5.txt
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSEnergyAndHitGANV2_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSPredictExtrapWeights_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/toy_network.onnx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/MLogging.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSEnergyAndHitGANV2.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANEtaSlice.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANLWTNNHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSNetworkFactory.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSONNXHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSPredictExtrapWeights.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSSimpleLWTNNHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkBase.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkLWTNN.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/GenericNetwork_test.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSEnergyAndHitGANV2_test.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSPredictExtrapWeights_test.cxx
Adding @tadej ,@jchapman ,@schaarsc ,@jbeirer ,@zhangr as watchers
CI Result FAILURE (hash d38c04ce)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2983]added 1 commit
- 0fa7d1ec - Told the CMake to ignore pointer lines, and added something to the ref that...
This merge request affects 1 package:
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent
This merge request affects 30 files:
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/CMakeLists.txt
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/LinkDef.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/MLogging.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSEnergyAndHitGANV2.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANEtaSlice.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANLWTNNHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSNetworkFactory.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSONNXHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSPredictExtrapWeights.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSSimpleLWTNNHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkBase.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkLWTNN.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/GenericNetwork_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/NormPredExtrapSample/MeanStdDevEnergyFractions_eta_0_5.txt
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSEnergyAndHitGANV2_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSPredictExtrapWeights_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/toy_network.onnx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/MLogging.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSEnergyAndHitGANV2.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANEtaSlice.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANLWTNNHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSNetworkFactory.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSONNXHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSPredictExtrapWeights.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSSimpleLWTNNHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkBase.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkLWTNN.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/GenericNetwork_test.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSEnergyAndHitGANV2_test.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSPredictExtrapWeights_test.cxx
Adding @jchapman ,@jbeirer ,@schaarsc ,@tadej ,@zhangr as watchers
CI Result FAILURE (hash 0fa7d1ec)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2985]This merge request affects 1 package:
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent
This merge request affects 30 files:
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/CMakeLists.txt
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/LinkDef.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/MLogging.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSEnergyAndHitGANV2.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANEtaSlice.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANLWTNNHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSNetworkFactory.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSONNXHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSPredictExtrapWeights.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSSimpleLWTNNHandler.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkBase.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkLWTNN.h
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/GenericNetwork_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/NormPredExtrapSample/MeanStdDevEnergyFractions_eta_0_5.txt
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSEnergyAndHitGANV2_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSPredictExtrapWeights_test.ref
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/toy_network.onnx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/MLogging.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSEnergyAndHitGANV2.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANEtaSlice.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANLWTNNHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSNetworkFactory.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSONNXHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSPredictExtrapWeights.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSSimpleLWTNNHandler.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkBase.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkLWTNN.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/GenericNetwork_test.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSEnergyAndHitGANV2_test.cxx
- Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSPredictExtrapWeights_test.cxx
Adding @tadej ,@zhangr ,@jchapman ,@jbeirer ,@schaarsc as watchers
CI Result FAILURE (hash 37a0292c)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2986] CI Result SUCCESS (hash 8e1128be)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2987]added review-pending-level-2 label and removed review-pending-level-1 label
For the record, the parts with
#if ORT_API_VERSION > 11
are not present in 23.0!63562 (merged) also updated https://gitlab.cern.ch/atlas/athena/-/blob/main/Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCS2DFunctionLateralShapeParametrization.cxx?ref_type=heads#L122
- // We derive the shower shapes for electrons and positively charged hadrons. - // Particle with the opposite charge are expected to have the same shower shape - // after the transformation: delta_phi --> -delta_phi - if ((charge < 0. && pdgId!=11) || pdgId==-11) + // Particle with negative charge are expected to have the same shape as + // positively charged particles after transformation: delta_phi --> -delta_phi + if (charge < 0.) delta_phi_mm = -delta_phi_mm;
Is it intended to be left out?
191 191 } 192 192 193 193 simulstate.add_E(layer, Einit * energyInVoxel); 194 194 vox++; - Comment on lines 188 to 194
To match !63562 (merged), unless
energyInVoxel
can never be negative?
292 int binsInAlphaInRBin = GetAlphaBinsForRBin(x, ix, yBinNum); 292 const int binsInAlphaInRBin = GetAlphaBinsForRBin(x, ix, yBinNum); 293 293 294 294 // Horrible work around for variable # of bins along alpha direction 295 int binsToMerge = yBinNum == 32 ? 32 / binsInAlphaInRBin : 1; 295 const int binsToMerge = yBinNum == 32 ? 32 / binsInAlphaInRBin : 1; 296 296 for (int iy = 1; iy <= binsInAlphaInRBin; ++iy) { 297 double energyInVoxel = outputs.at("out_" + std::to_string(vox)); 298 int lowEdgeIndex = (iy - 1) * binsToMerge + 1; 297 const double energyInVoxel = outputs.at(std::to_string(vox)); 298 const int lowEdgeIndex = (iy - 1) * binsToMerge + 1; 299 299 300 300 ATH_MSG_VERBOSE(" Vox " << vox << " energy " << energyInVoxel 301 301 << " binx " << ix << " biny " << iy); 302 302 303 303 if (energyInVoxel <= 0) { To match !63562 (merged)
- Resolved by Joshua Falco Beirer
- Resolved by Joshua Falco Beirer
- Resolved by Joshua Falco Beirer
30 30 // LWTNN 31 31 #include "lwtnn/LightweightGraph.hh" 32 32 #include "lwtnn/LightweightNeuralNetwork.hh" 33 33 #include "lwtnn/parse_json.hh" - Comment on lines 31 to 33
This file presents significant differences with respect to what was included in !63562 (merged). Is it intended?
- Resolved by Joshua Falco Beirer
- Resolved by Joshua Falco Beirer
- Resolved by Joshua Falco Beirer
- Resolved by Joshua Falco Beirer
- Resolved by Joshua Falco Beirer
This is to a large extent a sweep of !63562 (merged) and looks mostly fine as is. Some differences should be confirmed though and the missing copyrights statements already raised in the review of the 23.0 MR should be added.
Best, Thomas - L2
added review-user-action-required label and removed review-pending-level-2 label
assigned to @jbeirer
mentioned in merge request !63562 (merged)
- Resolved by Joshua Falco Beirer
@jbeirer I tried to push to Henry's branch to resolve one of the copywrite threads (to test if I could and got): remote: You are not allowed to push code to this project. fatal: unable to access 'https://gitlab.cern.ch:8443/hdayhall/athena.git/': The requested URL returned error: 403 Do you find the same thing?
mentioned in merge request !68057 (merged)