Skip to content
Snippets Groups Projects

Adding ONNX compatability to FastCaloSim

Closed Henry Day-Hall requested to merge hdayhall/athena:ONNX_build_up into main
5 unresolved threads

Spiritual successor to !66216 (closed) Which is itself a variant on !63562 (merged). Look to !63562 (merged) for the best documentation.

This is a slightly abbreviated version of the above MR's because there is a problem somewhere in the changes to TFCSPredicExtrapWeights.cxx. This problem caused the CI to fail. The problem is quite specific, it mostly doesn't show up. TO reproduce it outside the CI, you can run the 23.0 branch (which already has the changes, because it has less CI on it);

asetup Athena,23.0,latest && \
ATHENA_CORE_NUMBER=0 Sim_tf.py  --AMIConfig a913 --inputEVNTFile /cvmfs/atlas-nightlies.cern.ch/repo/data/data-art/CampaignInputs/mc23/EVNT/mc23_13p6TeV.601229.PhPy8EG_A14_ttbar_hdamp258p75_SingleLep.evgen.EVNT.e8514/EVNT.32288062._002040.pool.root.1 --outputHITSFile myHITS.pool.root --imf False  --maxEvents 20

So I took out the changes to TFCSPredictExtrapWeights.cxx, that now only runs on lwtnn. This MR only changes the net in TFCEGANEtaSlice.cxx so that it may run on lwtnn or ONNX. This bit seems to work just fine.

As I'm leaving, I won't be able to interact with gitlab. I'm still happy to help, if there is anything you'd like to ask; henrydayhall@protonmail.com

Edited by Henry Day-Hall

Merge request reports

Checking pipeline status.

Closed by Thomas StreblerThomas Strebler 1 year ago (Jan 8, 2024 3:17pm UTC)

Merge details

  • The changes were not merged into main.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Jenkins please retry a build

  • This merge request affects 1 package:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

    This merge request affects 21 files:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/CMakeLists.txt
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/LinkDef.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/MLogging.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSEnergyAndHitGANV2.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANEtaSlice.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANLWTNNHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANXMLParameters.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSNetworkFactory.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSONNXHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSSimpleLWTNNHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkBase.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkLWTNN.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/MLogging.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSEnergyAndHitGANV2.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANEtaSlice.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANLWTNNHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSNetworkFactory.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSONNXHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSSimpleLWTNNHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkBase.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkLWTNN.cxx

    Adding @zhangr ,@jbeirer ,@jchapman ,@tadej ,@schaarsc as watchers

  • :white_check_mark: CI Result SUCCESS (hash fe627808)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2976]

  • Henry Day-Hall added 2 commits

    added 2 commits

    Compare with previous version

  • Henry Day-Hall added 1 commit

    added 1 commit

    • 463520fb - Removed refernces to VNetworkBase

    Compare with previous version

  • Jenkins please retry a build

  • This merge request affects 1 package:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

    This merge request affects 30 files:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/CMakeLists.txt
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/LinkDef.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/MLogging.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSEnergyAndHitGANV2.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANEtaSlice.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANLWTNNHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSNetworkFactory.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSONNXHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSPredictExtrapWeights.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSSimpleLWTNNHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkBase.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkLWTNN.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/GenericNetwork_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/NormPredExtrapSample/MeanStdDevEnergyFractions_eta_0_5.txt
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSEnergyAndHitGANV2_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSPredictExtrapWeights_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/toy_network.onnx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/MLogging.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSEnergyAndHitGANV2.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANEtaSlice.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANLWTNNHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSNetworkFactory.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSONNXHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSPredictExtrapWeights.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSSimpleLWTNNHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkBase.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkLWTNN.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/GenericNetwork_test.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSEnergyAndHitGANV2_test.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSPredictExtrapWeights_test.cxx

    Adding @jbeirer ,@tadej ,@zhangr ,@schaarsc ,@jchapman as watchers

  • Henry Day-Hall added 1 commit

    added 1 commit

    Compare with previous version

  • Henry Day-Hall added 1 commit

    added 1 commit

    • 93a8f9ab - Trying to fix the predict extrap test

    Compare with previous version

  • Jenkins please retry a build

  • :pencil: Build area was cleaned as per request posted in the DB. The full software build will be performed

  • This merge request affects 1 package:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

    This merge request affects 30 files:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/CMakeLists.txt
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/LinkDef.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/MLogging.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSEnergyAndHitGANV2.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANEtaSlice.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANLWTNNHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSNetworkFactory.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSONNXHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSPredictExtrapWeights.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSSimpleLWTNNHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkBase.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkLWTNN.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/GenericNetwork_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/NormPredExtrapSample/MeanStdDevEnergyFractions_eta_0_5.txt
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSEnergyAndHitGANV2_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSPredictExtrapWeights_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/toy_network.onnx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/MLogging.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSEnergyAndHitGANV2.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANEtaSlice.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANLWTNNHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSNetworkFactory.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSONNXHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSPredictExtrapWeights.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSSimpleLWTNNHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkBase.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkLWTNN.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/GenericNetwork_test.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSEnergyAndHitGANV2_test.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSPredictExtrapWeights_test.cxx

    Adding @jbeirer ,@jchapman ,@schaarsc ,@tadej ,@zhangr as watchers

  • :x: CI Result FAILURE (hash 463520fb)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2977]

  • Henry Day-Hall added 1 commit

    added 1 commit

    • 7e3149b1 - Added needed line with pdgid

    Compare with previous version

  • Jenkins please retry a build

  • This merge request affects 1 package:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

    This merge request affects 30 files:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/CMakeLists.txt
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/LinkDef.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/MLogging.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSEnergyAndHitGANV2.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANEtaSlice.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANLWTNNHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSNetworkFactory.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSONNXHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSPredictExtrapWeights.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSSimpleLWTNNHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkBase.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkLWTNN.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/GenericNetwork_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/NormPredExtrapSample/MeanStdDevEnergyFractions_eta_0_5.txt
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSEnergyAndHitGANV2_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSPredictExtrapWeights_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/toy_network.onnx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/MLogging.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSEnergyAndHitGANV2.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANEtaSlice.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANLWTNNHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSNetworkFactory.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSONNXHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSPredictExtrapWeights.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSSimpleLWTNNHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkBase.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkLWTNN.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/GenericNetwork_test.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSEnergyAndHitGANV2_test.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSPredictExtrapWeights_test.cxx

    Adding @schaarsc ,@tadej ,@jchapman ,@jbeirer ,@zhangr as watchers

  • Henry Day-Hall marked this merge request as ready

    marked this merge request as ready

  • Henry Day-Hall changed the description

    changed the description

  • Henry Day-Hall mentioned in merge request !66216 (closed)

    mentioned in merge request !66216 (closed)

  • :x: CI Result FAILURE (hash 7e3149b1)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2979]

  • :x: CI Result FAILURE (hash 93a8f9ab)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2978]

  • Jenkins please retry a build

  • This merge request affects 1 package:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

    This merge request affects 30 files:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/CMakeLists.txt
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/LinkDef.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/MLogging.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSEnergyAndHitGANV2.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANEtaSlice.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANLWTNNHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSNetworkFactory.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSONNXHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSPredictExtrapWeights.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSSimpleLWTNNHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkBase.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkLWTNN.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/GenericNetwork_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/NormPredExtrapSample/MeanStdDevEnergyFractions_eta_0_5.txt
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSEnergyAndHitGANV2_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSPredictExtrapWeights_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/toy_network.onnx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/MLogging.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSEnergyAndHitGANV2.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANEtaSlice.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANLWTNNHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSNetworkFactory.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSONNXHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSPredictExtrapWeights.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSSimpleLWTNNHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkBase.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkLWTNN.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/GenericNetwork_test.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSEnergyAndHitGANV2_test.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSPredictExtrapWeights_test.cxx

    Adding @zhangr ,@schaarsc ,@tadej ,@jbeirer ,@jchapman as watchers

  • :x: CI Result FAILURE (hash 7e3149b1)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2980]

  • Henry Day-Hall added 1 commit

    added 1 commit

    • 11b24c22 - Removed print and updated ref

    Compare with previous version

  • This merge request affects 1 package:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

    This merge request affects 30 files:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/CMakeLists.txt
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/LinkDef.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/MLogging.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSEnergyAndHitGANV2.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANEtaSlice.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANLWTNNHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSNetworkFactory.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSONNXHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSPredictExtrapWeights.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSSimpleLWTNNHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkBase.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkLWTNN.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/GenericNetwork_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/NormPredExtrapSample/MeanStdDevEnergyFractions_eta_0_5.txt
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSEnergyAndHitGANV2_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSPredictExtrapWeights_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/toy_network.onnx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/MLogging.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSEnergyAndHitGANV2.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANEtaSlice.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANLWTNNHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSNetworkFactory.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSONNXHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSPredictExtrapWeights.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSSimpleLWTNNHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkBase.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkLWTNN.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/GenericNetwork_test.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSEnergyAndHitGANV2_test.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSPredictExtrapWeights_test.cxx

    Adding @zhangr ,@jbeirer ,@jchapman ,@schaarsc ,@tadej as watchers

  • :x: CI Result FAILURE (hash 11b24c22)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2981]

  • Henry Day-Hall added 1 commit

    added 1 commit

    Compare with previous version

  • This merge request affects 1 package:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

    This merge request affects 30 files:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/CMakeLists.txt
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/LinkDef.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/MLogging.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSEnergyAndHitGANV2.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANEtaSlice.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANLWTNNHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSNetworkFactory.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSONNXHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSPredictExtrapWeights.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSSimpleLWTNNHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkBase.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkLWTNN.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/GenericNetwork_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/NormPredExtrapSample/MeanStdDevEnergyFractions_eta_0_5.txt
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSEnergyAndHitGANV2_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSPredictExtrapWeights_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/toy_network.onnx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/MLogging.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSEnergyAndHitGANV2.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANEtaSlice.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANLWTNNHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSNetworkFactory.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSONNXHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSPredictExtrapWeights.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSSimpleLWTNNHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkBase.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkLWTNN.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/GenericNetwork_test.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSEnergyAndHitGANV2_test.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSPredictExtrapWeights_test.cxx

    Adding @tadej ,@jchapman ,@schaarsc ,@jbeirer ,@zhangr as watchers

  • :x: CI Result FAILURE (hash d38c04ce)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2983]

  • Henry Day-Hall added 1 commit

    added 1 commit

    • 0fa7d1ec - Told the CMake to ignore pointer lines, and added something to the ref that...

    Compare with previous version

  • This merge request affects 1 package:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

    This merge request affects 30 files:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/CMakeLists.txt
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/LinkDef.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/MLogging.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSEnergyAndHitGANV2.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANEtaSlice.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANLWTNNHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSNetworkFactory.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSONNXHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSPredictExtrapWeights.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSSimpleLWTNNHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkBase.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkLWTNN.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/GenericNetwork_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/NormPredExtrapSample/MeanStdDevEnergyFractions_eta_0_5.txt
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSEnergyAndHitGANV2_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSPredictExtrapWeights_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/toy_network.onnx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/MLogging.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSEnergyAndHitGANV2.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANEtaSlice.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANLWTNNHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSNetworkFactory.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSONNXHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSPredictExtrapWeights.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSSimpleLWTNNHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkBase.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkLWTNN.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/GenericNetwork_test.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSEnergyAndHitGANV2_test.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSPredictExtrapWeights_test.cxx

    Adding @jchapman ,@jbeirer ,@schaarsc ,@tadej ,@zhangr as watchers

  • :x: CI Result FAILURE (hash 0fa7d1ec)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2985]

  • Henry Day-Hall added 1 commit

    added 1 commit

    • 37a0292c - Just removed the pointer print

    Compare with previous version

  • This merge request affects 1 package:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

    This merge request affects 30 files:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/CMakeLists.txt
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/LinkDef.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/MLogging.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSEnergyAndHitGANV2.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANEtaSlice.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSGANLWTNNHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSNetworkFactory.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSONNXHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSPredictExtrapWeights.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/TFCSSimpleLWTNNHandler.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkBase.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/ISF_FastCaloSimEvent/VNetworkLWTNN.h
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/GenericNetwork_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/NormPredExtrapSample/MeanStdDevEnergyFractions_eta_0_5.txt
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSEnergyAndHitGANV2_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/TFCSPredictExtrapWeights_test.ref
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/share/toy_network.onnx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/MLogging.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSEnergyAndHitGANV2.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANEtaSlice.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSGANLWTNNHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSNetworkFactory.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSONNXHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSPredictExtrapWeights.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSSimpleLWTNNHandler.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkBase.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/VNetworkLWTNN.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/GenericNetwork_test.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSEnergyAndHitGANV2_test.cxx
    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/test/TFCSPredictExtrapWeights_test.cxx

    Adding @tadej ,@zhangr ,@jchapman ,@jbeirer ,@schaarsc as watchers

  • :x: CI Result FAILURE (hash 37a0292c)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :o:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2986]

  • Henry Day-Hall added 1 commit

    added 1 commit

    • 8e1128be - Actually remove the pointer...

    Compare with previous version

  • This merge request affects 1 package:

    • Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

    This merge request affects 31 files. Since this is a long list, it will not be printed.

    Adding @tadej ,@jchapman ,@jbeirer ,@schaarsc ,@zhangr as watchers

  • :white_check_mark: CI Result SUCCESS (hash 8e1128be)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 2987]

  • Extensive changes, passing to L2.

    Cheers, Lucy (L1)

  • For the record, the parts with #if ORT_API_VERSION > 11 are not present in 23.0

191 191 }
192 192
193 193 simulstate.add_E(layer, Einit * energyInVoxel);
194 194 vox++;
  • Comment on lines 188 to 194
    Suggested change
    188 if (energyInVoxel <= 0) {
    189 vox++;
    190 continue;
    191 }
    192
    193 simulstate.add_E(layer, Einit * energyInVoxel);
    194 vox++;
    188 if (energyInVoxel != 0) {
    189 simulstate.add_E(layer, Einit * energyInVoxel);
    190 }
    191 vox++;

    To match !63562 (merged), unless energyInVoxel can never be negative?

  • Please register or sign in to reply
  • 292 int binsInAlphaInRBin = GetAlphaBinsForRBin(x, ix, yBinNum);
    292 const int binsInAlphaInRBin = GetAlphaBinsForRBin(x, ix, yBinNum);
    293 293
    294 294 // Horrible work around for variable # of bins along alpha direction
    295 int binsToMerge = yBinNum == 32 ? 32 / binsInAlphaInRBin : 1;
    295 const int binsToMerge = yBinNum == 32 ? 32 / binsInAlphaInRBin : 1;
    296 296 for (int iy = 1; iy <= binsInAlphaInRBin; ++iy) {
    297 double energyInVoxel = outputs.at("out_" + std::to_string(vox));
    298 int lowEdgeIndex = (iy - 1) * binsToMerge + 1;
    297 const double energyInVoxel = outputs.at(std::to_string(vox));
    298 const int lowEdgeIndex = (iy - 1) * binsToMerge + 1;
    299 299
    300 300 ATH_MSG_VERBOSE(" Vox " << vox << " energy " << energyInVoxel
    301 301 << " binx " << ix << " biny " << iy);
    302 302
    303 303 if (energyInVoxel <= 0) {
  • Thomas Strebler
  • Thomas Strebler
  • Thomas Strebler
  • 185 185 inputVariables["pdgId"] = 1; // one hot enconding
    186 186 } else if (is_match_pdgid(11) || is_match_pdgid(-11)) {
    187 187 inputVariables["pdgId"] = 0; // one hot enconding
    188 }
    188 };
  • 30 30 // LWTNN
    31 31 #include "lwtnn/LightweightGraph.hh"
    32 32 #include "lwtnn/LightweightNeuralNetwork.hh"
    33 33 #include "lwtnn/parse_json.hh"
  • Thomas Strebler
  • Thomas Strebler
  • Thomas Strebler
  • Thomas Strebler
  • Thomas Strebler
  • This is to a large extent a sweep of !63562 (merged) and looks mostly fine as is. Some differences should be confirmed though and the missing copyrights statements already raised in the review of the 23.0 MR should be added.

    Best, Thomas - L2

  • @jbeirer would you be able to address the comments since @hdayhall lost access?

  • Christopher Young mentioned in merge request !63562 (merged)

    mentioned in merge request !63562 (merged)

  • Joshua Falco Beirer mentioned in merge request !68057 (merged)

    mentioned in merge request !68057 (merged)

  • Please register or sign in to reply
    Loading