Adding ONNX compatability to FastCaloSim

Successor of !68004 (closed)

added Simulation label

mentioned in merge request !68004 (closed)

This merge request affects 1 package:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

This merge request affects 31 files. Since this is a long list, it will not be printed.

Adding @tadej ,@schaarsc ,@zhangr ,@jchapman ,@jbeirer as watchers

added main review-pending-level-1 labels

added review-user-action-required label

removed Simulation label

added Simulation label

Manual sweep of !63562 (merged) into main

For the record, the parts with #if ORT_API_VERSION > 11 are not present in 23.0

!63562 (merged) also updated https://gitlab.cern.ch/atlas/athena/-/blob/main/Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCS2DFunctionLateralShapeParametrization.cxx?ref_type=heads#L122

-  // We derive the shower shapes for electrons and positively charged hadrons.
-  // Particle with the opposite charge are expected to have the same shower shape
-  // after the transformation: delta_phi --> -delta_phi
-  if ((charge < 0. && pdgId!=11) || pdgId==-11)
+  // Particle with negative charge are expected to have the same shape as
+  // positively charged particles after transformation: delta_phi --> -delta_phi
+  if (charge < 0.)
    delta_phi_mm = -delta_phi_mm;

Is it intended to be left out?

I've just reported the remains open threads from !68004 (closed)

CI Result SUCCESS (hash 1d1bb6cf)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3058]

added 1 commit

• f7c6e1bb - Apply L2 suggestion

Compare with previous version

This merge request affects 1 package:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

This merge request affects 31 files. Since this is a long list, it will not be printed.

Adding @jbeirer ,@tadej ,@zhangr ,@schaarsc ,@jchapman as watchers

removed review-user-action-required label

resolved all threads

CI Result SUCCESS (hash f7c6e1bb)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3060]

@tstreble @tsulaia All L2 comments are addressed and the CI is passing - it would be awesome if this could go in today!

Approving as L2 - Thomas

added review-approved label and removed review-pending-level-1 label

mentioned in commit ddbcfa69

merged

mentioned in merge request !68079 (merged)

mentioned in merge request !68108 (merged)