Skip to content
Snippets Groups Projects

Addition of PRW to IDPVM

Merged Guglielmo Frattari requested to merge gfrattar/athena:gfrattar-prwidpvm into main

This MR introduces the possibility to run pileup reweighting within IDPVM. This will allow immediate comparison between data and mc samples for tracking quantities.

The implementation works with mc23 samples for which the setup of PRW is simplified thanks to the introduction of common PRW files. The attached plot shows the impact on the actual mu distribution when running over 1000 ttbar mc23a events (black no prw, red prw).

comparison_prw_noprw.pdf

Credits to @tstreble for the help with the implementation, tagging @jburzyns @skadir

Merge request reports

Pipeline #6708596 passed

Pipeline passed for 21b23068 on gfrattar:gfrattar-prwidpvm

Approval is optional

Merged by Vakhtang TsulaiaVakhtang Tsulaia 1 year ago (Jan 10, 2024 6:37pm UTC)

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • This merge request affects 1 package:

    • InnerDetector/InDetValidation/InDetPhysValMonitoring

    This merge request affects 5 files:

    • InnerDetector/InDetValidation/InDetPhysValMonitoring/InDetPhysValMonitoring/InDetPhysValMonitoringTool.h
    • InnerDetector/InDetValidation/InDetPhysValMonitoring/python/InDetPhysValFlags.py
    • InnerDetector/InDetValidation/InDetPhysValMonitoring/python/InDetPhysValMonitoringConfig.py
    • InnerDetector/InDetValidation/InDetPhysValMonitoring/scripts/runIDPVM.py
    • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/InDetPhysValMonitoringTool.cxx

    Adding @goetz ,@bkerridg ,@keli ,@lgagnon ,@sroe as watchers

  • :white_check_mark: CI Result SUCCESS (hash 03b4ecb0)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3092]

  • added 2 commits

    Compare with previous version

  • This merge request affects 1 package:

    • InnerDetector/InDetValidation/InDetPhysValMonitoring

    This merge request affects 5 files:

    • InnerDetector/InDetValidation/InDetPhysValMonitoring/InDetPhysValMonitoring/InDetPhysValMonitoringTool.h
    • InnerDetector/InDetValidation/InDetPhysValMonitoring/python/InDetPhysValFlags.py
    • InnerDetector/InDetValidation/InDetPhysValMonitoring/python/InDetPhysValMonitoringConfig.py
    • InnerDetector/InDetValidation/InDetPhysValMonitoring/scripts/runIDPVM.py
    • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/InDetPhysValMonitoringTool.cxx

    Adding @lgagnon ,@bkerridg ,@keli ,@sroe ,@goetz as watchers

  • added 1 commit

    Compare with previous version

  • This merge request affects 1 package:

    • InnerDetector/InDetValidation/InDetPhysValMonitoring

    This merge request affects 5 files:

    • InnerDetector/InDetValidation/InDetPhysValMonitoring/InDetPhysValMonitoring/InDetPhysValMonitoringTool.h
    • InnerDetector/InDetValidation/InDetPhysValMonitoring/python/InDetPhysValFlags.py
    • InnerDetector/InDetValidation/InDetPhysValMonitoring/python/InDetPhysValMonitoringConfig.py
    • InnerDetector/InDetValidation/InDetPhysValMonitoring/scripts/runIDPVM.py
    • InnerDetector/InDetValidation/InDetPhysValMonitoring/src/InDetPhysValMonitoringTool.cxx

    Adding @bkerridg ,@goetz ,@keli ,@lgagnon ,@sroe as watchers

  • added 2 commits

    • e1d78e83 - moving PRW configuration to AsgAnalysisAlgorithms
    • 4f6fc465 - make algorithm and tool setup used in IDPVM available for all users

    Compare with previous version

  • This merge request affects 2 packages:

    • InnerDetector/InDetValidation/InDetPhysValMonitoring
    • PhysicsAnalysis/Algorithms/AsgAnalysisAlgorithms

    Affected files list will not be printed in this case

    Adding @goetz ,@sroe ,@keli ,@lgagnon ,@bkerridg ,@tadej ,@krumnack as watchers

  • :white_check_mark: CI Result SUCCESS (hash da95aa33)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3110]

  • added 1 commit

    • 344e72a1 - moving prwtool with ca setup to another config

    Compare with previous version

  • added 1 commit

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading