Resolve cppcheck defects in TopAnalysis code

Resolve cppcheck performance defects: pass vector/map arguments by const ref instead of value.

This merge request affects 1 package:

• PhysicsAnalysis/TopPhys/xAOD/TopAnalysis

This merge request affects 2 files:

• PhysicsAnalysis/TopPhys/xAOD/TopAnalysis/scripts/MakeQuarkGluonFractionPlots.cxx
• PhysicsAnalysis/TopPhys/xAOD/TopAnalysis/scripts/MakeQuarkGluonFractionPlots.h

Adding @cgarvey ,@thsteven ,@skorn ,@ravinab as watchers

added Analysis AnalysisTop analysis-review-required main review-pending-level-1 labels

CI Result SUCCESS (hash 55aade6c)

	AnalysisBase
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
AnalysisBase: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3113]

The changes are straightforward and there are no issues with the CI. Approving from L1.

added review-approved label and removed review-pending-level-1 label

Hi @sroe,
Could you put a title for the MR that reflects the changes please?
The changes looks good to me, once done I will approve
Thanks in advance,
Romain - AR shifter

changed title from main-cppcheck-TopAnalysis to Resolve cppcheck defects in TopAnalysis code

removed analysis-review-required label

added analysis-review-approved label

Approving now since the title has been updated - AR

merged

mentioned in commit cf3343fe

mentioned in merge request !68104 (merged)