Infrastructure for Machine Learning inference with ONNX Runtime

This MR regroups the existing OnnxRuntime packages into an Onnx-specific package located at Control/AthOnnx. Breakdown of the changes.

• The new Onnx package implementation can be found in commit 61a8f24f. Accordingly, the ONNX example and GNN tracking are updated in the commit c3bf27d9.

• A small change in Control/AthenaConfiguration/python/AllConfigFlags.py to include the ONNX flags so that users can easily configure Onnx backends: here

• Remove the two packages that are no longer needed: Control/AthOnnxruntimeService and Control/AthOnnxruntimeUtils, see 0ac0c9a2. Because a couple of other packages are using the Control/AthOnnxruntimeService, keep it for now and update the Onnx inference in another MR.

Adding @akraszna @dbakshig

added ML-Inference onnx labels

assigned to @xju

This merge request affects 10 packages:

• Control/AthOnnx/AthOnnxComps
• Control/AthOnnx/AthOnnxConfig
• Control/AthOnnx/AthOnnxInterfaces
• Control/AthOnnx/AthOnnxUtils
• Control/AthOnnxruntimeService
• Control/AthOnnxruntimeUtils
• Control/AthenaConfiguration
• Control/AthenaExamples/AthExOnnxRuntime
• InnerDetector/InDetGNNTracking
• InnerDetector/InDetRecTools/InDetRecToolInterfaces

Affected files list will not be printed in this case

Adding @goetz ,@maszyman ,@gemmeren ,@gavrilen ,@rbianchi ,@ssnyder ,@sroe as watchers

added Core InnerDetector analysis-review-required full-unit-tests main review-pending-level-1 labels

CI integration tests for projects Athena,AnalysisBase,AthAnalysis are cancelled because of compilation error(s)

CI Result FAILURE (hash 0ac0c9a2)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 6, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 1, warnings 0
AthAnalysis: number of compilation errors 1, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3128]

added review-user-action-required label

added 1 commit

• a6fbcebb - address Tadej comments

Compare with previous version

This merge request affects 10 packages:

• Control/AthOnnx/AthOnnxComps
• Control/AthOnnx/AthOnnxConfig
• Control/AthOnnx/AthOnnxInterfaces
• Control/AthOnnx/AthOnnxUtils
• Control/AthOnnxruntimeService
• Control/AthOnnxruntimeUtils
• Control/AthenaConfiguration
• Control/AthenaExamples/AthExOnnxRuntime
• InnerDetector/InDetGNNTracking
• InnerDetector/InDetRecTools/InDetRecToolInterfaces

Affected files list will not be printed in this case

Adding @goetz ,@ssnyder ,@gavrilen ,@maszyman ,@rbianchi ,@sroe ,@gemmeren as watchers

removed review-user-action-required label

added 1 commit

• d0928e2a - additional comments

Compare with previous version

This merge request affects 10 packages:

• Control/AthOnnx/AthOnnxComps
• Control/AthOnnx/AthOnnxConfig
• Control/AthOnnx/AthOnnxInterfaces
• Control/AthOnnx/AthOnnxUtils
• Control/AthOnnxruntimeService
• Control/AthOnnxruntimeUtils
• Control/AthenaConfiguration
• Control/AthenaExamples/AthExOnnxRuntime
• InnerDetector/InDetGNNTracking
• InnerDetector/InDetRecTools/InDetRecToolInterfaces

Affected files list will not be printed in this case

Adding @gavrilen ,@rbianchi ,@gemmeren ,@ssnyder ,@goetz ,@sroe ,@maszyman as watchers

resolved all threads

CI integration tests for projects Athena,AnalysisBase,AthAnalysis are cancelled because of compilation error(s)

CI Result FAILURE (hash a6fbcebb)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 6, warnings 8
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 1, warnings 8
AthAnalysis: number of compilation errors 1, warnings 7
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3135]

added 1 commit

• cc52c20c - Revert "remove redundant packages"

Compare with previous version

CI integration tests for projects Athena,AnalysisBase,AthAnalysis are cancelled because of compilation error(s)

changed the description

This merge request affects 8 packages:

• Control/AthOnnx/AthOnnxComps
• Control/AthOnnx/AthOnnxConfig
• Control/AthOnnx/AthOnnxInterfaces
• Control/AthOnnx/AthOnnxUtils
• Control/AthenaConfiguration
• Control/AthenaExamples/AthExOnnxRuntime
• InnerDetector/InDetGNNTracking
• InnerDetector/InDetRecTools/InDetRecToolInterfaces

Affected files list will not be printed in this case

Adding @sroe ,@gavrilen ,@gemmeren ,@ssnyder ,@goetz ,@maszyman ,@rbianchi as watchers

CI Result FAILURE (hash d0928e2a)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 6, warnings 8
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 1, warnings 8
AthAnalysis: number of compilation errors 1, warnings 7
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3136]

CI Result SUCCESS (hash cc52c20c)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3140]

I see you reverted removal of legacy code. Are there too many clients to migrate at once?

What's the rational for creating 4 packages of which one of them (AthOnnxUtils) contains exactly one file? Do we expect that this grows significantly over time? If not, it might make more sense to just have two packages overall: one interface package and one that contains all the rest including the python configuration and utilities.

Setting back to review-user-action-required until threads are resolved.

Best, Thomas - L2

added review-user-action-required label and removed review-pending-level-1 label

added 745 commits

• cc52c20c...ce1f0bfb - 738 commits from branch atlas:main
• 80368fb4 - Merge branch 'up_main' into mr_onnx_onetool
• aaba270e - seperate tools
• 244dcc51 - inference tool
• 9ddb2682 - to inference
• 27c13e14 - update configurations
• db85d6cb - no ref
• 76a83735 - Merge branch 'up_main' into mr_onnx_onetool

Compare with previous version

This merge request affects 6 packages:

• Control/AthOnnx/AthOnnxComps
• Control/AthOnnx/AthOnnxInterfaces
• Control/AthenaConfiguration
• Control/AthenaExamples/AthExOnnxRuntime
• InnerDetector/InDetGNNTracking
• InnerDetector/InDetRecTools/InDetRecToolInterfaces

Affected files list will not be printed in this case

Adding @maszyman ,@gemmeren ,@rbianchi ,@sroe ,@gavrilen ,@goetz ,@ssnyder as watchers

added review-pending-level-1 label and removed review-user-action-required label

resolved all threads

CI Result FAILURE (hash 76a83735)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3834]

It looks like the CI can't find the test script added by the MR. Is this expected? Lucy (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 47 commits

• 76a83735...f5f1b008 - 46 commits from branch atlas:main
• 32ad840b - Merge branch 'up_main' into mr_onnx_onetool

Compare with previous version

This merge request affects 6 packages:

• Control/AthOnnx/AthOnnxComps
• Control/AthOnnx/AthOnnxInterfaces
• Control/AthenaConfiguration
• Control/AthenaExamples/AthExOnnxRuntime
• InnerDetector/InDetGNNTracking
• InnerDetector/InDetRecTools/InDetRecToolInterfaces

Affected files list will not be printed in this case

Adding @gavrilen ,@sroe ,@maszyman ,@gemmeren ,@ssnyder ,@rbianchi ,@goetz as watchers

added review-pending-level-1 label and removed review-user-action-required label

Hi @llewitt, the branch was out of sync with the main branch. I merged the latest main branch to this branch. Hopefully, the error will disappear.

added 2 commits

• 006da8da - fix testing issue
• e40a6155 - more robust

Compare with previous version

resolved all threads

CI Result FAILURE (hash 32ad840b)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3898]

This merge request affects 6 packages:

• Control/AthOnnx/AthOnnxComps
• Control/AthOnnx/AthOnnxInterfaces
• Control/AthenaConfiguration
• Control/AthenaExamples/AthExOnnxRuntime
• InnerDetector/InDetGNNTracking
• InnerDetector/InDetRecTools/InDetRecToolInterfaces

Affected files list will not be printed in this case

Adding @goetz ,@sroe ,@ssnyder ,@maszyman ,@gemmeren ,@gavrilen ,@rbianchi as watchers

CI Result SUCCESS (hash e40a6155)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3912]

There are no issues with the CI and the changes look okay but are extensive, so passing to L2 for comment.

— James for L1

added review-pending-level-2 label and removed review-pending-level-1 label

Looks good. Karolos (L2)

added review-approved label and removed review-pending-level-2 label

Hi, seems not affect analysis side, ask expert for a double check. Best regards, Rui AR shifter

added analysis-review-approved analysis-review-expert labels and removed analysis-review-required label

removed analysis-review-approved label

I'm generally okay with this setup. But still went with some comments, just to annoy everyone...

added 4 commits

• f7b148ad - factorize utils
• 1751a373 - address more comments
• 8600dea1 - up
• 4cdd90fe - less code

Compare with previous version

This merge request affects 7 packages:

• Control/AthOnnx/AthOnnxComps
• Control/AthOnnx/AthOnnxInterfaces
• Control/AthOnnx/AthOnnxUtils
• Control/AthenaConfiguration
• Control/AthenaExamples/AthExOnnxRuntime
• InnerDetector/InDetGNNTracking
• InnerDetector/InDetRecTools/InDetRecToolInterfaces

Affected files list will not be printed in this case

Adding @goetz ,@gavrilen ,@ssnyder ,@maszyman ,@rbianchi ,@sroe ,@gemmeren as watchers

added review-pending-level-1 label and removed review-approved label

resolved all threads

Hi @akraszna Thanks for these constructive comments! They are fully implemented.

CI Result SUCCESS (hash 4cdd90fe)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4130]

Sending back to L2. Clara (L1)

added review-approved label and removed review-pending-level-1 label

removed review-approved label

added review-pending-level-2 label

resolved all threads

All seems OK for a code sense, I'll take @akraszna's "I'm generally okay with this setup" as satisfying expert review on the wider implementation pattern.

We do still have an analysis-review-expert label here. I'm not sure who's most appropriate to ping on this for this situation.

Tim (L2)

added review-approved label and removed review-pending-level-2 label

Will ping @krumnack if he has anything else to say.

I don't think we are using ONNX Runtime yet, so I'd say fine for analysis.

Nils [Analysis RC]

added analysis-review-approved label and removed analysis-review-expert label

Thanks Nils!

As this is a big MR, I'll postpone it to after we build a release tomorrow or on Friday.

added RC Attention Required label

added 1 commit

• 08aaed04 - no release

Compare with previous version

resolved all threads

This merge request affects 7 packages:

• Control/AthOnnx/AthOnnxComps
• Control/AthOnnx/AthOnnxInterfaces
• Control/AthOnnx/AthOnnxUtils
• Control/AthenaConfiguration
• Control/AthenaExamples/AthExOnnxRuntime
• InnerDetector/InDetGNNTracking
• InnerDetector/InDetRecTools/InDetRecToolInterfaces

Affected files list will not be printed in this case

Adding @sroe ,@maszyman ,@gavrilen ,@gemmeren ,@rbianchi ,@goetz ,@ssnyder as watchers

added review-pending-level-1 label and removed review-approved label

CI Result SUCCESS (hash 08aaed04)

	Athena	AthSimulation	AthGeneration	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4193]

Changes look fine and the CI is good. All threads have been resolved. Approving.

Cheers, Yuriy (L1)

removed review-pending-level-1 label