Skip to content
Snippets Groups Projects

Resolve cppcheck defects in xAODTrigger

Merged Shaun Roe requested to merge sroe/athena:main-cppcheck-xAODTrigger into main
All threads resolved!

resolve "portability" issue reported by cppcheck: signed integer 1 would wrap around if shifted too far, should be unsigned long to match desired bytesize.

Edited by Shaun Roe

Merge request reports

Pipeline #6713503 passed

Pipeline passed for 301230ba on sroe:main-cppcheck-xAODTrigger

Merged by Vakhtang TsulaiaVakhtang Tsulaia 1 year ago (Jan 10, 2024 6:47pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Attila Krasznahorkay resolved all threads

    resolved all threads

  • :white_check_mark: CI Result SUCCESS (hash 301230ba)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3184]

  • Looks good to me. Approved.

    Cheers L1

  • Romain Bouquet changed title from main-cppcheck-xAODTrigger to Resolve "portability" issue reported by cppcheck in xAODTrigger package

    changed title from main-cppcheck-xAODTrigger to Resolve "portability" issue reported by cppcheck in xAODTrigger package

  • Romain Bouquet changed title from Resolve "portability" issue reported by cppcheck in xAODTrigger package to Resolve cppcheck defects in xAODTrigger

    changed title from Resolve "portability" issue reported by cppcheck in xAODTrigger package to Resolve cppcheck defects in xAODTrigger

  • Edited the title of the MR to harmonize with similar MR see !68086 (merged)

  • Approving the MR - AR

  • Vakhtang Tsulaia mentioned in commit bed2a540

    mentioned in commit bed2a540

  • Please register or sign in to reply
    Loading