LArProvenance bit-pattern: Use an Enum instead of hardcoded numbers

Introduce an enum instead of the hardcoded, error-prone numbers to describe how the a LAr signal was reconstructed. There are still many places where hardcoded numbers are used, to be cleaned up in subsequent MRs.

This merge request affects 4 packages:

• LArCalorimeter/LArCnv/LArByteStream
• LArCalorimeter/LArElecCalib
• LArCalorimeter/LArROD
• LArCalorimeter/LArRecEvent

Affected files list will not be printed in this case

Adding @bcarlson ,@damazio ,@pavol as watchers

added LAr main review-pending-level-1 labels

CI Result SUCCESS (hash ed055db0)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3188]

Looks good to me, approving.

Cheers, Lucy (L1)

added review-approved label and removed review-pending-level-1 label

Wait, I discovered a problem with the test-method.

added 1 commit

• d86c9c9d - LArProvenance: Fix LArProv::test method. Extend unit test.

Compare with previous version

This merge request affects 4 packages:

• LArCalorimeter/LArCnv/LArByteStream
• LArCalorimeter/LArElecCalib
• LArCalorimeter/LArROD
• LArCalorimeter/LArRecEvent

Affected files list will not be printed in this case

Adding @bcarlson ,@pavol ,@damazio as watchers

added review-pending-level-1 label and removed review-approved label

CI Result SUCCESS (hash d86c9c9d)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3213]

Looks good to me, again ;), approving.

Cheers, Lucy (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit cec71225

mentioned in merge request !68129 (merged)