LArProvenance bit-pattern: Use an Enum instead of hardcoded numbers

Introduce an enum instead of the hardcoded, error-prone numbers to describe how the a LAr signal was reconstructed. There are still many places where hardcoded numbers are used, to be cleaned up in subsequent MRs.

LArCalorimeter/LArElecCalib/LArElecCalib/LArProvenance.h

@@ -33,13 +33,12 @@ namespace LArProv {
   };
 
   inline bool test(const uint16_t prov, const LArProvenance check) {
-    if (check<0xF) {
-      //The first four bits are a number 
-      return ((prov & 0xF) == check);
+    if (check & 0xF) {
+      //The first four bits are a number, require exact match 
+      if ((prov & 0xF) != (check &0xF)) return false;
     }
-    else
-      //The remaining bits are independent
-      return ((prov & check) == check);
+    //The remaining bits are independent, check only if 'check' bits are set
+    return (((prov >>4)  & (check >>4)) ==  (check >>4));
   }
 
   
@@ -60,7 +59,7 @@ Bits 4 to 15 are flags:
 5 -> 0x20 RAMPDB
 6 -> 0x40 PEDSAMPLEZERO  
 7 -> 0x80 PEDDB
-8  -> 0x0100 ITERCONVERGED
+8 -> 0x0100 ITERCONVERGED
 9
 10 -> 0x0400 SATURATED
 11 -> 0x0800 MASKED