JetTagTools clean up #2

Second part of clean up of JetTagTools package:

• remove unused configurable properties
• remove unnecessary includes
• move to range-based loops when possible

added BTagging label

This merge request affects 1 package:

• PhysicsAnalysis/JetTagging/JetTagTools

This merge request affects 15 files:

• PhysicsAnalysis/JetTagging/JetTagTools/JetTagTools/MSVVariablesFactory.h
• PhysicsAnalysis/JetTagging/JetTagTools/JetTagTools/MV2Tag.h
• PhysicsAnalysis/JetTagging/JetTagTools/JetTagTools/MultiSVTag.h
• PhysicsAnalysis/JetTagging/JetTagTools/JetTagTools/MultivariateTagManager.h
• PhysicsAnalysis/JetTagging/JetTagTools/JetTagTools/NewLikelihoodTool.h
• PhysicsAnalysis/JetTagging/JetTagTools/JetTagTools/SVForIPTool.h
• PhysicsAnalysis/JetTagging/JetTagTools/JetTagTools/SVTag.h
• PhysicsAnalysis/JetTagging/JetTagTools/python/MV2TagConfig.py
• PhysicsAnalysis/JetTagging/JetTagTools/src/MSVVariablesFactory.cxx
• PhysicsAnalysis/JetTagging/JetTagTools/src/MV2Tag.cxx
• PhysicsAnalysis/JetTagging/JetTagTools/src/MultiSVTag.cxx
• PhysicsAnalysis/JetTagging/JetTagTools/src/MultivariateTagManager.cxx
• PhysicsAnalysis/JetTagging/JetTagTools/src/NewLikelihoodTool.cxx
• PhysicsAnalysis/JetTagging/JetTagTools/src/SVForIPTool.cxx
• PhysicsAnalysis/JetTagging/JetTagTools/src/SVTag.cxx

added Analysis JetEtmiss main review-pending-level-1 labels

CI Result FAILURE (hash 07dcd4ac)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3199]

mentioned in merge request !68108 (merged)

The crash is likely unrelated. We are seeing similar crashes intermittently on other MR-s as well. I'm going to open a JIRA ticket for it shortly. In the mean time I'll restart the CI here.

Jenkins please retry a build

This merge request affects 1 package:

• PhysicsAnalysis/JetTagging/JetTagTools

This merge request affects 15 files:

• PhysicsAnalysis/JetTagging/JetTagTools/JetTagTools/MSVVariablesFactory.h
• PhysicsAnalysis/JetTagging/JetTagTools/JetTagTools/MV2Tag.h
• PhysicsAnalysis/JetTagging/JetTagTools/JetTagTools/MultiSVTag.h
• PhysicsAnalysis/JetTagging/JetTagTools/JetTagTools/MultivariateTagManager.h
• PhysicsAnalysis/JetTagging/JetTagTools/JetTagTools/NewLikelihoodTool.h
• PhysicsAnalysis/JetTagging/JetTagTools/JetTagTools/SVForIPTool.h
• PhysicsAnalysis/JetTagging/JetTagTools/JetTagTools/SVTag.h
• PhysicsAnalysis/JetTagging/JetTagTools/python/MV2TagConfig.py
• PhysicsAnalysis/JetTagging/JetTagTools/src/MSVVariablesFactory.cxx
• PhysicsAnalysis/JetTagging/JetTagTools/src/MV2Tag.cxx
• PhysicsAnalysis/JetTagging/JetTagTools/src/MultiSVTag.cxx
• PhysicsAnalysis/JetTagging/JetTagTools/src/MultivariateTagManager.cxx
• PhysicsAnalysis/JetTagging/JetTagTools/src/NewLikelihoodTool.cxx
• PhysicsAnalysis/JetTagging/JetTagTools/src/SVForIPTool.cxx
• PhysicsAnalysis/JetTagging/JetTagTools/src/SVTag.cxx

Here is JIRA ticket for reference: ATLASSIM-7031

CI Result SUCCESS (hash 07dcd4ac)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3203]

Looks good to me, approving.

Cheers, Lucy (L1)

added review-approved label and removed review-pending-level-1 label

mentioned in commit c6406fce

merged