Second part of the Tau Trigger offline monitoring upgrade
This MR addresses the second part of the Tau Trigger offline monitoring upgrade (ATR-28611) that we've been working on with @mashamim, sending a single MR for simplicity:
- Split the monitoring implementation from a single-file monolithic algorithm, to dedicated classes:
-
TrigTauMonitorSingleAlgorithm
: single-tau HLT chain efficiency and distributions -
TrigTauMonitorL1Algorithm
: L1 efficiency and distributions -
TrigTauMonitorDiTauAlgorithm
: di-tau HLT chains efficiency and distributions -
TrigTauMonitorTandPAlgorithm
: tag-and-probe HLT chains efficiency and distributions -
TrigTauMonitorTruthAlgorithm
: truth efficiency and distributions
-
- Fixed the Phase1 L1 elements isolation threshold identification:
- Now both the isolation and E_T threshold values are retrieved from the L1Menu stored in the MetaData/DB.
- This also replaces the manual E_T remapping from the remap TriggerMenuMT file implemented in the first part of the monitoring update.
-
TrigTauInfo
class:- Now available in Python: removed duplicated implementation in
TrigTauMonitoringConfig.py
- Fixed the phantom L1 item retrieval from the L1Topo part of Legacy di-tau chains (now it's setting the correct isolation threshold)
- Now available in Python: removed duplicated implementation in
- Simplified monitored variable names: removed the mon-group name from the variable name in many of the mon-groups (unnecessary)
- Updated distributions axis labels with LaTeX formatting
- Added
highPt
eta and phi efficiency distributions, with offline/truth p_T cuts shifted by 20 GeV. These plots will better describe the efficiency in the the energy plateau regions. - Added
OnlineOnlyVars
folder, with distributions without the requirement of at least 1 offline good-quality tau in all events.
Edited by Jean Yves Beaucamp
Merge request reports
Activity
Filter activity
added 1 commit
- 333cbd47 - Removed no-offline-tau plots for ditau and T&P
This merge request affects 1 package:
- Trigger/TrigMonitoring/TrigTauMonitoring
This merge request affects 28 files:
- Trigger/TrigMonitoring/TrigTauMonitoring/CMakeLists.txt
- Trigger/TrigMonitoring/TrigTauMonitoring/README.md
- Trigger/TrigMonitoring/TrigTauMonitoring/Root/TrigTauInfo.cxx
- Trigger/TrigMonitoring/TrigTauMonitoring/TrigTauMonitoring/TrigTauInfo.h
- Trigger/TrigMonitoring/TrigTauMonitoring/TrigTauMonitoring/TrigTauMonitoringDict.h
- Trigger/TrigMonitoring/TrigTauMonitoring/TrigTauMonitoring/selection.xml
- Trigger/TrigMonitoring/TrigTauMonitoring/python/ManualChains.py
- Trigger/TrigMonitoring/TrigTauMonitoring/python/TrigTauInfo.py
- Trigger/TrigMonitoring/TrigTauMonitoring/python/TrigTauMonitorAlgorithm.py
- Trigger/TrigMonitoring/TrigTauMonitoring/python/TrigTauMonitoringConfig.py
- Trigger/TrigMonitoring/TrigTauMonitoring/python/init.py
- Trigger/TrigMonitoring/TrigTauMonitoring/src/TrigTauInfo.cxx
- Trigger/TrigMonitoring/TrigTauMonitoring/src/TrigTauInfo.h
- Trigger/TrigMonitoring/TrigTauMonitoring/src/TrigTauMonitorAlgorithm.cxx
- Trigger/TrigMonitoring/TrigTauMonitoring/src/TrigTauMonitorAlgorithm.h
- Trigger/TrigMonitoring/TrigTauMonitoring/src/TrigTauMonitorBaseAlgorithm.cxx
- Trigger/TrigMonitoring/TrigTauMonitoring/src/TrigTauMonitorBaseAlgorithm.h
- Trigger/TrigMonitoring/TrigTauMonitoring/src/TrigTauMonitorDiTauAlgorithm.cxx
- Trigger/TrigMonitoring/TrigTauMonitoring/src/TrigTauMonitorDiTauAlgorithm.h
- Trigger/TrigMonitoring/TrigTauMonitoring/src/TrigTauMonitorL1Algorithm.cxx
- Trigger/TrigMonitoring/TrigTauMonitoring/src/TrigTauMonitorL1Algorithm.h
- Trigger/TrigMonitoring/TrigTauMonitoring/src/TrigTauMonitorSingleAlgorithm.cxx
- Trigger/TrigMonitoring/TrigTauMonitoring/src/TrigTauMonitorSingleAlgorithm.h
- Trigger/TrigMonitoring/TrigTauMonitoring/src/TrigTauMonitorTandPAlgorithm.cxx
- Trigger/TrigMonitoring/TrigTauMonitoring/src/TrigTauMonitorTandPAlgorithm.h
- Trigger/TrigMonitoring/TrigTauMonitoring/src/TrigTauMonitorTruthAlgorithm.cxx
- Trigger/TrigMonitoring/TrigTauMonitoring/src/TrigTauMonitorTruthAlgorithm.h
- Trigger/TrigMonitoring/TrigTauMonitoring/src/components/TrigTauMonitoring_entries.cxx
Adding @ademaria ,@iriu ,@carquin ,@gipezzul ,@malconad as watchers
added DQ Tau Trigger main review-pending-level-1 labels
CI Result SUCCESS (hash 333cbd47)Athena externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4454]removed review-pending-level-1 label
added review-pending-level-2 label
- Resolved by Jean Yves Beaucamp
- Resolved by Jean Yves Beaucamp
- Resolved by Jean Yves Beaucamp
- Resolved by Jean Yves Beaucamp
Please register or sign in to reply