Add some guards against null pointers (ATLASSIM-7031.)

Tentative solution to https://its.cern.ch/jira/browse/ATLASSIM-7031. Since there seem to some conditions under which truth and extrapol are not allocated but fillEnergy is still called this doesn't seem like a unreasonable check to make before using them.

@jbeirer

Jenkins please retry a build

changed title from Draft: Add some guards against null pointers. to Draft: Add some guards against null pointers (ATLASSIM-7031.)

This merge request affects 1 package:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

This merge request affects 1 file:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSEnergyAndHitGANV2.cxx

Adding @jchapman ,@schaarsc ,@tadej ,@jbeirer ,@zhangr as watchers

added Simulation main labels

CI Result SUCCESS (hash b7330cea)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3333]

marked this merge request as ready

added review-pending-level-1 label

Hi @llewitt,

thank you for this. However, I don't think this is a good idea as it will essentially hide the real underlying issue and we might miss energy in our simulation with this.

We could replace the warnings with errors, so that we are sure that the exceptions are a result of an invalid truth or extrapol pointer.

Cheers,

Joshua

marked this merge request as draft

removed review-pending-level-1 label

added 1 commit

• 8463bf4f - Replace warnings with errors so the issue is properly reported.

Compare with previous version

Jenkins please retry a build

This merge request affects 1 package:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent

This merge request affects 1 file:

• Simulation/ISF/ISF_FastCaloSim/ISF_FastCaloSimEvent/src/TFCSEnergyAndHitGANV2.cxx

Adding @tadej ,@zhangr ,@jchapman ,@schaarsc ,@jbeirer as watchers

resolved all threads

CI Result SUCCESS (hash 8463bf4f)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3337]

marked this merge request as ready

added review-pending-level-1 label

The changes are straightforward and there are no issues with the CI. Approving from L1.

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 27178e0d