RecExCommon: Fix Tile data overlay legacy configuration (ATLASSIM-7035)

Tile data overlay legacy configuration has been modifed to force to recreate correct mapping from bytestream frag ID to TileCal drawer ID from the fist event.

This merge request affects 1 package:

• Reconstruction/RecExample/RecExCommon

This merge request affects 1 file:

• Reconstruction/RecExample/RecExCommon/share/BSRead_config.py

Adding @goetz as watcher

added Reconstruction main review-pending-level-1 labels

added Run2-DataOverlay-output-changed label

CI Result FAILURE (hash 3b8abb83)

	Athena	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3344]

The change is straightforward but the reference needs to be updated. Can this be expected soon, @harkusha?

-- James for L1

Hi @jbeacham, I'll try to do this now.
Cheers,
Siarhei

Hi @jbeacham,
Could you, please, remind me the procedure how to update the references?
Cheers,
Siarhei

Hi @harkusha. One of the experts has to do this. @goetz, do you know who is responsible for preparing new references for overlay?

The RC (me this week) takes care of the reference updates once the relevant coordinators set offline-sw-review-approved

added offline-sw-review-approved label

The changes look reasonable, thanks @harkusha . Feel free to update the references @wlampl

Pinging @christos, @jcatmore , @nstyles , @jchapman for their awareness.

@wlampl Presumably we shouldn't approve this until the references are actually updated to avoid CI failures in the nightly build?

Cheers, Lucy (L1)

added 1 commit

• eb566ff4 - update reference of d1590 test

Compare with previous version

This merge request affects 2 packages:

• Reconstruction/RecExample/RecExCommon
• Tools/WorkflowTestRunner

Affected files list will not be printed in this case

Adding @pagessin ,@goetz as watchers

added Tools label

As a general question - why do we still rely on the legacy configuration? RecExCommon is planned to be removed from the code base in the not too distant future.

CI Result SUCCESS (hash eb566ff4)

	Athena	AthSimulation	AthGeneration
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3362]

added review-approved label and removed review-pending-level-1 label

Looks good to me from an L1 perspective.

Approved.

Cheers L1

merged

mentioned in commit bb21fb15