Skip to content
Snippets Groups Projects

FTF GPU ITk: Cluster width cut and layer selection for middle SPs

Merged Aleksandra Poreba requested to merge aporeba/athena:ftf-gpu-pixel-cluster-2 into main
All threads resolved!
  • Add a cut on the cluster width for barrel spacepoints
  • Add a cut on significance
  • Use middle spacepoints only from defined set of layers, configurable by JO
  • Launch Dobulet Counting and Doublet Making kernels only on layers containing the middle spacepoints
  • Fix RoI/FullScan check
  • Fix size allocation for DETECTOR_MODEL for ITk

Tagging @demelian @bwynne @bkerridg

Edited by Aleksandra Poreba

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Benjamin Philip Kerridge resolved all threads

    resolved all threads

  • This merge request affects 5 packages:

    • Trigger/TrigAccel/TrigAccelEvent
    • Trigger/TrigAccel/TrigInDetAccel/TrigInDetAccelerationService
    • Trigger/TrigAccel/TrigInDetAccel/TrigInDetAccelerationTool
    • Trigger/TrigAccel/TrigInDetCUDA
    • Trigger/TrigAlgorithms/TrigFastTrackFinder

    Affected files list will not be printed in this case

    Adding @nagano ,@bkerridg ,@keli ,@sutt as watchers

  • :white_check_mark: CI Result SUCCESS (hash a651806f)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3732]

  • added 1 commit

    • c712635a - Add a custom fullscan roi check

    Compare with previous version

  • This merge request affects 5 packages:

    • Trigger/TrigAccel/TrigAccelEvent
    • Trigger/TrigAccel/TrigInDetAccel/TrigInDetAccelerationService
    • Trigger/TrigAccel/TrigInDetAccel/TrigInDetAccelerationTool
    • Trigger/TrigAccel/TrigInDetCUDA
    • Trigger/TrigAlgorithms/TrigFastTrackFinder

    Affected files list will not be printed in this case

    Adding @sutt ,@nagano ,@bkerridg ,@keli as watchers

  • Mark Sutton
  • :white_check_mark: CI Result SUCCESS (hash c712635a)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3743]

  • Ongoing discussion. Lucy (L1)

  • Mark Sutton resolved all threads

    resolved all threads

  • The changes look okay and there are no issues with the CI. Approving from L1.

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit 3050c74b

  • Please register or sign in to reply
    Loading