TileByteStream+TrigT2CaloCommon: Read mapping from BS frag ID to Tile drawer ID from DB

Tile configuration (CA-based) function to prepare conditions object with mapping from BS frag ID to Tile drawer ID has been modified to initialize it from DB by default.

This is done to resolve the issue with two Tile modules EBA61 and EBA63 (ROD fibers swapped) in 2022-2023 data.

The conditions algorithm which prepares mapping from BS frag ID to Tile drawer ID has been modified to use all available information from DB (including beam elements).

Tile ROD decoder tool has been modified to unpack DQ fragment when unpacking channels is requested, and to use the conditions object with mapping from BS frag ID to Tile drawer ID as argument in function used to fill Tile cell collection in HLT.

The clients (TrigCaloDataAccessSvc and Tile ROD decoder test) have been updated accordingly.

This merge request affects 2 packages:

• TileCalorimeter/TileSvc/TileByteStream
• Trigger/TrigAlgorithms/TrigT2CaloCommon

Affected files list will not be printed in this case

Adding @iouri ,@jlieberm ,@efurtado ,@harkusha ,@pavol ,@solodkov ,@eegidiop ,@damazio as watchers

added Tile Trigger main review-pending-level-1 labels

WARNING: big files (>100K) are found in the changeset

168K in file TileCalorimeter/TileSvc/TileByteStream/src/TileROD_Decoder.cxx

added Run3-DataReco-output-changed label

CI Result FAILURE (hash e6a0797b)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3592]

Did you Check for processing speed?

@harkusha CI failures are due to mismatches with the references. I'm not sure if these are intended or not. Lucy (L1)

added review-user-action-required label and removed review-pending-level-1 label

Hi @llewitt,
Some of the tests are failed due to the fact that
the corresponding folder has not been yet created in the MC DB.
So, we hope that it will be created today and we'll fix some tests.
Some tests, in which the 2022-2023 data are used are expected to be failed,
because we have the issue with two swapped Tile modules in these data,
and we would like to fix this issue with this MR.
Cheers,
Siarhei

This is also impacting the HLT re-reconstruction of low-threshold topo jets in existing data

chainComp INFO     Found 4 chains with count differences:
chainComp INFO       HLT_2j20_ftf_mb_afprec_afpdz10_L1RD0_FILLED:
chainComp INFO         stepFeatures:
chainComp INFO           1: 144 -> 143
chainComp INFO       HLT_2j20_ftf_mb_afprec_afpdz5_L1RD0_FILLED:
chainComp INFO         stepFeatures:
chainComp INFO           1: 144 -> 143
chainComp INFO       HLT_j15_L1RD0_FILLED:
chainComp INFO         stepFeatures:
chainComp INFO           0: 228 -> 230
chainComp INFO       HLT_j35_L1RD0_FILLED:
chainComp INFO         stepFeatures:
chainComp INFO           0: 39 -> 40

cc @xingguo & @miochoa, @lbeemste & @lshi

added 1 commit

• 61dba0a1 - TileByteStream: Confgigure mapping from BS frag ID to Tile drawer ID for MC DB

Compare with previous version

This merge request affects 2 packages:

• TileCalorimeter/TileSvc/TileByteStream
• Trigger/TrigAlgorithms/TrigT2CaloCommon

Affected files list will not be printed in this case

Adding @jlieberm ,@damazio ,@iouri ,@eegidiop ,@solodkov ,@efurtado ,@pavol ,@harkusha as watchers

added review-pending-level-1 label and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

168K in file TileCalorimeter/TileSvc/TileByteStream/src/TileROD_Decoder.cxx

CI Result FAILURE (hash 61dba0a1)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3654]

Changing label to review-user-action-required until the discussions are resolved. Clara (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• bfae7c71 - TrigP1Test: Update the references for HLT test

Compare with previous version

This merge request affects 3 packages:

• TileCalorimeter/TileSvc/TileByteStream
• Trigger/TrigAlgorithms/TrigT2CaloCommon
• Trigger/TrigValidation/TrigP1Test

Affected files list will not be printed in this case

Adding @martindl ,@pavol ,@harkusha ,@jlieberm ,@salderwe ,@eegidiop ,@okumura ,@solodkov ,@efurtado ,@damazio ,@vmartin ,@iouri as watchers

added changes-trigger-counts review-pending-level-1 labels and removed review-user-action-required label