Add R4 version of MDT hough transform

Add a first version of the Muon Hough transform for the WIP Phase-2 muon reconstruction. Use ACTS as back-end, while detector-specific work is handled in athena.

Also add validation package and required event data classes.

Documentation has been presented in the ITK Acts integration meeting.

Large MR since required ACTS version in Externals only recently arrived. Further development will happen in smaller MR.

added 81 commits

• db5c42d7...7742b1e0 - 71 earlier commits
• a2c616f7 - MET: Do not use global config flags
• d79ed404 - AthenaPoolMultiTest: Cleanup EventTag tests
• 02c99092 - Parameterizing the cluster splitting based on truth value
• 302462f1 - TrigPrescalesAlg: Add option for prescale based on trigger formula
• bacff7ea - Update ISF_Validation tests (part 4: cosmics simulation)
• a21d105d - Split vx_n_vs_mu plots in CampaignsARTTests
• 88380a07 - juchu!
• 088fa28f - update MuonPatternEvent
• edbdab9e - complete first iter of hough alg
• 51f9dea8 - add hough validation alg

Compare with previous version

added 483 commits

• 51f9dea8...f2494fd8 - 481 commits from branch atlas:main
• 2efd2eca - t fetch upstream
• a85f9009 - Merge remote-tracking branch 'upstream/main' into mg_P2_MuonHoughAlg_modPaGessin

Compare with previous version

added 1 commit

• 4007e166 - more tweaks WIP

Compare with previous version

Following the creation of the 24.0 branch from main, you should now decide whether this MR should target 24.0 or main, according to these guidelines agreed in the Software Weekly meeting: https://indico.cern.ch/event/1382755/attachments/2802320/4889268/BranchingGuidelines24.pdf

If you decide that this MR should target 24.0, please re-direct it by editing and changing the target branch in the drop-down menu. If it should stay in master, please indicate this as a reply to this message. Remember that all MRs going into 24.0 will also be swept into main.

added 513 commits

• 4007e166...b57e29b6 - 509 commits from branch atlas:main
• e8658937 - Merge remote-tracking branch 'upstream/main' into mg_P2_MuonHoughAlg_modPaGessin
• aacb6678 - add some more WIP code
• e08210ae - Merge branch 'MG_chamberParsRpc' into mg_P2_MuonHoughAlg_modPaGessin
• 613163e6 - stfu

Compare with previous version

added 450 commits

• 613163e6...9bfafbd0 - 449 commits from branch atlas:main
• 8676c73c - Introduce Hough algorithm & Hough pattern event

Compare with previous version

added 637 commits

• 8676c73c...f8651c6e - 636 commits from branch atlas:main
• 5a6b0408 - Introduce Hough algorithm & Hough pattern event

Compare with previous version

added 3 commits

• 8676c73c - Introduce Hough algorithm & Hough pattern event
• 14836bd4 - move to a coarser P2 Hough binning inspired by existing hough
• 2d5cc28e - RPC support in Phase2 Hough tester

Compare with previous version

added 639 commits

• 2d5cc28e...f8651c6e - 636 commits from branch atlas:main
• ef82e6af - Introduce Hough algorithm & Hough pattern event
• 960f5450 - move to a coarser P2 Hough binning inspired by existing hough
• 53526369 - RPC support in Phase2 Hough tester

Compare with previous version

added 1 commit

• 9505d638 - Fix largely the compilation

Compare with previous version

added 1 commit

• 9a9981b7 - Fix the maxima part

Compare with previous version

added 212 commits

• 9a9981b7...953e407c - 206 commits from branch atlas:main
• 750fa98d - Introduce Hough algorithm & Hough pattern event
• 2c27730a - move to a coarser P2 Hough binning inspired by existing hough
• 4ab20211 - RPC support in Phase2 Hough tester
• 99f90d16 - Fix largely the compilation
• e172bee3 - Fix the maxima part
• 99e6d06e - add support for TGC and adapt latest changes to phase-2 geo

Compare with previous version

resolved all threads

Jenkins please retry a build

build area is cleaned as the previous build was for the MR labeled as full-build

This merge request affects 3 packages:

• MuonSpectrometer/MuonPhaseII/MuonPatternRecognition/MuonPatternEvent
• MuonSpectrometer/MuonPhaseII/MuonPatternRecognition/MuonPatternRecognitionAlgs
• MuonSpectrometer/MuonPhaseII/MuonValidation/MuonPatternRecognitionTest

Affected files list will not be printed in this case

Adding @pscholer ,@kluit ,@apsallid ,@stavrop ,@jojungge ,@rosati as watchers

added MuonSpectrometer Upgrade main labels

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI Result FAILURE (hash 99e6d06e)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5978] (remote access info)

added 284 commits

• 99e6d06e...1c0b4613 - 278 commits from branch atlas:main
• 35efe1af - Introduce Hough algorithm & Hough pattern event
• d505490a - move to a coarser P2 Hough binning inspired by existing hough
• f4904ca7 - RPC support in Phase2 Hough tester
• befb518a - Fix largely the compilation
• 46b5a324 - Fix the maxima part
• 3e50319a - add support for TGC and adapt latest changes to phase-2 geo

Compare with previous version

marked this merge request as ready

added 973 commits

• 3e50319a...023d47a7 - 972 commits from branch atlas:main
• ffff15ea - First version of hough acts muon algorithm

Compare with previous version

Jenkins please retry a build

This merge request affects 5 packages:

• MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonGeoModelTestR4
• MuonSpectrometer/MuonPhaseII/MuonPatternRecognition/MuonPatternEvent
• MuonSpectrometer/MuonPhaseII/MuonPatternRecognition/MuonPatternRecognitionAlgs
• MuonSpectrometer/MuonPhaseII/MuonSpacePointFormation
• MuonSpectrometer/MuonPhaseII/MuonValidation/MuonPatternRecognitionTest

Affected files list will not be printed in this case

Adding @kluit ,@rosati ,@stavrop ,@apsallid ,@pscholer ,@jojungge as watchers

added review-pending-level-1 label

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

changed the description

removed review-pending-level-1 label

added review-pending-level-1 label

CI Result SUCCESS (hash ffff15ea)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 7077] (remote access info)

added review-pending-level-2 label

removed review-pending-level-1 label

changed the description

Looks good, approving - L2

added review-approved label and removed review-pending-level-2 label

merged

mentioned in commit ba092933