AFP_Calibration: Fix cppcheck warnings.

Pass strings/containers by const reference, not by value. Reorder some vector operations to clarify that references are not being invalidated.

This merge request affects 1 package:

• ForwardDetectors/AFP/AFP_Calibration

This merge request affects 4 files:

• ForwardDetectors/AFP/AFP_Calibration/AFP_Calibration/AFP_NoisyPixelTool.h
• ForwardDetectors/AFP/AFP_Calibration/AFP_Calibration/AFP_PixelIdentifier.h
• ForwardDetectors/AFP/AFP_Calibration/src/AFP_NoisyPixelTool.cxx
• ForwardDetectors/AFP/AFP_Calibration/src/AFP_PixelIdentifier.cxx

Adding @battagl ,@lshan ,@stsuno as watchers

added ForwardDetectors main review-pending-level-1 labels

CI Result SUCCESS (hash ab49ff0f)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3643]

Changes look fine and the CI is good. Approving. Clara (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 762b431e