MuonR4 data preparation - Add Tgc & Rpc strip hit conversion from Sim hits & misc

xAODMuonPrepData

• Add setters & getters of the readout element. If the container is loaded from the disk, the xAOD::Measurement tries to retrieve the readout element on-the fly from the StoreGate
• RpcStrips & TgcStrips Add the Identifier fields as data members RpcReadoutElement
  • Simplify the translation of the Identifier fields to the measurement hash which allows to declare the method to be static
  • Remove the isUpsideDown flag as we're reversing the order of the chamber components if this flag is switched on

xAODMuonSimHitCnv

• Introduce algorithms that convert the MuonSimHits of the Rpcs & Tgcs into Uncalibrated measurements. The precision coordinate of the corresponding layer is smeared with a Gaussian with a width propotional to the strip pitch

Tagging: @emoyse, @goblirsc, @pscholer, @ivyas

Jenkins please retry a build

This merge request affects 6 packages:

• MuonSpectrometer/MuonPhaseII/Event/xAOD/xAODMuonPrepData
• MuonSpectrometer/MuonPhaseII/MuonCnv/MuonHitCsvDump
• MuonSpectrometer/MuonPhaseII/MuonCnv/xAODMuonSimHitCnv
• MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonGeoModelR4
• MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonReadoutGeometryR4
• MuonSpectrometer/MuonPhaseII/MuonDetDescr/MuonStationGeoHelpers

Affected files list will not be printed in this case

Adding @toyamaza ,@jojungge ,@cvarni ,@apsallid ,@pscholer ,@rosati ,@kluit ,@adye ,@tbold ,@pagessin ,@stavrop as watchers

added ACTS MuonSpectrometer main labels

CI Result FAILURE (hash 1466a539)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3646]

added Upgrade label

added 43 commits

• 1466a539...b5c8554e - 35 commits from branch atlas:main
• ba5862d3 - Make the measurementHash static.
• df9a6d8d - Add readout element to the interface
• cc54d2bd - Add Identifier fields & retrieve the readout element
• 2aa75388 - Add identifier fields & readout element retrieval
• c95c0c65 - Add SimHit -> Rpc/Tgc measurement conversion alg
• 80b2e413 - Write hit csv dumper
• f4be3bb1 - Add strip config
• 1bdcb469 - Fix phi index assignment issue

Compare with previous version

resolved all threads

Hi @jojungge - I'm not sure about this "auto-retrieve" functionality! It seems like too much intelligence to put into an xAOD object. Are there any other examples of similarly complex retrieval? I would rather just insert the ReadoutElement on construction and keep the EDM as dumb as possible.

Also, I'm struggling to remember how this all works, but a service cannot have state (obviously) but the geometry does have alignment ... so are there any possible implications for the scheduler?

I have not seen any examples myself but exploited kind of a similar mechanism to create a complex object on-the fly for the SimHits. I've put in this mechanism because we cannot peristify the link to the readout element. So if we load the measurements from the file again, they won't have a readout element link. I've no clue how the xAOD disk reading mechanism is implemented at all.

In Run4, there will be only 1 readout geometry instantiated. The alignment & other corrections are parsed to the geometry via the GeometryContext which is a conditions object.

added 1 commit

• 25755b1f - First running version

Compare with previous version

added 71 commits

• 25755b1f...ce91e83c - 70 commits from branch atlas:main
• cead33f8 - Merge remote-tracking branch 'upstream/main' into RpcFastDigi

Compare with previous version

mentioned in merge request !68393 (merged)

added 5 commits

• cead33f8...7ac48916 - 4 commits from branch atlas:main
• 42ebd6e6 - Add algorithms to convert Rpc & Tgc sim hits into xAODMuonPrepData

Compare with previous version

marked this merge request as ready

added review-user-action-required label

Jenkins please retry a build

This merge request affects 1 package:

• MuonSpectrometer/MuonPhaseII/MuonCnv/xAODMuonSimHitCnv

This merge request affects 8 files:

• MuonSpectrometer/MuonPhaseII/MuonCnv/xAODMuonSimHitCnv/python/MuonSimHitCnvCfg.py
• MuonSpectrometer/MuonPhaseII/MuonCnv/xAODMuonSimHitCnv/src/components/xAODMuonSimHitCnv_entries.cxx
• MuonSpectrometer/MuonPhaseII/MuonCnv/xAODMuonSimHitCnv/src/xAODSimHitToMdtMeasCnvAlg.cxx
• MuonSpectrometer/MuonPhaseII/MuonCnv/xAODMuonSimHitCnv/src/xAODSimHitToMmMeasCnvAlg.cxx
• MuonSpectrometer/MuonPhaseII/MuonCnv/xAODMuonSimHitCnv/src/xAODSimHitToRpcMeasCnvAlg.cxx
• MuonSpectrometer/MuonPhaseII/MuonCnv/xAODMuonSimHitCnv/src/xAODSimHitToRpcMeasCnvAlg.h
• MuonSpectrometer/MuonPhaseII/MuonCnv/xAODMuonSimHitCnv/src/xAODSimHitToTgcMeasCnvAlg.cxx
• MuonSpectrometer/MuonPhaseII/MuonCnv/xAODMuonSimHitCnv/src/xAODSimHitToTgcMeasCnvAlg.h

Adding @stavrop ,@jojungge ,@pscholer ,@rosati ,@kluit ,@apsallid as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash 42ebd6e6)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3738]