B-physics trigger: switch from EM3 to eEM5 L1Seed in R(K*) bBeeM6000 chains (ATR-28162)

Switch from 'EM3' to 'eEM5' L1 seeds in bBeeM6000 chains:

• add L1_BKeePrimaryLegacy/L1_BKeePrescaledLegacy for preserving the current behaviour (data 2023)
• L1_BKeePrimary/L1_BKeePrescaled use only Phase 1 L1/L1Topo items
• explicitly mention l1SeedThresholds in the chain legs definitions for chains seeded from L1_All: HLT_e5_lhvloose_L1eEM5_bBeeM6000_L1All, HLT_e5_lhvloose_L1EM3_bBeeM6000_L1All (legacy)
• found no Phase 1 replacement for 'L1_MU8F_TAU20IM', 'L1_MU8F_TAU12IM_3J12', 'L1_EM15VHI_2TAU12IM_XE35', 'L1_EM15VHI_2TAU12IM_4J12' and 'L1_3J15p0ETA25_XE40' L1 items
• for 'L1_jJ80' (legacy 'L1_J40') from L1BKeePrescaled list found CheckL1HLTConsistency ERROR Missing L1 items: L1_jJ80 - to be followed later
• for 'L1_eTAU60_2cTAU20M_jXE80' (legacy 'L1_TAU40_2TAU12IM_XE40') from TriggerMenuMT:L1Seeds ERROR L1 item L1_eTAU60_2cTAU20M_jXE80 from L1_BKeePrimary seeds is not in current L1 menu - to be followed later
• add 'HLT_e5_lhvloose_e3_lhvloose_bBeeM6000_L1BKeePrimary' and 'HLT_e5_lhvloose_e3_lhvloose_bBeeM6000_L1BKeePrescaled' chains to Dev_pp_run3_v1 menu to estimate the rates
• minimum transverse energy of the cluster associated with close-by electron should be greater than 3 GeV

CC @abarton @jakoubek @dmankad @hod @lidiaz

added TriggerMenu changes-trigger-counts main review-pending-level-1 labels

changed the description

This merge request affects 3 packages:

• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigP1Test
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @iriu ,@okumura ,@gipezzul ,@ademaria ,@lidiaz ,@sutt ,@ggonella ,@vmartin ,@carquin ,@malconad ,@martindl ,@salderwe ,@shanisch as watchers

added Trigger label

WARNING: big files (>100K) are found in the changeset

116K in file Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/Dev_pp_run3_v1.py

460K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

428K in file Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/Physics_pp_run3_v1.py

268K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

CI Result SUCCESS (hash a3ccfd87)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3650]

Changing label to review-user-action-required until the discussions are resolved. Clara (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 36f16f66 - add L1_AllLegacy, L1_BKeePrimaryLegacy and L1_BKeePrescaledLegacy seeds to run...

Compare with previous version

This merge request affects 3 packages:

• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigP1Test
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @lidiaz ,@shanisch ,@malconad ,@carquin ,@salderwe ,@gipezzul ,@sutt ,@ademaria ,@hrussell ,@martindl ,@vmartin ,@ggonella ,@iriu ,@okumura as watchers

added review-pending-level-1 label and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

116K in file Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/Dev_pp_run3_v1.py

428K in file Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/Physics_pp_run3_v1.py

268K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

460K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

CI Result SUCCESS (hash 36f16f66)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3682]

Dear @khoo @lidiaz @tamartin could you have a look to the next iteration?

added review-approved-point1 label

added review-user-action-required label and removed review-pending-level-1 label

As RC: What needs to be done here it has review-user-action-required ?

Please resolve threads and relabel back to review if nothing else needs to be done.

As RC: Sorry a conflict has arisen.

marked this merge request as draft

added 116 commits

• 36f16f66...fff8a345 - 114 commits from branch atlas:main
• 5d77c343 - fix conflict in MC_pp_run4_v1.py
• 98bd3a33 - fix L1 seeds

Compare with previous version

added 1 commit

• 825babea - remove L1AllLegacy

Compare with previous version

added 47 commits

• 825babea...4cf75edb - 46 commits from branch atlas:main
• e3afa4c8 - fix conflict

Compare with previous version

added 1 commit

• 4572f1ce - fix in getSpecificL1Seeds

Compare with previous version

Jenkins please retry build

added 1 commit

• 5e00fbc9 - fix ref files

Compare with previous version

marked this merge request as ready

changed the description

@khoo could you please check the current status?

I've removed L1_AllLegacy to avoid possible confusions and checked the HLT_(2)e5_lhvloose_L1eEM5_bBeeM6000_L1All has exactly the same number of counts/features as for HLT_(2)e5_lhvloose_bBeeM6000_L1All with l1SeedThresholds=['eEM5'] Same is true for HLT_(2)e5_lhvloose_L1EM3_bBeeM6000_L1All. It coincides with HLT_(2)e5_lhvloose_bBeeM6000_L1All with l1SeedThresholds=['EM3']

resolved all threads

added review-pending-level-1 label

removed review-user-action-required label

Looks great to me, thanks for the work!

One thing that occurred to me is that relaxing the HLT threshold to 3 GeV might then hit a wall due to the L1 seeding starting from eEM5, but not much to do besides try it and see if it delivers the expected improvement.

The changes are straightforward and there are no issues with the CI. Approving from L1.

added review-approved label and removed review-pending-level-1 label

@jbeacham could we force Jenkins to restart CI for this MR?

I am a little bit afraid I could spoil ref files for egamma/tau counts?

Jenkins please retry a build

Jenkins please retry a build

This merge request affects 4 packages:

• Trigger/TrigHypothesis/TrigBphysHypo
• Trigger/TrigValidation/TrigAnalysisTest
• Trigger/TrigValidation/TrigP1Test
• Trigger/TriggerCommon/TriggerMenuMT

Affected files list will not be printed in this case

Adding @lidiaz ,@sutt ,@okumura ,@vmartin ,@abarton ,@iriu ,@shanisch ,@gipezzul ,@malconad ,@carquin ,@lyubushk ,@ggonella ,@salderwe ,@ademaria ,@martindl as watchers

added review-pending-level-1 label and removed review-approved review-approved-point1 labels

WARNING: big files (>100K) are found in the changeset

424K in file Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/Physics_pp_run3_v1.py

464K in file Trigger/TrigValidation/TrigAnalysisTest/share/ref_RDOtoRDOTrig_v1Dev_build.ref

116K in file Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Menu/Dev_pp_run3_v1.py

272K in file Trigger/TrigValidation/TrigP1Test/share/ref_v1Dev_decodeBS_build.ref

CI Result FAILURE (hash 5e00fbc9)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3811]

marked this merge request as draft

added 1 commit

• 70bf498c - fix ref files

Compare with previous version

marked this merge request as ready

changed the description