HLTResultByteStreamCnv: Destroy the incoming address if exists and recreate

• Fixes the memory leak encountered in DataModelRunTests_ByteStreamTestWrite: !68406 (comment 7685890)
• Resolves the issue described in !68171 (comment 7523469).

/cc @gemmeren

added full-integration-tests full-unit-tests labels

Jenkins please retry the build

This merge request affects 1 package:

• Trigger/TrigSteer/TrigHLTResultByteStream

This merge request affects 1 file:

• Trigger/TrigSteer/TrigHLTResultByteStream/src/HLTResultByteStreamCnv.cxx

Adding @tamartin ,@fpastore as watchers

added Trigger main labels

CI Result SUCCESS (hash 36d9e6f7)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3734]

added 1 commit

• d6219cb4 - add the reference of the address object

Compare with previous version

Jenkins please retry the build

This merge request affects 1 package:

• Trigger/TrigSteer/TrigHLTResultByteStream

This merge request affects 1 file:

• Trigger/TrigSteer/TrigHLTResultByteStream/src/HLTResultByteStreamCnv.cxx

Adding @fpastore ,@tamartin as watchers

CI Result SUCCESS (hash d6219cb4)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3815]

added 1 commit

• 798216fb - release the original address if exists, to prevent the leak

Compare with previous version

Jenkins please retry the build

This merge request affects 1 package:

• Trigger/TrigSteer/TrigHLTResultByteStream

This merge request affects 1 file:

• Trigger/TrigSteer/TrigHLTResultByteStream/src/HLTResultByteStreamCnv.cxx

Adding @tamartin ,@fpastore as watchers

CI Result SUCCESS (hash 798216fb)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3846]

Following the creation of the 24.0 branch from main, you should now decide whether this MR should target 24.0 or main, according to these guidelines agreed in the Software Weekly meeting: https://indico.cern.ch/event/1382755/attachments/2802320/4889268/BranchingGuidelines24.pdf

If you decide that this MR should target 24.0, please re-direct it by editing and changing the target branch in the drop-down menu. If it should stay in master, please indicate this as a reply to this message. Remember that all MRs going into 24.0 will also be swept into main.

As discussed with @gemmeren about !68406 (comment 7685890), we think this MR should proceed as is:

• It fixes the memory leak encountered only in DataModelRunTests_ByteStreamTestWrite.
• In DRAW production we are using ByteStreamOutputStreamCopyTool (judging from the configuration), therefore we do not suffer from the memory leak resulting from the usage of AthenaOutputStreamTool::streamObjects in combination with ByteStream converters.
• It enables to proceed with the improvement in !68171 (merged).
• It avoids changing AthenaOutputStreamTool to create a correct of the object which implies adding a dependency on ByteStreamCnvSvcBaseLib in AthenaServices.

changed title from Draft: HLTResultByteStreamCnv: do not overwrite the address if exists to Draft: HLTResultByteStreamCnv: Destroy the incoming address if exists and recreate

changed the description

added 2240 commits

• 798216fb...b9a6001c - 2237 commits from branch atlas:main
• 11562da6 - HLTResultByteStreamCnv: do not overwrite the address if exists
• 3dcd3f21 - add the reference of the address object
• 684413e4 - release the original address if exists, to prevent the leak

Compare with previous version

resolved all threads

marked this merge request as ready

Jenkins please retry the build

This merge request affects 1 package:

• Trigger/TrigSteer/TrigHLTResultByteStream

This merge request affects 1 file:

• Trigger/TrigSteer/TrigHLTResultByteStream/src/HLTResultByteStreamCnv.cxx

Adding @fpastore ,@tamartin as watchers

added review-pending-level-1 label

CI Result SUCCESS (hash 684413e4)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5906] (remote access info)

removed review-pending-level-1 label

removed main label

added review-user-action-required label

added 49 commits

• 684413e4...d4bb65a2 - 30 commits from branch atlas:main
• d4bb65a2...350084d5 - 9 earlier commits
• 2051cd1d - Merge branch 'dta-q445_serialfix' into '24.0'
• 66ac9d18 - Merge branch 'FixATLASSIM-7095_24.0' into '24.0'
• c6c8631f - Merge branch 'bdong-24.0-patch-db5e' into '24.0'
• b828c171 - Merge branch 'recofix' into '24.0'
• 3324aed4 - Merge branch 'xaodtruth' into '24.0'
• dbd99a28 - Backport oracle fixes from main
• 0acede7f - Merge branch '24.0-dq-oracle' into '24.0'
• 82389559 - HLTResultByteStreamCnv: do not overwrite the address if exists
• cb047242 - add the reference of the address object
• 165e0fcc - release the original address if exists, to prevent the leak

Compare with previous version

changed target branch from main to 24.0

This merge request affects 1 package:

• Trigger/TrigSteer/TrigHLTResultByteStream

This merge request affects 1 file:

• Trigger/TrigSteer/TrigHLTResultByteStream/src/HLTResultByteStreamCnv.cxx

Adding @tamartin ,@fpastore as watchers

added 24.0 review-pending-level-1 labels and removed review-user-action-required label

CI Result FAILURE (hash 165e0fcc)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5981] (remote access info)

The local build area got corrupted after the branch change. The tests that are failing are not enabled in 24.0. I cleaned the build node.

Jenkins please retry a build

resolved all threads

This merge request affects 1 package:

• Trigger/TrigSteer/TrigHLTResultByteStream

This merge request affects 1 file:

• Trigger/TrigSteer/TrigHLTResultByteStream/src/HLTResultByteStreamCnv.cxx

Adding @tamartin ,@fpastore as watchers

CI Result SUCCESS (hash 165e0fcc)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 5986] (remote access info)

Change is straightforward and has been reviewed by experts, so approving.

L1 shifter

added review-approved label and removed review-pending-level-1 label

added review-approved-point1 label

mentioned in commit aa0e05d4

merged

mentioned in merge request !69618 (merged)

mentioned in merge request !68171 (merged)