Skip to content
Snippets Groups Projects

including flag ExcludeNSWFromPrecisionLayers in the MuonCalibTool

Merged Luca Martinelli requested to merge lucam/athena:luca_ExcludeNSW_flagCalibTool into main
All threads resolved!

including flag ExcludeNSWFromPrecisionLayers to be passed to the MuonSelectionTool to run on older p-tags and recent releases cc @fballi @mungo

Merge request reports

Pipeline #6804174 passed

Pipeline passed for 46260cfe on lucam:luca_ExcludeNSW_flagCalibTool

Merged by Adam Edward BartonAdam Edward Barton 1 year ago (Jan 30, 2024 9:23am UTC)

Merge details

  • Changes merged into with 4cf75edb.
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • One small comment to address. Otherwise looks good. Lucy (L1)

  • Luca Martinelli added 1 commit

    added 1 commit

    Compare with previous version

  • Luca Martinelli resolved all threads

    resolved all threads

  • Luca Martinelli added 1 commit

    added 1 commit

    Compare with previous version

  • Luca Martinelli resolved all threads

    resolved all threads

  • Luca Martinelli resolved all threads

    resolved all threads

  • Luca Martinelli added 1 commit

    added 1 commit

    • 46260cfe - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • This merge request affects 1 package:

    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections

    This merge request affects 2 files:

    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/MuonMomentumCorrections/MuonCalibTool.h
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/Root/MuonCalibTool.cxx

    Adding @nicolaid ,@jojungge ,@sangelid ,@apsallid as watchers

  • This merge request affects 1 package:

    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections

    This merge request affects 2 files:

    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/MuonMomentumCorrections/MuonCalibTool.h
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/Root/MuonCalibTool.cxx

    Adding @apsallid ,@sangelid ,@nicolaid ,@jojungge as watchers

  • This merge request affects 1 package:

    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections

    This merge request affects 2 files:

    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/MuonMomentumCorrections/MuonCalibTool.h
    • PhysicsAnalysis/MuonID/MuonIDAnalysis/MuonMomentumCorrections/Root/MuonCalibTool.cxx

    Adding @apsallid ,@jojungge ,@nicolaid ,@sangelid as watchers

  • :white_check_mark: CI Result SUCCESS (hash 46260cfe)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3750]

  • Looks good to me. Lucy (L1)

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit 4cf75edb

  • Please register or sign in to reply
    Loading