Skip to content
Snippets Groups Projects

FTAG: Clean up onnx output configuration

Merged FTAG: Clean up onnx output configuration
svanstro/athena:svanstro/ftag-onnx-output-config into main
All threads resolved!
Merged Samuel Van Stroud requested to merge svanstro/athena:svanstro/ftag-onnx-output-config into main
All threads resolved!

Clearer and less redundant configuration for onnx outputs using a new OnnxOutput class, which combines the structs in GNNConfig with some related functions form OnnxUtil.

In the future the OnnxOutput class could also take ownership fo the decorations back to the atlas edm.

cc @dkobylia @dbiswas @dguest

Edited by Samuel Van Stroud

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Samuel Van Stroud added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants

    This merge request affects 9 files:

    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/CMakeLists.txt
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/DataPrepUtilities.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/GNNConfig.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/OnnxOutput.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/OnnxUtil.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/DataPrepUtilities.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/GNN.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/OnnxOutput.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/OnnxUtil.cxx
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash c18ab254)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3765]

  • Lucy Lewitt
  • Lucy Lewitt
  • Lucy Lewitt
  • Lucy Lewitt
  • Lucy Lewitt
  • Lucy Lewitt
    Lucy Lewitt @llewitt ·
    Developer

    I've made some initial suggestions but these aren't complete so future reviewers should still take a look over this before approving once all the threads are resolved. Lucy (L1)

  • Lucy Lewitt added review-user-action-required label and removed review-pending-level-1 label

    added review-user-action-required label and removed review-pending-level-1 label

  • Samuel Van Stroud added 1 commit

    added 1 commit

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants

    This merge request affects 9 files:

    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/CMakeLists.txt
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/DataPrepUtilities.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/GNNConfig.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/OnnxOutput.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/OnnxUtil.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/DataPrepUtilities.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/GNN.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/OnnxOutput.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/OnnxUtil.cxx
  • ATLAS Robot added review-pending-level-1 label and removed review-user-action-required label

    added review-pending-level-1 label and removed review-user-action-required label

  • Lucy Lewitt resolved all threads

    resolved all threads

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 8222b02d)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3783]

  • Samuel Van Stroud added 1 commit

    added 1 commit

    • 1a752869 - use const refs where possible

    Compare with previous version

  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    This merge request affects 1 package:

    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants

    This merge request affects 9 files:

    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/CMakeLists.txt
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/DataPrepUtilities.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/GNNConfig.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/OnnxOutput.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/FlavorTagDiscriminants/OnnxUtil.h
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/DataPrepUtilities.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/GNN.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/OnnxOutput.cxx
    • PhysicsAnalysis/JetTagging/FlavorTagDiscriminants/Root/OnnxUtil.cxx
  • ATLAS Robot
    ATLAS Robot @atlasbot ·
    Developer

    :white_check_mark: CI Result SUCCESS (hash 1a752869)

    Athena AnalysisBase AthAnalysis
    externals :white_check_mark: :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AnalysisBase: number of compilation errors 0, warnings 0
    :white_check_mark: AthAnalysis: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3787]

  • James Beacham
    James Beacham @jbeacham ·
    Developer

    The changes look okay and there are no issues with the CI. Approving from L1.

  • James Beacham added review-approved label and removed review-pending-level-1 label

    added review-approved label and removed review-pending-level-1 label

  • R
    Rui Yuan @ruyuan ·
    Developer

    Hi, looks fine, but ask expert for double check. Best

  • Rui Yuan added analysis-review-expert label and removed analysis-review-required label

    added analysis-review-expert label and removed analysis-review-required label

  • K
    Nils Erik Krumnack @krumnack ·
    Developer

    This seems fine to me, also seems like there would be no direct impact on analyzers. Approving for analysis.

    Cheers, Nils [Analysis RC]

  • Nils Erik Krumnack added analysis-review-approved label and removed analysis-review-expert label

    added analysis-review-approved label and removed analysis-review-expert label

  • Adam Edward Barton merged

    merged

  • Adam Edward Barton mentioned in commit a8628a20

    mentioned in commit a8628a20

  • Samuel Van Stroud mentioned in merge request !68540 (merged)

    mentioned in merge request !68540 (merged)

    • Please register or sign in to reply