Skip to content
Snippets Groups Projects

GeneratorFilters/DiPhotonFilter: Added a cut-off on the angle deltaR_yy between the two photons

Merged Romain Van Den Broucke requested to merge rovanden/athena:diPhotonFilter-deltaRcut into main
All threads resolved!

A selection on the angle deltaR_yy between the two photons has been added to DiPhotonFilter, allowing for selecting photons separated by an angle in a given range (min, max).

Merge request reports

Checking pipeline status.

Approval is optional

Merged by Adam Edward BartonAdam Edward Barton 1 year ago (Feb 1, 2024 3:30pm UTC)

Merge details

  • Changes merged into main with 444fcec7 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 5c05799f - GeneratorFilters/DiPhotonFilter: Change of variable initialization

    Compare with previous version

  • This merge request affects 1 package:

    • Generators/GeneratorFilters

    This merge request affects 2 files:

    • Generators/GeneratorFilters/GeneratorFilters/DiPhotonFilter.h
    • Generators/GeneratorFilters/src/DiPhotonFilter.cxx
  • :white_check_mark: CI Result SUCCESS (hash 5c05799f)

    Athena AthGeneration
    externals :white_check_mark: :white_check_mark:
    cmake :white_check_mark: :white_check_mark:
    make :white_check_mark: :white_check_mark:
    tests :white_check_mark: :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :white_check_mark: AthGeneration: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 3918]

  • James Beacham resolved all threads

    resolved all threads

  • Great; thanks. The changes look okay and there are no issues with the CI. Approving from L1.

  • added review-approved label and removed review-pending-level-1 label

  • mentioned in commit 444fcec7

  • Please register or sign in to reply
    Loading