Bugfix in the creation of the sTGC readout elements in the SQLite...

Bugfix in the creation of the sTGC readout elements in the SQLite configuration. Existing code contains logic error. Does not run in today's production.

This merge request affects 1 package:

• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry

This merge request affects 1 file:

• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/src/sTgcReadoutElement.cxx

Adding @jojungge ,@rosati ,@kluit ,@apsallid ,@pscholer ,@stavrop as watchers

added MuonSpectrometer main review-pending-level-1 labels

CI Result SUCCESS (hash 60f68cc6)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4011]

resolved all threads

added 1 commit

• ca34cde9 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

This merge request affects 1 package:

• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry

This merge request affects 1 file:

• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/src/sTgcReadoutElement.cxx

Adding @kluit ,@jojungge ,@apsallid ,@stavrop ,@rosati ,@pscholer as watchers

Just one thread to resolve but otherwise looks okay to me :). Lucy (L1)

added review-approved label and removed review-pending-level-1 label

added review-user-action-required label and removed review-approved label

added 1 commit

• d968463c - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

This merge request affects 1 package:

• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry

This merge request affects 1 file:

• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/src/sTgcReadoutElement.cxx

Adding @pscholer ,@kluit ,@jojungge ,@apsallid ,@rosati ,@stavrop as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI Result SUCCESS (hash ca34cde9)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4032]

CI Result SUCCESS (hash d968463c)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4033]

Changing label to review-user-action-required until the discussion is resolved. Clara (L1)

added review-user-action-required label and removed review-pending-level-1 label

added 1 commit

• 1afb85e8 - incorporate suggestion

Compare with previous version

This merge request affects 1 package:

• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry

This merge request affects 1 file:

• MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry/src/sTgcReadoutElement.cxx

Adding @apsallid ,@kluit ,@pscholer ,@rosati ,@stavrop ,@jojungge as watchers

added review-pending-level-1 label and removed review-user-action-required label

resolved all threads

CI Result SUCCESS (hash 1afb85e8)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4072]

Changes look fine, the CI is good and the threads are resolved. Approving. Clara (L1)

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit d332ab51