sTgcPrepData - Remove BCID tag

The variable is not needed in reconstruction. Tagging: @pscholer

This merge request affects 1 package:

• MuonSpectrometer/MuonReconstruction/MuonRecEvent/MuonPrepRawData

This merge request affects 2 files:

• MuonSpectrometer/MuonReconstruction/MuonRecEvent/MuonPrepRawData/MuonPrepRawData/sTgcPrepData.h
• MuonSpectrometer/MuonReconstruction/MuonRecEvent/MuonPrepRawData/src/sTgcPrepData.cxx

Adding @goetz ,@apsallid ,@jojungge ,@pscholer ,@rosati ,@stavrop ,@kluit as watchers

added MuonSpectrometer main review-pending-level-1 labels

CI integration tests for projects Athena are cancelled because of compilation error(s)

removed review-pending-level-1 label

added review-user-action-required label

CI Result FAILURE (hash 18c57a6d)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 5, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4030]

Following the creation of the 24.0 branch from main, you should now decide whether this MR should target 24.0 or main, according to these guidelines agreed in the Software Weekly meeting: https://indico.cern.ch/event/1382755/attachments/2802320/4889268/BranchingGuidelines24.pdf

If you decide that this MR should target 24.0, please re-direct it by editing and changing the target branch in the drop-down menu. If it should stay in master, please indicate this as a reply to this message. Remember that all MRs going into 24.0 will also be swept into main.

resolved all threads

added 2227 commits

• 18c57a6d...23fb305f - 2226 commits from branch atlas:main
• 22354eb7 - Merge branch athena:main into sTgcBcBitMap

Compare with previous version

Jenkins please retry a build

resolved all threads

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

This merge request affects 1 package:

• MuonSpectrometer/MuonReconstruction/MuonRecEvent/MuonPrepRawData

This merge request affects 2 files:

• MuonSpectrometer/MuonReconstruction/MuonRecEvent/MuonPrepRawData/MuonPrepRawData/sTgcPrepData.h
• MuonSpectrometer/MuonReconstruction/MuonRecEvent/MuonPrepRawData/src/sTgcPrepData.cxx

Adding @jojungge ,@goetz ,@stavrop ,@apsallid ,@rosati ,@pscholer ,@kluit as watchers

added review-pending-level-1 label and removed review-user-action-required label

added review-user-action-required label

CI integration tests for projects Athena are cancelled because of compilation error(s)

removed review-pending-level-1 label

CI Result FAILURE (hash 22354eb7)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 4, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6236] (remote access info)

added 1 commit

• ab60963f - Remove bcID tag

Compare with previous version

This merge request affects 5 packages:

• MuonSpectrometer/MuonCnv/MuonEventTPCnv
• MuonSpectrometer/MuonCnv/MuonSTGC_CnvTools
• MuonSpectrometer/MuonReconstruction/MuonDataPrep/STgcClusterization
• MuonSpectrometer/MuonReconstruction/MuonRecEvent/MuonPrepRawData
• MuonSpectrometer/MuonValidation/MuonPRDTest

Affected files list will not be printed in this case

Adding @jojungge ,@stavrop ,@kluit ,@goetz ,@apsallid ,@rosati ,@gemmeren ,@pscholer as watchers

added review-pending-level-1 label and removed review-user-action-required label

changed title from sTgcPrepData - Propagate BC bitMap to proper enum to sTgcPrepData - Remove BCID tag

changed the description

CI integration tests for projects Athena are cancelled because of compilation error(s)

CI Result FAILURE (hash ab60963f)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 2, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6322] (remote access info)

added 1 commit

• ab0c397a - Fix compiler

Compare with previous version

This merge request affects 6 packages:

• MuonSpectrometer/MuonCnv/MuonEventTPCnv
• MuonSpectrometer/MuonCnv/MuonSTGC_CnvTools
• MuonSpectrometer/MuonReconstruction/MuonDataPrep/STgcClusterization
• MuonSpectrometer/MuonReconstruction/MuonPatternFinders/MuonPatternFinderTools/MuonHoughPatternTools
• MuonSpectrometer/MuonReconstruction/MuonRecEvent/MuonPrepRawData
• MuonSpectrometer/MuonValidation/MuonPRDTest

Affected files list will not be printed in this case

Adding @apsallid ,@jojungge ,@rosati ,@pscholer ,@stavrop ,@gemmeren ,@goetz ,@kluit as watchers

WARNING: big files (>100K) are found in the changeset

128K in file MuonSpectrometer/MuonReconstruction/MuonPatternFinders/MuonPatternFinderTools/MuonHoughPatternTools/src/MuonLayerHoughTool.cxx

added Run3-DataReco-output-changed Run3-MCReco-output-changed labels

CI Result FAILURE (hash ab0c397a)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6329] (remote access info)

There are still test failures. I assume these are expected?

In that case the references would need to be updated.

Otherwise this all looks good to me.

Cheers L1

added RC Attention Required review-user-action-required labels and removed review-pending-level-1 label

Yep difference is expected

added 247 commits

• ab0c397a...bc5f4854 - 246 commits from branch atlas:main
• cb41c29f - Merge branch athena:main into sTgcBcBitMap

Compare with previous version

This merge request affects 6 packages:

• MuonSpectrometer/MuonCnv/MuonEventTPCnv
• MuonSpectrometer/MuonCnv/MuonSTGC_CnvTools
• MuonSpectrometer/MuonReconstruction/MuonDataPrep/STgcClusterization
• MuonSpectrometer/MuonReconstruction/MuonPatternFinders/MuonPatternFinderTools/MuonHoughPatternTools
• MuonSpectrometer/MuonReconstruction/MuonRecEvent/MuonPrepRawData
• MuonSpectrometer/MuonValidation/MuonPRDTest

Affected files list will not be printed in this case

Adding @kluit ,@rosati ,@apsallid ,@stavrop ,@goetz ,@pscholer ,@gemmeren ,@jojungge as watchers

added review-pending-level-1 label and removed review-user-action-required label

WARNING: big files (>100K) are found in the changeset

128K in file MuonSpectrometer/MuonReconstruction/MuonPatternFinders/MuonPatternFinderTools/MuonHoughPatternTools/src/MuonLayerHoughTool.cxx

CI Result FAILURE (hash cb41c29f)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 6429] (remote access info)

There are some CI failures. Please have a look.

Cheers, L1

removed review-pending-level-1 label

added review-user-action-required label

Hi @yvolkotr ,

according to the comment above, the output difference are expected. Please go ahead with the code review, once judge ok, I'll update the reference files.

Thanks, Walter (release coordinator this week)

removed review-user-action-required label

resolved all threads

added review-pending-level-1 label

Changes look fine. Approved.

Cheers, L1

removed review-pending-level-1 label

added review-approved label

Hi @jojungge,

there have been other updates of the q449 test since the CI ran. So we'll have to re-run the CI two more times on this one. Could you please rebase your branch to avoid a conflict and to trigger the first CI-round?

Thanks, Walter

added 57 commits

• cb41c29f...a4a3b2a9 - 56 commits from branch atlas:main
• 049f684b - Merge branch athena:main into sTgcBcBitMap

Compare with previous version