[ATR-28760] Correct the use of CloneAndReplace in trigger muon signature

The function returns a copy of the flag container with the modification.

The behaviour of the job is unchanged as the ID code contains a fall-back to call CloneAndReplace itself if not done by the signature code. Hence not flagging as bugfix.

cc @vippolit, @yoyamagu

Build area was cleaned as per request posted in the DB. The full software build will be performed

This merge request affects 1 package:

• Trigger/TriggerCommon/TriggerMenuMT

This merge request affects 1 file:

• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Muon/MuonRecoSequences.py

Adding @sutt ,@lidiaz as watchers

added Trigger TriggerMenu main review-pending-level-1 labels

Hey Tim, thanks for fixing this! There are two other places in that file with the same issue I think (five total). Any chance you can update them as well?

added 1 commit

• 818bc69b - update cloneAndReplace

Compare with previous version

resolved all threads

This merge request affects 1 package:

• Trigger/TriggerCommon/TriggerMenuMT

This merge request affects 1 file:

• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Muon/MuonRecoSequences.py

Adding @lidiaz ,@sutt as watchers

added 1 commit

• 17f44635 - update cloneAndReplace

Compare with previous version

This merge request affects 1 package:

• Trigger/TriggerCommon/TriggerMenuMT

This merge request affects 1 file:

• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Muon/MuonRecoSequences.py

Adding @sutt ,@lidiaz as watchers

CI Result FAILURE (hash 818bc69b)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4061]

CI Result FAILURE (hash 17f44635)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4063]

added 1 commit

• 8396995e - fix silly typo

Compare with previous version

This merge request affects 1 package:

• Trigger/TriggerCommon/TriggerMenuMT

This merge request affects 1 file:

• Trigger/TriggerCommon/TriggerMenuMT/python/HLT/Muon/MuonRecoSequences.py

Adding @lidiaz ,@sutt as watchers

CI Result SUCCESS (hash 770d4800)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4057]

CI Result SUCCESS (hash 8396995e)

	Athena
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4067]

Changes look fine and the CI is good. Approving. Clara (L1)

added review-approved label and removed review-pending-level-1 label

mentioned in commit b37b9eba

merged

mentioned in merge request !68643 (merged)

mentioned in commit 1152c489

mentioned in commit 36eca43c