Skip to content
Snippets Groups Projects

JetCalibTools: fix overflow/underflow in JMSCorrection

Merged Bertrand Martin Dit Latour requested to merge martindl/athena:JetCalibToolsFix into main

Hello,

This MR is fixing the treatment of underflows and overflows in JMSCorrection, and out-of-range interpolations. The problem was reported in ATEAM-955. Somehow in the trigger, it happens that we pass pT_uncorr=pTMax to getMassCorr. In that case, if ( pT_uncorr > pTMax ) pT_uncorr = pTMax-1e-6 ; does nothing, and m_respFactorsMass[etabin]->Interpolate( pT_uncorr, mass_uncorr ); complains that we're out of the validity range. So I changed > to >= and < to <=.

Cheers, Bertrand

Merge request reports

Pipeline #6851427 passed

Pipeline passed for cc996825 on martindl:JetCalibToolsFix

Approval is optional

Merged by Tadej NovakTadej Novak 1 year ago (Feb 7, 2024 1:15pm UTC)

Merge details

  • Changes merged into main with 49109979 (commits were squashed).
  • Deleted the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading