Fix phi() method in the gfex jet EDM

With this MR the phi() method that, given the index, returns the float value of phi for the gFEX jet EDM is updated. The update is necessary to account for a recombination of the input towers in the most forward region covered by gFEX. The recombination was introduced in the gFEX simulation with !67016 (merged).

This merge request affects 2 packages:

• Event/xAOD/xAODTrigger
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

Affected files list will not be printed in this case

Adding @tamartin ,@thompson ,@will ,@akraszna as watchers

added EDM JetEtmiss L1Calo Trigger analysis-review-required main review-pending-level-1 labels

CI Result FAILURE (hash 39b17fb6)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4141]

I am retrying a build I cannot access the log of the CI and it feels weird pipelines are failing for this MR - AR shifter

Jenkins please retry a build

This merge request affects 2 packages:

• Event/xAOD/xAODTrigger
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

Affected files list will not be printed in this case

Adding @akraszna ,@will ,@tamartin ,@thompson as watchers

There is a unit test failure - looks like it needs some checking

1/2 Test #231: xAODTrigger_ut_xaodtrigger_gFexEDM_test_ctest .....................***Failed    0.12 sec
Initializing test object: jet TOB
Match failure: 0.687223 1.37445 (0.333333)
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/Event/xAOD/xAODTrigger/test/ut_xaodtrigger_gFexEDM_test.cxx:62 Failed test: Athena_test::isEqual (obj->phi_gFex(), static_cast<float>(3*(2*M_PI/16)+(2*M_PI/(16*2))) )
terminate called after throwing an instance of 'std::runtime_error'
  what():  Failed Athena_test::isEqual (obj->phi_gFex(), static_cast<float>(3*(2*M_PI/16)+(2*M_PI/(16*2))) )
Initializing test object: jet TOB
Match failure: 0.687223 1.37445 (0.333333)
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/Event/xAOD/xAODTrigger/test/ut_xaodtrigger_gFexEDM_test.cxx:62 Failed test: Athena_test::isEqual (obj->phi_gFex(), static_cast<float>(3*(2*M_PI/16)+(2*M_PI/(16*2))) )
terminate called after throwing an instance of 'std::runtime_error'
  what():  Failed Athena_test::isEqual (obj->phi_gFex(), static_cast<float>(3*(2*M_PI/16)+(2*M_PI/(16*2))) )
[97;101;1m post.sh> ERROR: Test ut_xaodtrigger_gFexEDM_test failed with exit code: 134[m
 post.sh> Please check /build/ci-builds/main/AnalysisBase/build/AnalysisBase/Event/xAOD/xAODTrigger/CMakeFiles/unitTestRun/ut_xaodtrigger_gFexEDM_test.log

Tim

added review-user-action-required label and removed review-pending-level-1 label

CI Result FAILURE (hash 39b17fb6)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4144]

added 1 commit

• f76ac325 - Update gFEX EDM test

Compare with previous version

This merge request affects 2 packages:

• Event/xAOD/xAODTrigger
• Trigger/TrigT1/L1CaloFEX/L1CaloFEXSim

Affected files list will not be printed in this case

Adding @akraszna ,@thompson ,@will ,@tamartin as watchers

added review-pending-level-1 label and removed review-user-action-required label

resolved all threads

Jenkins please retry a build

There were multiple CI triggers for this MR and commit. The system ignored duplicates but the GitLab pipeline status may incorrectly show the job as failed. Once the remaining job finished running, the CI results will be posted as usual.

CI Result SUCCESS (hash f76ac325)

	Athena	AnalysisBase	AthAnalysis
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AnalysisBase: number of compilation errors 0, warnings 0
AthAnalysis: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4209]

Changes looks good and pipeline all green now so approving - AR

removed analysis-review-required label

added analysis-review-approved label

MR looks good to me, approving.

Cheers, Yuriy (L1)

removed review-pending-level-1 label

added review-approved label

merged

mentioned in commit 1e50441c