MuonGeoModel - Do not add the auxillary GeoModelTrees to the world volume

In the current MuonGeoModel, the readout geometry is rebuilt every time when the alignment IOV boundaries are crossed. Usually, that's happening once in a job or so. However, the auxillary GeoModel tree is appended to the root volume node of ATLAS. That's causing a problem if the input data is kind of shuffled as it's in the Mdt calibration stream and the geometry is rebuilt again and again. This patch completely disconnects the auxillary GeoModel tree from the ATLAS world volume and should hence ensure that the auxillary GeoModel tree is deleted once the alignment IOVs go out of scope. The useage of PVLink already assumes the smart pointer useage which is coming with !68268 (merged).

Tagging: @diehl, @zyan, @pscholer

changed the description

added full-unit-tests label

added 1 commit

• 8ece2b1a - Fixed typo

Compare with previous version

This merge request affects 2 packages:

• MuonSpectrometer/MuonConfig
• MuonSpectrometer/MuonGeoModel

Affected files list will not be printed in this case

Adding @pscholer ,@rosati ,@kluit ,@jojungge ,@apsallid ,@stavrop as watchers

added MuonSpectrometer main review-pending-level-1 labels

This merge request affects 2 packages:

• MuonSpectrometer/MuonConfig
• MuonSpectrometer/MuonGeoModel

Affected files list will not be printed in this case

Adding @kluit ,@stavrop ,@apsallid ,@jojungge ,@pscholer ,@rosati as watchers

added 1 commit

• 6b70a1bc - Put the patch after the SQLite check

Compare with previous version

added full-build label

removed full-build label

This merge request affects 2 packages:

• MuonSpectrometer/MuonConfig
• MuonSpectrometer/MuonGeoModel

Affected files list will not be printed in this case

Adding @kluit ,@rosati ,@apsallid ,@pscholer ,@stavrop ,@jojungge as watchers

CI integration tests for projects Athena,AthSimulation are cancelled because of compilation error(s)

CI integration tests for projects Athena,AthSimulation are cancelled because of compilation error(s)

CI Result FAILURE (hash 8ece2b1a)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 1, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4214]

CI Result FAILURE (hash 6b70a1bc)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 1, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4215]

CI integration tests for projects Athena,AthSimulation are cancelled because of compilation error(s)

CI Result FAILURE (hash 8719171e)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 0
AthSimulation: number of compilation errors 1, warnings 2
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4213]

MR is given back to the developer due to CI failures.

From the log there is the output

/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/MuonSpectrometer/MuonGeoModel/src/MuonDetectorTool.cxx:151:15: error: 'PVLink' {aka 'class GeoPVLink'} has no member named 'reset'
151 |         world.reset(new GeoPhysVol(world->getLogVol()));
|               ^~~~~
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/MuonSpectrometer/MuonGeoModel/src/MuonDetectorTool.cxx:166:25: error: cannot convert 'PVLink' {aka 'GeoPVLink'} to 'GeoPhysVol*'
166 |       theFactory.create(world);
|                         ^~~~~
|                         |
|                         PVLink {aka GeoPVLink}
In file included from /var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/MuonSpectrometer/MuonGeoModel/src/MuonDetectorTool.cxx:18:
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/MuonSpectrometer/MuonGeoModel/MuonGeoModel/MuonDetectorFactoryLite.h:30:41: note:   initializing argument 1 of 'virtual void MuonGM::MuonDetectorFactoryLite::create(GeoPhysVol*)'
30 |         virtual void create(GeoPhysVol *world) override;
|                             ~~~~~~~~~~~~^~~~~
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/MuonSpectrometer/MuonGeoModel/src/MuonDetectorTool.cxx:313:31: error: cannot convert 'PVLink' {aka 'GeoPVLink'} to 'GeoPhysVol*'
313 |             theFactory.create(world);
|                               ^~~~~
|                               |
|                               PVLink {aka GeoPVLink}
In file included from /var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/MuonSpectrometer/MuonGeoModel/src/MuonDetectorTool.cxx:17:
/var/lib/jenkins/workspace/CI-MERGE-REQUEST-EL9/main/MuonSpectrometer/MuonGeoModel/MuonGeoModel/MuonDetectorFactory001.h:33:41: note:   initializing argument 1 of 'virtual void MuonGM::MuonDetectorFactory001::create(GeoPhysVol*)'
33 |         virtual void create(GeoPhysVol *world) override;

Cheers, Yuriy (L1)

added review-user-action-required label

removed review-pending-level-1 label

Yep, I know that. I need to wait until the bump to GeoModel happened

Jenkinsp please retry a build

Jenkins please retry a build

This merge request affects 2 packages:

• MuonSpectrometer/MuonConfig
• MuonSpectrometer/MuonGeoModel

Affected files list will not be printed in this case

Adding @jojungge ,@pscholer ,@stavrop ,@rosati ,@kluit ,@apsallid as watchers

added review-pending-level-1 label and removed review-user-action-required label

CI integration tests for projects Athena,AthSimulation are cancelled because of compilation error(s)

CI Result FAILURE (hash 6b70a1bc)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 1, warnings 2
AthSimulation: number of compilation errors 1, warnings 1
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4320]

resolved all threads

added full-integration-tests label

added 1 commit

• 40fdc456 - Apply 1 suggestion(s) to 1 file(s)

Compare with previous version

This merge request affects 2 packages:

• MuonSpectrometer/MuonConfig
• MuonSpectrometer/MuonGeoModel

Affected files list will not be printed in this case

Adding @rosati ,@apsallid ,@jojungge ,@kluit ,@stavrop ,@pscholer as watchers

CI Result SUCCESS (hash 40fdc456)

	Athena	AthSimulation
externals
cmake
make
tests

Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4341]

The changes look okay and there are no issues with the CI; the externals warning is from ATLINFR-5244. Approving from L1.

added review-approved label and removed review-pending-level-1 label

merged

mentioned in commit 39a06692

mentioned in merge request !68816 (merged)