Adding draft GENtoEVGEN_Skeleton module and cleanup of unused arguments for Gen_tf
- Removed following unused arguments from
Gen_tf
. If the user provides theseGen_tf.py
will immediately crash saying that these arguments are not recognised--inputGenConfFile
--runNumber
- Added
skeletonCA
options inevgenExecutor
- Added dummy file for
GENtoEVGEN_Skeleton.py
that will be later populated (see !67233 (closed))
Tested on 421007 that runs on the CI also the new Gen_tf.py --CA
option and it runs
PS: we can also take this opportunity to maybe do a bit of cleanup including some stylistic fixes in Gen_tf.py
? (or in a separate MR)
Merge request reports
Activity
added Generators label
This merge request affects 1 package:
- Generators/EvgenJobTransforms
This merge request affects 6 files:
- Generators/EvgenJobTransforms/python/GENtoEVGEN_Skeleton.py
- Generators/EvgenJobTransforms/python/evgenTrfArgs.py
- Generators/EvgenJobTransforms/scripts/Gen_tf.py
- Generators/EvgenJobTransforms/share/skel.ABtoEVGEN.py
- Generators/EvgenJobTransforms/share/skel.GENtoEVGEN.py
- Generators/EvgenJobTransforms/share/skel.GENtoTXT.py
added main review-pending-level-1 labels
- Resolved by Spyros Argyropoulos
Can we, please, keep a default value for ecmEnergy - it really simplifies testing. The idea was that one can run test with minimal number of parameters (at present evgenConfig, maxEvents and outputEVNTFile).
CI Result SUCCESS (hash a0d85702)Athena AthGeneration externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4246]This merge request affects 1 package:
- Generators/EvgenJobTransforms
This merge request affects 6 files:
- Generators/EvgenJobTransforms/python/GENtoEVGEN_Skeleton.py
- Generators/EvgenJobTransforms/python/evgenTrfArgs.py
- Generators/EvgenJobTransforms/scripts/Gen_tf.py
- Generators/EvgenJobTransforms/share/skel.ABtoEVGEN.py
- Generators/EvgenJobTransforms/share/skel.GENtoEVGEN.py
- Generators/EvgenJobTransforms/share/skel.GENtoTXT.py
CI Result SUCCESS (hash 9973b847)Athena AthGeneration externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthGeneration: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4249]added review-approved label and removed review-pending-level-1 label
mentioned in commit 98606475