Skip to content
Snippets Groups Projects

Acts Track container reading helper algorithm

Merged Tomasz Bold requested to merge tbold/athena:track-container-reading into main

Purpose of this algorithm is to load Track Container backends and construct ActsTrk and Acts classes used by ACTS algorithmic code.

Followups:

  • check surfaces
  • cleanup (I consider renaming helper classes)
  • symmetrise use of Aux versus interface containers

@wolter - FYI it seems the surfaces conversion is happy with just Acts::GeometryContext - I have simplified the code for it.

Edited by Tomasz Bold

Merge request reports

Pipeline #6979244 passed

Pipeline passed for 814835ac on tbold:track-container-reading

Approval is optional

Merged by Tadej NovakTadej Novak 1 year ago (Feb 29, 2024 6:47pm UTC)

Merge details

  • Changes merged into with b5da77e0.
  • Did not delete the source branch.

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Just a few minor points to consider but overall it looks good.

    Best, Thomas - L2

  • Tomasz Bold added 1 commit

    added 1 commit

    Compare with previous version

  • This merge request affects 3 packages:

    • Tracking/Acts/ActsCollectionAlgs
    • Tracking/Acts/ActsConfig
    • Tracking/Acts/ActsEvent

    Affected files list will not be printed in this case

    Adding @toyamaza ,@adye ,@pagessin ,@tbold ,@cvarni ,@jojungge as watchers

  • :white_check_mark: CI Result SUCCESS (hash 5c8a7632)

    Athena
    externals :white_check_mark:
    cmake :white_check_mark:
    make :white_check_mark:
    tests :white_check_mark:

    Full details available on this CI monitor view. Check the JIRA CI status board for known problems
    :white_check_mark: Athena: number of compilation errors 0, warnings 0
    :pencil: For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4555]

  • Tomasz Bold resolved all threads

    resolved all threads

  • Lucy Lewitt
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading