DetectorManagers - Remove ref & unref calls
The PVLink & PVConstLink are doing the reference counting by themselves now. No need to call ref/unref on the RCBase objects
Merge request reports
Activity
This merge request affects 7 packages:
- AtlasGeometryCommon/CavernInfraGeoModel
- ForwardDetectors/ALFA/ALFA_GeoModel
- ForwardDetectors/LUCID/LUCID_GeoModel
- ForwardDetectors/ZDC/ZDC_GeoM
- InnerDetector/InDetDetDescr/TRT_ReadoutGeometry
- MuonSpectrometer/MuonCnv/MuonEventTPCnv
- MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
Affected files list will not be printed in this case
Adding @gemmeren ,@jojungge ,@sroe ,@pscholer ,@stavrop ,@goetz ,@rosati ,@calfayan ,@kluit ,@apsallid ,@cgrefe ,@rbianchi as watchers
- Resolved by Johannes Junggeburth
I may be getting paranoid about these things but how about we run another round of CI (after the first one finishes) with full-integration-tests and full-unit-tests?
added full-integration-tests full-unit-tests labels
added 19 commits
-
61e7e37a...8f55c354 - 18 commits from branch
atlas:main
- 7b83c383 - Merge branch athena:main into RemRefUnRefDetMgrs
-
61e7e37a...8f55c354 - 18 commits from branch
CI Result SUCCESS (hash 61e7e37a)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4323]This merge request affects 7 packages:
- AtlasGeometryCommon/CavernInfraGeoModel
- ForwardDetectors/ALFA/ALFA_GeoModel
- ForwardDetectors/LUCID/LUCID_GeoModel
- ForwardDetectors/ZDC/ZDC_GeoM
- InnerDetector/InDetDetDescr/TRT_ReadoutGeometry
- MuonSpectrometer/MuonCnv/MuonEventTPCnv
- MuonSpectrometer/MuonDetDescr/MuonReadoutGeometry
Affected files list will not be printed in this case
Adding @jojungge ,@gemmeren ,@pscholer ,@calfayan ,@goetz ,@apsallid ,@rosati ,@sroe ,@rbianchi ,@stavrop ,@kluit ,@cgrefe as watchers
CI Result SUCCESS (hash 7b83c383)Athena AthSimulation externals cmake make tests Full details available on this CI monitor view. Check the JIRA CI status board for known problems
Athena: number of compilation errors 0, warnings 0
AthSimulation: number of compilation errors 0, warnings 0
For experts only: Jenkins output [CI-MERGE-REQUEST-EL9 4339]The changes look okay and there are no issues with the CI; the externals warning is from ATLINFR-5244. Approving from L1.
added review-approved label and removed review-pending-level-1 label
mentioned in commit fe70c7ba